[PATCH v4] spi: xilinx: use device property accessors.

[PATCH v4] spi: xilinx: use device property accessors.

[Abdurrahman Hussain via B4 Relay]

From: Abdurrahman Hussain <abdurrahman@nexthop.ai>

Switch to device property accessors.

Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
---
Switch to generic device property accessors.

2.52.0

base-commit: 944aacb68baf7624ab8d277d0ebf07f025ca137c
---
Changes in v4:
- Removed patches making the irq optional.
- Link to v3: https://lore.kernel.org/r/20260122-spi-xilinx-v3-1-8cea20e82f0b@nexthop.ai
---
 drivers/spi/spi-xilinx.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index c86dc56f38b4..c4b70e95b695 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -405,11 +405,11 @@ static int xilinx_spi_probe(struct platform_device *pdev)
 		bits_per_word = pdata->bits_per_word;
 		force_irq = pdata->force_irq;
 	} else {
-		of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
-					  &num_cs);
-		ret = of_property_read_u32(pdev->dev.of_node,
-					   "xlnx,num-transfer-bits",
-					   &bits_per_word);
+		device_property_read_u32(&pdev->dev, "xlnx,num-ss-bits",
+					 &num_cs);
+		ret = device_property_read_u32(&pdev->dev,
+					       "xlnx,num-transfer-bits",
+					       &bits_per_word);
 		if (ret)
 			bits_per_word = 8;
 	}

---
base-commit: 944aacb68baf7624ab8d277d0ebf07f025ca137c
change-id: 20260118-spi-xilinx-1b884d5b6519

Best regards,
-- 
Abdurrahman Hussain <abdurrahman@nexthop.ai>

Re: [PATCH v4] spi: xilinx: use device property accessors.

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

On Tue, Feb 03, 2026 at 01:55:12AM +0000, Abdurrahman Hussain via B4 Relay wrote:
> ---
> Changes in v4:
> - Removed patches making the irq optional.
> - Link to v3: https://lore.kernel.org/r/20260122-spi-xilinx-v3-1-8cea20e82f0b@nexthop.ai
> ---

That was the changelog for v3 as well (and you dropped the changelog for
v3...).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v4] spi: xilinx: use device property accessors.

[Abdurrahman Hussain]

> On Feb 3, 2026, at 4:48 AM, Mark Brown <broonie@kernel.org> wrote:
> 
> On Tue, Feb 03, 2026 at 01:55:12AM +0000, Abdurrahman Hussain via B4 Relay wrote:
>> ---
>> Changes in v4:
>> - Removed patches making the irq optional.
>> - Link to v3: https://lore.kernel.org/r/20260122-spi-xilinx-v3-1-8cea20e82f0b@nexthop.ai
>> ---
> 
> That was the changelog for v3 as well (and you dropped the changelog for
> v3…).

Sorry, I haven’t realized v3 was the same. Do you want me to change anything in this patch?

Re: [PATCH v4] spi: xilinx: use device property accessors.

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

On Tue, Feb 03, 2026 at 10:16:46AM -0800, Abdurrahman Hussain wrote:
> > On Feb 3, 2026, at 4:48 AM, Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Feb 03, 2026 at 01:55:12AM +0000, Abdurrahman Hussain via B4 Relay wrote:

> >> ---
> >> Changes in v4:
> >> - Removed patches making the irq optional.
> >> - Link to v3: https://lore.kernel.org/r/20260122-spi-xilinx-v3-1-8cea20e82f0b@nexthop.ai
> >> ---

> > That was the changelog for v3 as well (and you dropped the changelog for
> > v3…).

> Sorry, I haven’t realized v3 was the same. Do you want me to change anything in this patch?

No, it's more just understanding what the change is.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v4] spi: xilinx: use device property accessors.

[Jonathan Cameron]

On Tue, 03 Feb 2026 01:55:12 +0000
Abdurrahman Hussain via B4 Relay <devnull+abdurrahman.nexthop.ai@kernel.org> wrote:

> From: Abdurrahman Hussain <abdurrahman@nexthop.ai>
> 
> Switch to device property accessors.
> 
> Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
> ---
> Switch to generic device property accessors.
> 
> 2.52.0
> 
> base-commit: 944aacb68baf7624ab8d277d0ebf07f025ca137c
> ---
> Changes in v4:
> - Removed patches making the irq optional.
> - Link to v3: https://lore.kernel.org/r/20260122-spi-xilinx-v3-1-8cea20e82f0b@nexthop.ai
> ---
>  drivers/spi/spi-xilinx.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index c86dc56f38b4..c4b70e95b695 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -405,11 +405,11 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>  		bits_per_word = pdata->bits_per_word;
>  		force_irq = pdata->force_irq;
>  	} else {
> -		of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> -					  &num_cs);
> -		ret = of_property_read_u32(pdev->dev.of_node,
> -					   "xlnx,num-transfer-bits",
> -					   &bits_per_word);
> +		device_property_read_u32(&pdev->dev, "xlnx,num-ss-bits",
> +					 &num_cs);
> +		ret = device_property_read_u32(&pdev->dev,

Nothing useful is done with ret after this point, so could simplify to
the pattern of setting the default then overriding it if the property
can be successfully read.

		bits_per_word = 8;
		device_property_read_u32(&pdev->dev,
					 "xlnx,num-transfer-bits",
					 &bits_per_word);

> +					       "xlnx,num-transfer-bits",
> +					       &bits_per_word);
>  		if (ret)
>  			bits_per_word = 8;
>  	}
> 
> ---
> base-commit: 944aacb68baf7624ab8d277d0ebf07f025ca137c
> change-id: 20260118-spi-xilinx-1b884d5b6519
> 
> Best regards,

Re: [PATCH v4] spi: xilinx: use device property accessors.

[Mark Brown]

On Tue, 03 Feb 2026 01:55:12 +0000, Abdurrahman Hussain wrote:
> Switch to device property accessors.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: xilinx: use device property accessors.
      commit: 4cc4ace709860c37f7f8019e950380a4694eb101

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark