From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7B0274B3A for ; Wed, 4 Feb 2026 10:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770200140; cv=none; b=I8F5VTFvdHgFXooqHMEQA2hww56Cg9QbtkePqexeblBO8Dsn4iyJ7ySLUgUirDdE/RTjFP1cNkt5QRvPnkONGH2NS5nIixGPIq+WOumrDTc1Gb38YBTi8gPJioxjZZgNXXXrPz28Ds139IpaWuE7SOmDxkMjeeDSwZz1XjG4A8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770200140; c=relaxed/simple; bh=NJMipCWPPkbj4WJnOqnxKMKjoUwaGTR3HXIqrY4PdKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S8Kex4eWnFZzavSFCaJxtaboAflVER0JgfxruwSYNQsnUSXlHlXSrsVh5+l/jQ6zlZ+2CZT7X7Exxo/Hd/G6WQii7vrtGlZit2Qpklsiwl9IufpMAGkvPXKXCk50DS+RRQ12FNRChoVrROEjp3Nasjf2I+JVJekPkNm4CnQjbeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VETZpJqq; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VETZpJqq" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b8849dc12f6so953904066b.1 for ; Wed, 04 Feb 2026 02:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770200139; x=1770804939; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kqepZHcW5XTj/gQ8gyyG9cWC23UM/f9Mcrtff0UNsoU=; b=VETZpJqqcaLMdXktzYrwfokyg26qchnppmTz851cc7PWY4+pr3kcw+5XbClrRSjKo8 Q1/s+0DrIQpg8E9eB2J3KHrj4gdyMqUDeojw1cLlKeTxeBKIbxD05bdwlkEPVutQgwAO qczR1WL2bQZDp5ZTo1BAu67Mp/SFiucxVHaqRfG6rLI//07qP0ZGdjork4agtp1X/9c8 IPM79jLJk5pL03sTPzXvneXuOy5106Nk5zJfO+c1TNqq8HI8bbPbtdeuOUzlLJHv7XIB 8Qrz481lB0sY2431uGtO+DQgojKh3U08xj6X3lhdP4QK1DcWhNFUDerhV5Bu5xohnvQC eQtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770200139; x=1770804939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kqepZHcW5XTj/gQ8gyyG9cWC23UM/f9Mcrtff0UNsoU=; b=jReOJGDXskPEq6tJ8vx1O6eqoAk/nHJccxavS+Nv04Sy4YJtODw/TcEtUqvAwlwF9w 82hf9iPeF7CAi2kf+J2ocQL+4pzfAXvZv9AEDw61v1sXuR1VUOe8qcr0RUWWaXB3KIJm t0Be1B2tw/3mDXEzx2xhdn+fARZaJLHQ5Mnyid/iFvu3eWS4FJX68WxgheUf3+BMx37h 0nZ6+j2Xt7Ir5+PCuhNECjE3Jit2fH5jrTXMkUPPcwCsnCmBFQy2VfQ4wt1SDwRCFQw0 WomqrRpqGmq0zAqeIVck3eLe2yWKlmgWGEQbXJ0oIifvzKnKCISqF3kJfxjJq8s3qQ3L FlAw== X-Forwarded-Encrypted: i=1; AJvYcCVg8m2fV+M4O6ex+7wcvNPIBmhzGQ886CjmEtFdU7DADa66o8ZoOKcasEXhtfxGdYvkVosZ0RGes4mOKvE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1KdP7gtYS+3klAdNV/zJBqLPDJyCIg9yY4wW9bDKRM29pYvhC pNVFqXH5a5vsGntmeohcLVZKPsWPTxGS0OW//t7b8UgnmFzanPKjaiGxONJP3qZUb8s5h2Qg X-Gm-Gg: AZuq6aKa3AA+7800w/S/mDPrxvgYiD2DAS86KKHxMOxqnUdsE2/pASyAAXfX8VsNJKf JGnkrxHLEb8XlYO1ykgkKqYItNz5SoISjmM/pIZtsZjFn2QTQvY/6RMWM8XbXOL5zIhcecnvf6Y 9qf1VMrfWgzxw9WxzB2v7CE9l5gAOpcTVb9cxa+uZ9QX2easjYIZx0MT2tCFwb6dFldXgbjPyhl F3SPL5XEM0fSxkL0OlEm6Jzxktmb/zDORaH5J/n8MvGRxN1ETrfloZq8Khq5qqm0DWkx5E/JsKE SSHnsMNIOYiJAEDgk7LWAiiQOEIKXJVisBlqBNewFkJ8eUHUbzSvtKlYrzxY53fhe4QiBUm+BdP CCjT/0KFhOFiemqdPHG0yL2VLmh4GY0cT7fYRnog1vqN4BXbFVXB1bgCtEOJJxvuKWXCZe4Uccr GZL8ASdvkag+wAtuFId536wKbv1xTqbCDYs1qDSzN19JGFPEPuF+vfOiDt4vSDOrp+3tQsD3f+e mwwrd0RivEu07QtEEgulorMLzn7rgQ7bmUJA4dj3+ykiOf5Knsdk/RUqaxboA== X-Received: by 2002:a17:906:f582:b0:b8a:f91e:283b with SMTP id a640c23a62f3a-b8e9f32c168mr163757766b.60.1770200138359; Wed, 04 Feb 2026 02:15:38 -0800 (PST) Received: from cs-874966990260-default.europe-west4-b.c.od237066db22328bb-tp.internal (181.183.90.34.bc.googleusercontent.com. [34.90.183.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e9fef0e17sm106440366b.33.2026.02.04.02.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 02:15:37 -0800 (PST) From: Artem Lytkin To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH v2 2/4] staging: sm750fb: use strcmp() for exact option matching Date: Wed, 4 Feb 2026 10:15:34 +0000 Message-ID: <20260204101536.3311-2-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204101536.3311-1-iprintercanon@gmail.com> References: <20260204101536.3311-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace strncmp(opt, "...", strlen("...")) with strcmp() in option parsing functions. Options from strsep() are complete null-terminated tokens, so prefix matching via strncmp() could cause false positives for options like "noaccelXYZ" matching "noaccel". Signed-off-by: Artem Lytkin --- drivers/staging/sm750fb/sm750.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 0eacb522d..73d78f893 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -937,21 +937,21 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt); dev_info(&sm750_dev->pdev->dev, "src=%s\n", src); - if (!strncmp(opt, "swap", strlen("swap"))) { + if (!strcmp(opt, "swap")) { swap = 1; - } else if (!strncmp(opt, "nocrt", strlen("nocrt"))) { + } else if (!strcmp(opt, "nocrt")) { sm750_dev->nocrt = 1; - } else if (!strncmp(opt, "36bit", strlen("36bit"))) { + } else if (!strcmp(opt, "36bit")) { sm750_dev->pnltype = sm750_doubleTFT; - } else if (!strncmp(opt, "18bit", strlen("18bit"))) { + } else if (!strcmp(opt, "18bit")) { sm750_dev->pnltype = sm750_dualTFT; - } else if (!strncmp(opt, "24bit", strlen("24bit"))) { + } else if (!strcmp(opt, "24bit")) { sm750_dev->pnltype = sm750_24TFT; - } else if (!strncmp(opt, "nohwc0", strlen("nohwc0"))) { + } else if (!strcmp(opt, "nohwc0")) { g_hwcursor &= ~0x1; - } else if (!strncmp(opt, "nohwc1", strlen("nohwc1"))) { + } else if (!strcmp(opt, "nohwc1")) { g_hwcursor &= ~0x2; - } else if (!strncmp(opt, "nohwc", strlen("nohwc"))) { + } else if (!strcmp(opt, "nohwc")) { g_hwcursor = 0; } else { if (!g_fbmode[0]) { @@ -1156,11 +1156,11 @@ static int __init lynxfb_setup(char *options) */ while ((opt = strsep(&options, ":")) != NULL) { /* options that mean for any lynx chips are configured here */ - if (!strncmp(opt, "noaccel", strlen("noaccel"))) { + if (!strcmp(opt, "noaccel")) { g_noaccel = 1; - } else if (!strncmp(opt, "nomtrr", strlen("nomtrr"))) { + } else if (!strcmp(opt, "nomtrr")) { g_nomtrr = 1; - } else if (!strncmp(opt, "dual", strlen("dual"))) { + } else if (!strcmp(opt, "dual")) { g_dualview = 1; } else { size_t opt_len = strlen(opt); -- 2.43.0