From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75C182BD012; Wed, 4 Feb 2026 15:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770218915; cv=none; b=XBkb2m6Xq/B3jEiRV4NvrP8yv11coRBCx/NRFt3v79PT9fVM3vDndvYkPRgCY5tiCIJ/5ytEpes7tPanrbwoMMrn9KgrWZT7EYt++46Yfl6DcGR0RDe9rbItW01/z6FD/7sqdnofzovI9mEtvRuk012jmY6ky5VZ1Gin1kVi6Eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770218915; c=relaxed/simple; bh=8b7NEE0pg/AHJ7XBOifwnvN2QzfrWc6nJZvHlB+YsXo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pFLmk+3tO6lETBuOTDPL+gYR44fNq5AytIRp7abDsg/wgpFcH6OyhQMPjKvsla+L//C9ll+Qbjy5VlEzCMUsUVqlYGeEwT+g4ezZ/uqBs+VRFIG+/kB7isrPTTWLYJkFX8BM1Kjkb/LQA/g8T53Knw6vVQUjK1DRWhDduNgQnrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=b0Vm94fL; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="b0Vm94fL" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--ff4.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::ff4]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5C1325B2; Wed, 4 Feb 2026 16:27:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770218871; bh=8b7NEE0pg/AHJ7XBOifwnvN2QzfrWc6nJZvHlB+YsXo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b0Vm94fLIs+83Fk6V4H4NAhZAPn8f+D8O3tIrhgLiGgziGvTVnCBLJjqUJVW3rzSI cS/XrjCViIC+KBTsZ/XitinuPNHB6CFjOGE06d/F/0PZEozrslR+1EXU0o4F4CbGM/ eiASLTINLyyFKJ/kWY66M7R67dgsc0KH1iarS8MY= Date: Wed, 4 Feb 2026 17:28:31 +0200 From: Laurent Pinchart To: Isaac Scott Cc: linux-media@vger.kernel.org, dafna@fastmail.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 4/6] media: rkisp1-isp: Propagate sink -> source format in YUV passthough Message-ID: <20260204152831.GA170964@killaraus> References: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> <20260204112506.3706049-5-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260204112506.3706049-5-isaac.scott@ideasonboard.com> On Wed, Feb 04, 2026 at 11:25:04AM +0000, Isaac Scott wrote: > If we are in bypass mode, we should propagate the sink format of the ISP > to the source format to ensure the pipeline is valid. Ensure the source > pad format of the ISP is configured to the same format as the sink pad. > > Signed-off-by: Isaac Scott > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > index 716bd7f3c66d..c457593526c5 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > @@ -630,6 +630,11 @@ static void rkisp1_isp_set_src_fmt(struct rkisp1_isp *isp, > */ > sink_info = rkisp1_mbus_info_get_by_code(sink_fmt->code); > A comment would be useful here, or maybe better a rework of the comment block just above. > + if (sink_info->pixel_enc == V4L2_PIXEL_ENC_YUV) { > + format->code = sink_fmt->code; > + dev_dbg(isp->rkisp1->dev, "ISP sink pad is YUV"); Drop the debug message. > + } > + > src_fmt->code = format->code; > src_info = rkisp1_mbus_info_get_by_code(src_fmt->code); > if (!src_info || !(src_info->direction & RKISP1_ISP_SD_SRC)) { -- Regards, Laurent Pinchart