[PATCH 1/2] docs: media: maintainer-entry-profile: do some editorial reviews

[PATCH 1/2] docs: media: maintainer-entry-profile: do some editorial reviews

[Mauro Carvalho Chehab]

Do some editorial improvements to the Media Subsystem Profile
documentation:

- Some English fixups and cleanups;
- Capitalize patchwork;
- Uncapitalize pull requests, as other occurrences are in lower case;
- Added bold markups to the 3 types of media maintainers;
- ensure that the document uses 80 chars per line;

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 .../media/maintainer-entry-profile.rst        | 157 +++++++++---------
 1 file changed, 80 insertions(+), 77 deletions(-)

diff --git a/Documentation/driver-api/media/maintainer-entry-profile.rst b/Documentation/driver-api/media/maintainer-entry-profile.rst
index 0024f85101b7..bb95611f0a84 100644
--- a/Documentation/driver-api/media/maintainer-entry-profile.rst
+++ b/Documentation/driver-api/media/maintainer-entry-profile.rst
@@ -4,7 +4,7 @@ Media Subsystem Profile
 Overview
 --------
 
-The Linux Media Community (aka: the LinuxTV Community) is formed of
+The Linux Media Community (aka: the LinuxTV Community) is formed by
 developers working on Linux Kernel Media Subsystem, together with users
 who also play an important role in testing the code.
 
@@ -27,7 +27,7 @@ tree:
 .. [1] Device tree bindings are maintained by the
        OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS maintainers
        (see the MAINTAINERS file). So, changes there must be reviewed
-       by them before being merged via the media subsystem's development
+       by them before being merged into the media subsystem's development
        tree.
 
 Both media userspace and Kernel APIs are documented and the documentation
@@ -38,32 +38,33 @@ corresponding API documentation.
 Media Maintainers
 -----------------
 
+Media Maintainers are not just people capable of writing code, but they
+are developers who have demonstrated their ability to collaborate with
+the team, get the most knowledgeable people to review code, contribute
+high-quality code, and follow through to fix issues (in code or tests).
+
 Due to the size and wide scope of the media subsystem, multiple layers of
 maintainers are required, each with their own areas of expertise:
 
-- Media Driver Maintainer:
-    Responsible for one or more drivers within the Media Subsystem. You
+- **Media Driver Maintainer**:
+    Responsible for one or more drivers within the Media Subsystem. They
     are listed in the MAINTAINERS file as maintainer for those drivers. Media
     Driver Maintainers review patches for those drivers, provide feedback if
-    the patches are not following the subsystem rules, or are not using the
-    media kernel or userspace APIs correctly, or have poor code quality.
+    patches do not follow the subsystem rules, or are not using the
+    media kernel or userspace APIs correctly, or if they have poor code
+    quality.
 
-    If you are the author of the patches, then you work with other Media
+    If you are the patch author, you work with other Media
     Maintainers to ensure your patches are reviewed.
 
-    Some Media Driver Maintainers have additional responsibilities.  They have
-    been granted patchwork access and keep
-    `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
+    Some Media Driver Maintainers have additional responsibilities. They have
+    been granted Patchwork access and keep
+    `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
     up to date, decide when patches are ready for merging, and create Pull
     Requests for the Media Subsystem Maintainers to merge.
 
-    Such Media Driver Maintainers are not just someone who is capable of creating code,
-    but someone who has demonstrated their ability to collaborate with the team,
-    get the most knowledgeable people to review code, contribute high-quality code,
-    and follow through to fix issues (in code or tests).
-
-- Media Core Maintainer:
-    Media Driver Maintainers with patchwork access who are also responsible for
+- **Media Core Maintainer**:
+    Media Driver Maintainers with Patchwork access who are also responsible for
     one or more media core frameworks.
 
     Core framework changes are done via consensus between the relevant Media
@@ -71,22 +72,21 @@ maintainers are required, each with their own areas of expertise:
     their Pull Requests if they are signed off by the relevant Media Core
     Maintainers.
 
-- Media Subsystem Maintainers:
-    Media Core Maintainers who are also responsible for the subsystem as a whole,
-    with access to the entire subsystem. Responsible for merging Pull Requests
-    from other Media Maintainers.
+- **Media Subsystem Maintainers**:
+    Media Core Maintainers who are also responsible for the subsystem as a
+    whole, with access to the entire subsystem. Responsible for merging Pull
+    Requests from other Media Maintainers.
 
-    Userspace API/ABI changes are done via consensus between Media Subsystem
+    Userspace API/ABI changes are made via consensus among Media Subsystem
     Maintainers\ [2]_. Media Maintainers may include API/ABI changes in
-    their Pull Requests if they are signed off by the all Media Subsystem
+    their pull requests if they are signed off by all Media Subsystem
     Maintainers.
 
-All Media Maintainers shall explicitly agree with the Kernel development process
-as described at Documentation/process/index.rst and to the Kernel
-development rules inside the Kernel documentation, including its code of
-conduct.
+All Media Maintainers shall agree with the Kernel development process as
+described in Documentation/process/index.rst and with the Kernel development
+rules in the Kernel documentation, including its code of conduct.
 
-Media Maintainers are reachable via the #linux-media IRC channel at OFTC.
+Media Maintainers are often reachable via the #linux-media IRC channel at OFTC.
 
 .. [2] Everything that would break backward compatibility with existing
        non-kernel code are API/ABI changes. This includes ioctl and sysfs
@@ -95,8 +95,8 @@ Media Maintainers are reachable via the #linux-media IRC channel at OFTC.
 Patchwork Access
 ----------------
 
-All Media Maintainers who have been granted patchwork access shall ensure that
-`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
+All Media Maintainers who have been granted Patchwork access shall ensure that
+`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
 will reflect the current status, e.g. patches shall be delegated to the Media
 Maintainer who is handling them and the patch status shall be updated according
 to these rules:
@@ -112,28 +112,28 @@ to these rules:
   tree (e.g. drm, dmabuf, upstream merge, etc.) but were cross-posted to the
   linux-media mailing list.
 
-If a Media Maintainer decides not to accept a patch, then reply by email to
-the patch authors, explaining why it is not accepted, and
-`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_ shall be
-updated accordingly with either:
+If Media Maintainers decide not to accept a patch, they should reply to the
+patch authors by e‑mail, explaining why it is not accepted, and
+update `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
+accordingly with one of the following statuses:
 
 - ``Changes Requested``: if a new revision was requested;
 - ``Rejected``: if the proposed change is not acceptable at all.
 
 .. Note::
 
-   Patchwork supports a couple of clients to help semi-automating
+   Patchwork supports a couple of clients to help semi-automate
    status updates via its REST interface:
 
    https://patchwork.readthedocs.io/en/latest/usage/clients/
 
-For those patches that fall in your area of responsibility you alse decide
-when those patches are ready for merging, and create Pull Requests for the
-Media Subsystem Maintainers to merge.
+For patches that fall within their area of responsibility a Media Maintainer
+also decide when those patches are ready for merging, and create Pull Requests
+for the Media Subsystem Maintainers to merge.
 
-The most important aspect of becoming a Media Maintainer with patchwork access
-is that you have demonstrated the ability to give good code reviews. So we are
-looking for whether or not we think you will be good at doing that.
+The most important aspect of becoming a Media Maintainer with Patchwork access
+is that you have demonstrated an ability to give good code reviews. We value
+your ability to deliver thorough, constructive code reviews.
 
 As such, potential maintainers must earn enough credibility and trust from the
 Linux Media Community. To do that, developers shall be familiar with the open
@@ -145,7 +145,7 @@ demonstrating your:
 
 - commitment to the project;
 - ability to collaborate with the team and communicate well;
-- understand of how upstream and the Linux Media Community work
+- understanding of how upstream and the Linux Media Community work
   (policies, processes for testing, code review, ...)
 - reasonable knowledge about:
 
@@ -160,9 +160,9 @@ demonstrating your:
 - ability to judge when a patch might be ready for review and to submit;
 - ability to write good code (last but certainly not least).
 
-Media Driver Maintainers that desire to get patchwork access are encouraged
+Media Driver Maintainers that desire to get Patchwork access are encouraged
 to participate at the yearly Linux Media Summit, typically co-located with
-a Linux related conference. These summits are announced on the linux-media
+a Linux-related conference. These summits are announced on the linux-media
 mailing list.
 
 If you are doing such tasks and have become a valued developer, an
@@ -170,8 +170,8 @@ existing Media Maintainer can nominate you to the Media Subsystem Maintainers.
 
 The ultimate responsibility for accepting a nominated maintainer is up to
 the subsystem's maintainers. The nominated maintainer must have earned a trust
-relationship with all Media Subsystem Maintainers, as, by being granted patchwork
-access, you will take over part of their maintenance tasks.
+relationship with all Media Subsystem Maintainers, as, by being granted
+Patchwork access, you will take over part of their maintenance tasks.
 
 Media Committers
 ----------------
@@ -191,14 +191,18 @@ The main development tree used by the media subsystem is hosted at
 https://gitlab.freedesktop.org/linux-media/.
 https://linuxtv.org/ hosts news about the subsystem,
 `wiki <https://www.linuxtv.org/wiki/index.php/Main_Page>`_ pages
-and a `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
+and a `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
 instance where we track patches though their lifetime.
 
-The main tree used by media developers is at:
+The stable tree used by media developers is at:
+
+https://git.linuxtv.org/media.git/
+
+Patches there are initially committed to the media committers tree:
 
 https://gitlab.freedesktop.org/linux-media/media-committers.git
 
-Please note that this tree can be rebased, although only as a last resort.
+Please note that the later can be rebased, although only as a last resort.
 
 .. _Media development workflow:
 
@@ -217,11 +221,11 @@ you can find details about how to subscribe to it and to see its archives at:
 
 Emails with HTML will be automatically rejected by the mail server.
 
-It could be wise to also copy the Media Maintainer(s). You should use
+It could be wise to also copy the relevant Media Maintainer(s). You should use
 ``scripts/get_maintainers.pl`` to identify whom else needs to be copied.
 Please always copy driver's authors and maintainers.
 
-To minimize the chance of merge conflicts for your patch series, and make
+To minimize the chance of merge conflicts for your patch series, and make it
 easier to backport patches to stable Kernels, we recommend that you use the
 following baseline for your patch series:
 
@@ -267,13 +271,14 @@ workflows:
 a. Media Maintainers' workflow: Media Maintainers post the PRs, which are
    handled by the Media Subsystem Maintainers::
 
-     +-------+   +------------+   +------+   +-------+   +----------------------------+
-     |e-mail |-->|picked up by|-->|code  |-->|pull   |-->|Subsystem Maintainers merge |
-     |to LMML|   |patchwork   |   |review|   |request|   |in media-committers.git     |
-     +-------+   +------------+   +------+   +-------+   +----------------------------+
+     +-------+   +------------+   +------+   +-------+   +---------------------+
+     |e-mail |-->|picked up by|-->|code  |-->|pull   |-->|Subsystem Maintainers|
+     |to LMML|   |Patchwork   |   |review|   |request|   |merge in             |
+     |       |   |            |   |      |   |       |   |media-committers.git |
+     +-------+   +------------+   +------+   +-------+   +---------------------+
 
    For this workflow, pull requests are generated by Media Maintainers with
-   patchwork access.  If you do not have patchwork access, then please don't
+   Patchwork access.  If you do not have Patchwork access, then please don't
    submit pull requests, as they will not be processed.
 
 b. Media Committers' workflow: patches are handled by Media Maintainers with
@@ -281,15 +286,14 @@ b. Media Committers' workflow: patches are handled by Media Maintainers with
 
      +-------+   +------------+   +------+   +--------------------------+
      |e-mail |-->|picked up by|-->|code  |-->|Media Committers merge in |
-     |to LMML|   |patchwork   |   |review|   |media-committers.git      |
+     |to LMML|   |Patchwork   |   |review|   |media-committers.git      |
      +-------+   +------------+   +------+   +--------------------------+
 
 When patches are picked up by
-`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
-and when merged at media-committers,
-Media CI bots will check for errors and may provide e-mail feedback about
-patch problems. When this happens, the patch submitter must fix them or
-explain why the errors are false positives.
+`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
+and when merged at media-committers, Media CI bots will check for errors and
+may provide e-mail feedback about patch problems. When this happens, the patch
+submitter must fix them or explain why the errors are false positives.
 
 Patches will only be moved to the next stage in these two workflows if they
 pass on Media CI or if there are false-positives in the Media CI reports.
@@ -327,18 +331,17 @@ server has accepted your patch, by looking at:
    - https://lore.kernel.org/linux-media/
 
 If the patch is there and not at
-`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
-it is likely that your e-mailer
-mangled the patch. Patchwork internally has logic that checks if the
-received e-mail contains a valid patch. Any whitespace and new line
-breakages mangling the patch won't be recognized by
-`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
+`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
+it is likely that your e-mailer mangled the patch. Patchwork internally
+has logic that checks if the received e-mail contains a valid patch.
+Any whitespace and new line breakages mangling the patch won't be recognized by
+`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
 and such a patch will be rejected.
 
 .. [3] It usually takes a few minutes for the patch to arrive, but
-       the e-mail server may be busy, so it may take up a longer time
+       the e-mail server may be busy, so it may take a longer time
        for a patch to be picked by
-       `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.
+       `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.
 
 .. [4] If your email contains HTML, the mailing list server will simply
        drop it, without any further notice.
@@ -349,8 +352,8 @@ Authentication for pull and merge requests
 ++++++++++++++++++++++++++++++++++++++++++
 
 The authenticity of developers submitting pull requests and merge requests
-shall be validated by using PGP signing at some moment.
-See: :ref:`kernel_org_trust_repository`.
+shall be validated by using the Linux Kernel Web of Trust, with PGP signing
+at some moment. See: :ref:`kernel_org_trust_repository`.
 
 With the pull request workflow, pull requests shall use PGP-signed tags.
 
@@ -494,11 +497,11 @@ least, simply wrapping the lines.
 In particular, we accept lines with more than 80 columns:
 
     - on strings, as they shouldn't be broken due to line length limits;
-    - when a function or variable name need to have a big identifier name,
-      which keeps hard to honor the 80 columns limit;
+    - when a function or variable name needs to have a large identifier name,
+      which makes hard to honor the 80 columns limit;
     - on arithmetic expressions, when breaking lines makes them harder to
       read;
-    - when they avoid a line to end with an open parenthesis or an open
+    - when they avoid a line ending with an open parenthesis or an open
       bracket.
 
 Key Cycle Dates
@@ -512,7 +515,7 @@ Review Cadence
 --------------
 
 Provided that your patch has landed in
-`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_, it
+`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_, it
 should be sooner or later handled, so you don't need to re-submit a patch.
 
 Except for important bug fixes, we don't usually add new patches to the
@@ -525,4 +528,4 @@ other developers to publicly add ``Reviewed-by:`` and, more importantly,
 ``Tested-by:`` tags.
 
 Please note that we expect a detailed description for ``Tested-by:``,
-identifying what boards were used at the test and what it was tested.
+identifying what boards were used during the test and what it was tested.
-- 
2.52.0

[PATCH 2/2] docs: media: media-committer: do some editorial changes

[Mauro Carvalho Chehab]

Do some editorial changes to make it look clearer:

  - media-committers tree references corrected from singular to plural;
  - updated commit rights wording and responsibilities;
  - fixed various typographical errors;
  - corrected “mailing list” and “Kernel” references;
  - improved core committer description;
  - updated documentation paths and URLs;
  - added missing “for” and improved sentence flow.

Perhaps the most relevant change is that i removed a word
that was requiring granting Patchwork rights some time before
adding commit rights (we may grant them altogether if makes
sense for us), and I added a 4th note to committer notes
list to let it clear that about what it is expected from a
committer with regards to updating Patchwork.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 .../driver-api/media/media-committer.rst      | 97 ++++++++++---------
 1 file changed, 51 insertions(+), 46 deletions(-)

diff --git a/Documentation/driver-api/media/media-committer.rst b/Documentation/driver-api/media/media-committer.rst
index 18cce6e06a2b..c83e94750e57 100644
--- a/Documentation/driver-api/media/media-committer.rst
+++ b/Documentation/driver-api/media/media-committer.rst
@@ -20,8 +20,8 @@ and the Linux Media community.
 
 .. Note::
 
-   1. Patches you authored must have a Signed-off-by, Reviewed-by or Acked-by
-      of another Media Maintainer;
+   1. Patches you authored must have a ``Signed-off-by``, ``Reviewed-by``
+      or ``Acked-by`` from another Media Maintainer;
    2. If a patch introduces a regression, then it is the Media Committer's
       responsibility to correct that as soon as possible. Typically the
       patch is either reverted, or an additional patch is committed to
@@ -29,14 +29,18 @@ and the Linux Media community.
    3. If patches are fixing bugs against already released Kernels, including
       the reverts above mentioned, the Media Committer shall add the needed
       tags. Please see :ref:`Media development workflow` for more details.
+   4. All Media Committers are responsible for maintaining
+      `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
+      updating the state of the patches they review or merge.
+
 
 Becoming a Media Committer
 --------------------------
 
 Existing Media Committers can nominate a Media Maintainer to be granted
-commit rights. The Media Maintainer must already have patchwork access and
-have been in that role for some time, and has demonstrated a good
-understanding of the maintainer's duties and processes.
+commit rights. The Media Maintainer must have patchwork access,
+have been reviewing patches from third parties for some time, and has
+demonstrated a good understanding of the maintainer's duties and processes.
 
 The ultimate responsibility for accepting a nominated committer is up to
 the Media Subsystem Maintainers. The nominated committer must have earned a
@@ -61,8 +65,8 @@ Media Committer's agreement
 Once a nominated committer is accepted by all Media Subsystem Maintainers,
 they will ask if the developer is interested in the nomination and discuss
 what area(s) of the media subsystem the committer will be responsible for.
-Those areas will typically be the same as the areas that are already
-maintained by the nominated committer.
+Those areas will typically be the same as the areas that the nominated
+committer is already maintaining.
 
 When the developer accepts being a committer, the new committer shall
 explicitly accept the Kernel development policies described under its
@@ -77,7 +81,7 @@ following the model below::
 
    ...
 
-   For the purpose of committing patches to the media-committer's tree,
+   For the purpose of committing patches to the media-committers tree,
    I'll be using my user https://gitlab.freedesktop.org/users/<username>.
 
 Followed by a formal declaration of agreement with the Kernel development
@@ -85,7 +89,7 @@ rules::
 
    I agree to follow the Kernel development rules described at:
 
-   https://www.kernel.org/doc/html/latest/driver-api/media/media-committer.rst
+   https://www.kernel.org/doc/html/latest/driver-api/media/media-committers.rst
 
    and to the Linux Kernel development process rules.
 
@@ -97,18 +101,17 @@ rules::
    my commit rights.
 
    I am aware that the Kernel development rules change over time.
-   By doing a new push to media-committer tree, I understand that I agree
+   By doing a new push to media-committers tree, I understand that I agree
    to follow the rules in effect at the time of the commit.
 
-That e-mail shall be signed with a PGP key cross signed by other Kernel and
-media developers. As described at :ref:`media-developers-gpg`, the PGP
-signature, together with the gitlab user security are fundamental components
-that ensure the authenticity of the merge requests that will happen at the
-media-committer.git tree.
+That e-mail shall be signed via the Kernel Web of trust with a PGP key cross
+signed by other Kernel and media developers. As described at
+:ref:`media-developers-gpg`, the PGP signature, together with the gitlab user
+security are fundamental components that ensure the authenticity of the merge
+requests that will happen at the media-committers.git tree.
 
-In case the kernel development process changes, by merging new commits
-to the
-`media-committer tree <https://gitlab.freedesktop.org/linux-media/media-committers>`_,
+In case the kernel development process changes, by merging new commits to the
+`media-committers tree <https://gitlab.freedesktop.org/linux-media/media-committers>`_,
 the Media Committer implicitly declares their agreement with the latest
 version of the documented process including the contents of this file.
 
@@ -118,25 +121,27 @@ notify the Media Subsystem Maintainers about that decision.
 .. note::
 
    1. Changes to the kernel media development process shall be announced in
-      the media-committers mailinglist with a reasonable review period. All
-      committers are automatically subscribed to that mailinglist;
+      the media-committers mailing list with a reasonable review period. All
+      committers are automatically subscribed to that mailing list;
    2. Due to the distributed nature of the Kernel development, it is
       possible that kernel development process changes may end being
-      reviewed/merged at the linux-docs mailing list, specially for the
-      contents under Documentation/process and for trivial typo fixes.
+      reviewed/merged at the Linux Docs and/or at the Linux Kernel mailing
+      lists, especially for the contents under Documentation/process and for
+      trivial typo fixes.
 
 Media Core Committers
 ---------------------
 
-As described in Documentation/driver-api/media/maintainer-entry-profile.rst
+A Media Core Committer is a Media Core Maintainer with commit rights.
+
+As described in Documentation/driver-api/media/maintainer-entry-profile.rst,
 a Media Core Maintainer maintains media core frameworks as well, besides
-just drivers, and so is able to change core files and the media subsystem's
-Kernel API. A Media Core Committer is a Media Core Maintainer with commit
-rights. The extent of the core committer's grants will be detailed by the
+just drivers, and so is allowed to change core files and the media subsystem's
+Kernel API. The extent of the core committer's grants will be detailed by the
 Media Subsystem Maintainers when they nominate a Media Core Committer.
 
 Existing Media Committers may become Media Core Committers and vice versa.
-Such decisions will be taken in consensus between the Media Subsystem
+Such decisions will be taken in consensus among the Media Subsystem
 Maintainers.
 
 Media committers rules
@@ -148,16 +153,16 @@ shall be merged as soon as possible, aiming to be merged at the same Kernel
 cycle the bug is reported.
 
 Media committers shall behave accordingly to the rights granted by
-the Media Subsystem Maintainers, specially with regards of the scope of changes
+the Media Subsystem Maintainers, especially with regards of the scope of changes
 they may apply directly at the media-committers tree. That scope can
-change over time on a mutual agreement between media committers and
-maintainers.
+change over time on a mutual agreement between Media Committers and
+Media Subsystem Maintainers.
 
 The Media Committer workflow is described at :ref:`Media development workflow`.
 
 .. _Maintain Media Status:
 
-Maintaining media maintainer or committer status
+Maintaining Media Maintainer or Committer status
 ------------------------------------------------
 
 A community of maintainers working together to move the Linux Kernel
@@ -165,27 +170,27 @@ forward is essential to creating successful projects that are rewarding
 to work on. If there are problems or disagreements within the community,
 they can usually be solved through healthy discussion and debate.
 
-In the unhappy event that a media maintainer or committer continues to
+In the unhappy event that a Media Maintainer or Committer continues to
 disregard good citizenship (or actively disrupts the project), we may need
 to revoke that person's status. In such cases, if someone suggests the
-revocation with a good reason, then after discussing this among the media
-maintainers, the final decision is taken by the Media Subsystem Maintainers.
-As the decision to become a media maintainer or committer comes from a
-consensus between Media Subsystem Maintainers, a single subsystem maintainer
-not trusting the media maintainer or committer anymore is enough to revoke
-the maintenance/patchwork or commit rights.
+revocation with a good reason, then after discussing this among the Media
+Maintainers, the final decision is taken by the Media Subsystem Maintainers.
 
-A previous committer that had their commit rights revoked can keep
-contributing to the subsystem via the pull request workflow as documented
-at the :ref:`Media development workflow`, unless they were also removed as
-Media Maintainer.
+As the decision to become a Media Maintainer or Committer comes from a
+consensus between Media Subsystem Maintainers, a single Media Subsystem
+Maintainer not trusting the Media Maintainer or Committer anymore is enough
+to revoke their maintenance, Patchwork grants and/or commit rights.
+
+Having commit rights revoked doesn't prevent Media Maintainers to keep
+contributing to the subsystem either via the pull request or via email workflow
+as documented at the :ref:`Media development workflow`.
 
 If a maintainer is inactive for more than a couple of Kernel cycles,
 maintainers will try to reach you via e-mail. If not possible, they may
-revoke your maintainer/patchwork and committer rights and update MAINTAINERS file
-entries accordingly. If you wish to resume contributing later on, then contact
-the Media Subsystem Maintainers to ask if your maintenance/patchwork and
-commit rights can be restored.
+revoke their maintainer/patchwork and committer rights and update MAINTAINERS
+file entries accordingly. If you wish to resume contributing as maintainer
+later on, then contact the Media Subsystem Maintainers to ask if your
+maintenance, Patchwork grants and commit rights can be restored.
 
 References
 ----------
-- 
2.52.0

Re: [PATCH 2/2] docs: media: media-committer: do some editorial changes

[Mauro Carvalho Chehab]

On Wed,  4 Feb 2026 15:37:45 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:

> Do some editorial changes to make it look clearer:
...
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>  .../driver-api/media/media-committer.rst      | 97 ++++++++++---------
>  1 file changed, 51 insertions(+), 46 deletions(-)
...
> @@ -85,7 +89,7 @@ rules::
>  
>     I agree to follow the Kernel development rules described at:
>  
> -   https://www.kernel.org/doc/html/latest/driver-api/media/media-committer.rst
> +   https://www.kernel.org/doc/html/latest/driver-api/media/media-committers.rst
>  
>     and to the Linux Kernel development process rules.

Heh, this change is obviously wrong, except if we rename the rst document
to also be media-committers.rst, which sounds a good idea to me:

- Use "media-committers" for both the .rst file and for the git tree.

So, please rename the file on v8 (or otherwise fix it here)

-- 
Thanks,
Mauro

Re: [PATCH 1/2] docs: media: maintainer-entry-profile: do some editorial reviews

[Hans Verkuil]

Hi Mauro,

Looks good. Just three minor issues (two typos, and one suggestion for a better word).

If there are no objections, then I will just make those changes and fold it into this
patch for v8.

Regards,

	Hans

On 2/4/26 15:37, Mauro Carvalho Chehab wrote:
> Do some editorial improvements to the Media Subsystem Profile
> documentation:
> 
> - Some English fixups and cleanups;
> - Capitalize patchwork;
> - Uncapitalize pull requests, as other occurrences are in lower case;
> - Added bold markups to the 3 types of media maintainers;
> - ensure that the document uses 80 chars per line;
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>  .../media/maintainer-entry-profile.rst        | 157 +++++++++---------
>  1 file changed, 80 insertions(+), 77 deletions(-)
> 
> diff --git a/Documentation/driver-api/media/maintainer-entry-profile.rst b/Documentation/driver-api/media/maintainer-entry-profile.rst
> index 0024f85101b7..bb95611f0a84 100644
> --- a/Documentation/driver-api/media/maintainer-entry-profile.rst
> +++ b/Documentation/driver-api/media/maintainer-entry-profile.rst
> @@ -4,7 +4,7 @@ Media Subsystem Profile
>  Overview
>  --------
>  
> -The Linux Media Community (aka: the LinuxTV Community) is formed of
> +The Linux Media Community (aka: the LinuxTV Community) is formed by
>  developers working on Linux Kernel Media Subsystem, together with users
>  who also play an important role in testing the code.
>  
> @@ -27,7 +27,7 @@ tree:
>  .. [1] Device tree bindings are maintained by the
>         OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS maintainers
>         (see the MAINTAINERS file). So, changes there must be reviewed
> -       by them before being merged via the media subsystem's development
> +       by them before being merged into the media subsystem's development
>         tree.
>  
>  Both media userspace and Kernel APIs are documented and the documentation
> @@ -38,32 +38,33 @@ corresponding API documentation.
>  Media Maintainers
>  -----------------
>  
> +Media Maintainers are not just people capable of writing code, but they
> +are developers who have demonstrated their ability to collaborate with
> +the team, get the most knowledgeable people to review code, contribute
> +high-quality code, and follow through to fix issues (in code or tests).
> +
>  Due to the size and wide scope of the media subsystem, multiple layers of
>  maintainers are required, each with their own areas of expertise:
>  
> -- Media Driver Maintainer:
> -    Responsible for one or more drivers within the Media Subsystem. You
> +- **Media Driver Maintainer**:
> +    Responsible for one or more drivers within the Media Subsystem. They
>      are listed in the MAINTAINERS file as maintainer for those drivers. Media
>      Driver Maintainers review patches for those drivers, provide feedback if
> -    the patches are not following the subsystem rules, or are not using the
> -    media kernel or userspace APIs correctly, or have poor code quality.
> +    patches do not follow the subsystem rules, or are not using the
> +    media kernel or userspace APIs correctly, or if they have poor code
> +    quality.
>  
> -    If you are the author of the patches, then you work with other Media
> +    If you are the patch author, you work with other Media
>      Maintainers to ensure your patches are reviewed.
>  
> -    Some Media Driver Maintainers have additional responsibilities.  They have
> -    been granted patchwork access and keep
> -    `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> +    Some Media Driver Maintainers have additional responsibilities. They have
> +    been granted Patchwork access and keep
> +    `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
>      up to date, decide when patches are ready for merging, and create Pull
>      Requests for the Media Subsystem Maintainers to merge.
>  
> -    Such Media Driver Maintainers are not just someone who is capable of creating code,
> -    but someone who has demonstrated their ability to collaborate with the team,
> -    get the most knowledgeable people to review code, contribute high-quality code,
> -    and follow through to fix issues (in code or tests).
> -
> -- Media Core Maintainer:
> -    Media Driver Maintainers with patchwork access who are also responsible for
> +- **Media Core Maintainer**:
> +    Media Driver Maintainers with Patchwork access who are also responsible for
>      one or more media core frameworks.
>  
>      Core framework changes are done via consensus between the relevant Media
> @@ -71,22 +72,21 @@ maintainers are required, each with their own areas of expertise:
>      their Pull Requests if they are signed off by the relevant Media Core
>      Maintainers.
>  
> -- Media Subsystem Maintainers:
> -    Media Core Maintainers who are also responsible for the subsystem as a whole,
> -    with access to the entire subsystem. Responsible for merging Pull Requests
> -    from other Media Maintainers.
> +- **Media Subsystem Maintainers**:
> +    Media Core Maintainers who are also responsible for the subsystem as a
> +    whole, with access to the entire subsystem. Responsible for merging Pull
> +    Requests from other Media Maintainers.
>  
> -    Userspace API/ABI changes are done via consensus between Media Subsystem
> +    Userspace API/ABI changes are made via consensus among Media Subsystem
>      Maintainers\ [2]_. Media Maintainers may include API/ABI changes in
> -    their Pull Requests if they are signed off by the all Media Subsystem
> +    their pull requests if they are signed off by all Media Subsystem
>      Maintainers.
>  
> -All Media Maintainers shall explicitly agree with the Kernel development process
> -as described at Documentation/process/index.rst and to the Kernel
> -development rules inside the Kernel documentation, including its code of
> -conduct.
> +All Media Maintainers shall agree with the Kernel development process as
> +described in Documentation/process/index.rst and with the Kernel development
> +rules in the Kernel documentation, including its code of conduct.
>  
> -Media Maintainers are reachable via the #linux-media IRC channel at OFTC.
> +Media Maintainers are often reachable via the #linux-media IRC channel at OFTC.
>  
>  .. [2] Everything that would break backward compatibility with existing
>         non-kernel code are API/ABI changes. This includes ioctl and sysfs
> @@ -95,8 +95,8 @@ Media Maintainers are reachable via the #linux-media IRC channel at OFTC.
>  Patchwork Access
>  ----------------
>  
> -All Media Maintainers who have been granted patchwork access shall ensure that
> -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> +All Media Maintainers who have been granted Patchwork access shall ensure that
> +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
>  will reflect the current status, e.g. patches shall be delegated to the Media
>  Maintainer who is handling them and the patch status shall be updated according
>  to these rules:
> @@ -112,28 +112,28 @@ to these rules:
>    tree (e.g. drm, dmabuf, upstream merge, etc.) but were cross-posted to the
>    linux-media mailing list.
>  
> -If a Media Maintainer decides not to accept a patch, then reply by email to
> -the patch authors, explaining why it is not accepted, and
> -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_ shall be
> -updated accordingly with either:
> +If Media Maintainers decide not to accept a patch, they should reply to the
> +patch authors by e‑mail, explaining why it is not accepted, and
> +update `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> +accordingly with one of the following statuses:
>  
>  - ``Changes Requested``: if a new revision was requested;
>  - ``Rejected``: if the proposed change is not acceptable at all.
>  
>  .. Note::
>  
> -   Patchwork supports a couple of clients to help semi-automating
> +   Patchwork supports a couple of clients to help semi-automate
>     status updates via its REST interface:
>  
>     https://patchwork.readthedocs.io/en/latest/usage/clients/
>  
> -For those patches that fall in your area of responsibility you alse decide
> -when those patches are ready for merging, and create Pull Requests for the
> -Media Subsystem Maintainers to merge.
> +For patches that fall within their area of responsibility a Media Maintainer
> +also decide when those patches are ready for merging, and create Pull Requests

decide -> decides

> +for the Media Subsystem Maintainers to merge.
>  
> -The most important aspect of becoming a Media Maintainer with patchwork access
> -is that you have demonstrated the ability to give good code reviews. So we are
> -looking for whether or not we think you will be good at doing that.
> +The most important aspect of becoming a Media Maintainer with Patchwork access
> +is that you have demonstrated an ability to give good code reviews. We value
> +your ability to deliver thorough, constructive code reviews.
>  
>  As such, potential maintainers must earn enough credibility and trust from the
>  Linux Media Community. To do that, developers shall be familiar with the open
> @@ -145,7 +145,7 @@ demonstrating your:
>  
>  - commitment to the project;
>  - ability to collaborate with the team and communicate well;
> -- understand of how upstream and the Linux Media Community work
> +- understanding of how upstream and the Linux Media Community work
>    (policies, processes for testing, code review, ...)
>  - reasonable knowledge about:
>  
> @@ -160,9 +160,9 @@ demonstrating your:
>  - ability to judge when a patch might be ready for review and to submit;
>  - ability to write good code (last but certainly not least).
>  
> -Media Driver Maintainers that desire to get patchwork access are encouraged
> +Media Driver Maintainers that desire to get Patchwork access are encouraged
>  to participate at the yearly Linux Media Summit, typically co-located with
> -a Linux related conference. These summits are announced on the linux-media
> +a Linux-related conference. These summits are announced on the linux-media
>  mailing list.
>  
>  If you are doing such tasks and have become a valued developer, an
> @@ -170,8 +170,8 @@ existing Media Maintainer can nominate you to the Media Subsystem Maintainers.
>  
>  The ultimate responsibility for accepting a nominated maintainer is up to
>  the subsystem's maintainers. The nominated maintainer must have earned a trust
> -relationship with all Media Subsystem Maintainers, as, by being granted patchwork
> -access, you will take over part of their maintenance tasks.
> +relationship with all Media Subsystem Maintainers, as, by being granted
> +Patchwork access, you will take over part of their maintenance tasks.
>  
>  Media Committers
>  ----------------
> @@ -191,14 +191,18 @@ The main development tree used by the media subsystem is hosted at
>  https://gitlab.freedesktop.org/linux-media/.
>  https://linuxtv.org/ hosts news about the subsystem,
>  `wiki <https://www.linuxtv.org/wiki/index.php/Main_Page>`_ pages
> -and a `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> +and a `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
>  instance where we track patches though their lifetime.
>  
> -The main tree used by media developers is at:
> +The stable tree used by media developers is at:
> +
> +https://git.linuxtv.org/media.git/
> +
> +Patches there are initially committed to the media committers tree:
>  
>  https://gitlab.freedesktop.org/linux-media/media-committers.git
>  
> -Please note that this tree can be rebased, although only as a last resort.
> +Please note that the later can be rebased, although only as a last resort.

later -> latter

>  
>  .. _Media development workflow:
>  
> @@ -217,11 +221,11 @@ you can find details about how to subscribe to it and to see its archives at:
>  
>  Emails with HTML will be automatically rejected by the mail server.
>  
> -It could be wise to also copy the Media Maintainer(s). You should use
> +It could be wise to also copy the relevant Media Maintainer(s). You should use
>  ``scripts/get_maintainers.pl`` to identify whom else needs to be copied.
>  Please always copy driver's authors and maintainers.
>  
> -To minimize the chance of merge conflicts for your patch series, and make
> +To minimize the chance of merge conflicts for your patch series, and make it
>  easier to backport patches to stable Kernels, we recommend that you use the
>  following baseline for your patch series:
>  
> @@ -267,13 +271,14 @@ workflows:
>  a. Media Maintainers' workflow: Media Maintainers post the PRs, which are
>     handled by the Media Subsystem Maintainers::
>  
> -     +-------+   +------------+   +------+   +-------+   +----------------------------+
> -     |e-mail |-->|picked up by|-->|code  |-->|pull   |-->|Subsystem Maintainers merge |
> -     |to LMML|   |patchwork   |   |review|   |request|   |in media-committers.git     |
> -     +-------+   +------------+   +------+   +-------+   +----------------------------+
> +     +-------+   +------------+   +------+   +-------+   +---------------------+
> +     |e-mail |-->|picked up by|-->|code  |-->|pull   |-->|Subsystem Maintainers|
> +     |to LMML|   |Patchwork   |   |review|   |request|   |merge in             |
> +     |       |   |            |   |      |   |       |   |media-committers.git |
> +     +-------+   +------------+   +------+   +-------+   +---------------------+
>  
>     For this workflow, pull requests are generated by Media Maintainers with
> -   patchwork access.  If you do not have patchwork access, then please don't
> +   Patchwork access.  If you do not have Patchwork access, then please don't
>     submit pull requests, as they will not be processed.
>  
>  b. Media Committers' workflow: patches are handled by Media Maintainers with
> @@ -281,15 +286,14 @@ b. Media Committers' workflow: patches are handled by Media Maintainers with
>  
>       +-------+   +------------+   +------+   +--------------------------+
>       |e-mail |-->|picked up by|-->|code  |-->|Media Committers merge in |
> -     |to LMML|   |patchwork   |   |review|   |media-committers.git      |
> +     |to LMML|   |Patchwork   |   |review|   |media-committers.git      |
>       +-------+   +------------+   +------+   +--------------------------+
>  
>  When patches are picked up by
> -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> -and when merged at media-committers,
> -Media CI bots will check for errors and may provide e-mail feedback about
> -patch problems. When this happens, the patch submitter must fix them or
> -explain why the errors are false positives.
> +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> +and when merged at media-committers, Media CI bots will check for errors and
> +may provide e-mail feedback about patch problems. When this happens, the patch
> +submitter must fix them or explain why the errors are false positives.
>  
>  Patches will only be moved to the next stage in these two workflows if they
>  pass on Media CI or if there are false-positives in the Media CI reports.
> @@ -327,18 +331,17 @@ server has accepted your patch, by looking at:
>     - https://lore.kernel.org/linux-media/
>  
>  If the patch is there and not at
> -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> -it is likely that your e-mailer
> -mangled the patch. Patchwork internally has logic that checks if the
> -received e-mail contains a valid patch. Any whitespace and new line
> -breakages mangling the patch won't be recognized by
> -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> +it is likely that your e-mailer mangled the patch. Patchwork internally
> +has logic that checks if the received e-mail contains a valid patch.
> +Any whitespace and new line breakages mangling the patch won't be recognized by
> +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
>  and such a patch will be rejected.
>  
>  .. [3] It usually takes a few minutes for the patch to arrive, but
> -       the e-mail server may be busy, so it may take up a longer time
> +       the e-mail server may be busy, so it may take a longer time
>         for a patch to be picked by
> -       `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.
> +       `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.
>  
>  .. [4] If your email contains HTML, the mailing list server will simply
>         drop it, without any further notice.
> @@ -349,8 +352,8 @@ Authentication for pull and merge requests
>  ++++++++++++++++++++++++++++++++++++++++++
>  
>  The authenticity of developers submitting pull requests and merge requests
> -shall be validated by using PGP signing at some moment.
> -See: :ref:`kernel_org_trust_repository`.
> +shall be validated by using the Linux Kernel Web of Trust, with PGP signing
> +at some moment. See: :ref:`kernel_org_trust_repository`.
>  
>  With the pull request workflow, pull requests shall use PGP-signed tags.
>  
> @@ -494,11 +497,11 @@ least, simply wrapping the lines.
>  In particular, we accept lines with more than 80 columns:
>  
>      - on strings, as they shouldn't be broken due to line length limits;
> -    - when a function or variable name need to have a big identifier name,
> -      which keeps hard to honor the 80 columns limit;
> +    - when a function or variable name needs to have a large identifier name,

large -> long ('long' makes much more sense in this context)

> +      which makes hard to honor the 80 columns limit;
>      - on arithmetic expressions, when breaking lines makes them harder to
>        read;
> -    - when they avoid a line to end with an open parenthesis or an open
> +    - when they avoid a line ending with an open parenthesis or an open
>        bracket.
>  
>  Key Cycle Dates
> @@ -512,7 +515,7 @@ Review Cadence
>  --------------
>  
>  Provided that your patch has landed in
> -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_, it
> +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_, it
>  should be sooner or later handled, so you don't need to re-submit a patch.
>  
>  Except for important bug fixes, we don't usually add new patches to the
> @@ -525,4 +528,4 @@ other developers to publicly add ``Reviewed-by:`` and, more importantly,
>  ``Tested-by:`` tags.
>  
>  Please note that we expect a detailed description for ``Tested-by:``,
> -identifying what boards were used at the test and what it was tested.
> +identifying what boards were used during the test and what it was tested.

Re: [PATCH 2/2] docs: media: media-committer: do some editorial changes

[Hans Verkuil]

Hi Mauro,

For the most part I agree, but I have some suggestions regarding the point 4
you added, since I think it just restates what is already mentioned in
maintainer-entry-profile.rst.

Let me know what you think of my suggestions.

On 2/4/26 15:37, Mauro Carvalho Chehab wrote:
> Do some editorial changes to make it look clearer:
> 
>   - media-committers tree references corrected from singular to plural;
>   - updated commit rights wording and responsibilities;
>   - fixed various typographical errors;
>   - corrected “mailing list” and “Kernel” references;
>   - improved core committer description;
>   - updated documentation paths and URLs;
>   - added missing “for” and improved sentence flow.
> 
> Perhaps the most relevant change is that i removed a word
> that was requiring granting Patchwork rights some time before
> adding commit rights (we may grant them altogether if makes
> sense for us), and I added a 4th note to committer notes
> list to let it clear that about what it is expected from a
> committer with regards to updating Patchwork.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>  .../driver-api/media/media-committer.rst      | 97 ++++++++++---------
>  1 file changed, 51 insertions(+), 46 deletions(-)
> 
> diff --git a/Documentation/driver-api/media/media-committer.rst b/Documentation/driver-api/media/media-committer.rst
> index 18cce6e06a2b..c83e94750e57 100644
> --- a/Documentation/driver-api/media/media-committer.rst
> +++ b/Documentation/driver-api/media/media-committer.rst
> @@ -20,8 +20,8 @@ and the Linux Media community.
>  
>  .. Note::

Re-reading this I don't really think this should be a note at all. This just
lists the additional responsibilities of a media committer, no need to
present this as a 'note'.

>  
> -   1. Patches you authored must have a Signed-off-by, Reviewed-by or Acked-by
> -      of another Media Maintainer;
> +   1. Patches you authored must have a ``Signed-off-by``, ``Reviewed-by``
> +      or ``Acked-by`` from another Media Maintainer;
>     2. If a patch introduces a regression, then it is the Media Committer's
>        responsibility to correct that as soon as possible. Typically the
>        patch is either reverted, or an additional patch is committed to
> @@ -29,14 +29,18 @@ and the Linux Media community.
>     3. If patches are fixing bugs against already released Kernels, including
>        the reverts above mentioned, the Media Committer shall add the needed
>        tags. Please see :ref:`Media development workflow` for more details.
> +   4. All Media Committers are responsible for maintaining
> +      `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> +      updating the state of the patches they review or merge.
> +

I don't really agree with this. Not that it hurts, but maintaining patchwork
is a job of media maintainers. The only addition for committers is that they
have to update patches in patchwork to 'Accepted' when they have committed
them. That is certainly worth mentioning (including updating the maintainers
profile to clearly state that only committers can set it to Accepted.

So in maintainer-entry-profile.rst in 1.3 I would change the description for
the Accepted state to:

"Accepted: Once a patch is merged in the media-committers tree. Only Media
Maintainers with commit rights can set this state."

And change point 4 to this:

4. After committing a patch, the Media Committer must also update the
   patch status to ``Accepted`` in
   `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.

>  
>  Becoming a Media Committer
>  --------------------------
>  
>  Existing Media Committers can nominate a Media Maintainer to be granted
> -commit rights. The Media Maintainer must already have patchwork access and
> -have been in that role for some time, and has demonstrated a good
> -understanding of the maintainer's duties and processes.
> +commit rights. The Media Maintainer must have patchwork access,
> +have been reviewing patches from third parties for some time, and has
> +demonstrated a good understanding of the maintainer's duties and processes.
>  
>  The ultimate responsibility for accepting a nominated committer is up to
>  the Media Subsystem Maintainers. The nominated committer must have earned a
> @@ -61,8 +65,8 @@ Media Committer's agreement
>  Once a nominated committer is accepted by all Media Subsystem Maintainers,
>  they will ask if the developer is interested in the nomination and discuss
>  what area(s) of the media subsystem the committer will be responsible for.
> -Those areas will typically be the same as the areas that are already
> -maintained by the nominated committer.
> +Those areas will typically be the same as the areas that the nominated
> +committer is already maintaining.
>  
>  When the developer accepts being a committer, the new committer shall
>  explicitly accept the Kernel development policies described under its
> @@ -77,7 +81,7 @@ following the model below::
>  
>     ...
>  
> -   For the purpose of committing patches to the media-committer's tree,
> +   For the purpose of committing patches to the media-committers tree,
>     I'll be using my user https://gitlab.freedesktop.org/users/<username>.
>  
>  Followed by a formal declaration of agreement with the Kernel development
> @@ -85,7 +89,7 @@ rules::
>  
>     I agree to follow the Kernel development rules described at:
>  
> -   https://www.kernel.org/doc/html/latest/driver-api/media/media-committer.rst
> +   https://www.kernel.org/doc/html/latest/driver-api/media/media-committers.rst

BTW, I agree that this file should be renamed to media-committers.rst. That matches
the name of our git tree as well.

>  
>     and to the Linux Kernel development process rules.
>  
> @@ -97,18 +101,17 @@ rules::
>     my commit rights.
>  
>     I am aware that the Kernel development rules change over time.
> -   By doing a new push to media-committer tree, I understand that I agree
> +   By doing a new push to media-committers tree, I understand that I agree
>     to follow the rules in effect at the time of the commit.
>  
> -That e-mail shall be signed with a PGP key cross signed by other Kernel and
> -media developers. As described at :ref:`media-developers-gpg`, the PGP
> -signature, together with the gitlab user security are fundamental components
> -that ensure the authenticity of the merge requests that will happen at the
> -media-committer.git tree.
> +That e-mail shall be signed via the Kernel Web of trust with a PGP key cross
> +signed by other Kernel and media developers. As described at
> +:ref:`media-developers-gpg`, the PGP signature, together with the gitlab user
> +security are fundamental components that ensure the authenticity of the merge
> +requests that will happen at the media-committers.git tree.
>  
> -In case the kernel development process changes, by merging new commits
> -to the
> -`media-committer tree <https://gitlab.freedesktop.org/linux-media/media-committers>`_,
> +In case the kernel development process changes, by merging new commits to the
> +`media-committers tree <https://gitlab.freedesktop.org/linux-media/media-committers>`_,
>  the Media Committer implicitly declares their agreement with the latest
>  version of the documented process including the contents of this file.
>  
> @@ -118,25 +121,27 @@ notify the Media Subsystem Maintainers about that decision.
>  .. note::
>  
>     1. Changes to the kernel media development process shall be announced in
> -      the media-committers mailinglist with a reasonable review period. All
> -      committers are automatically subscribed to that mailinglist;
> +      the media-committers mailing list with a reasonable review period. All
> +      committers are automatically subscribed to that mailing list;
>     2. Due to the distributed nature of the Kernel development, it is
>        possible that kernel development process changes may end being
> -      reviewed/merged at the linux-docs mailing list, specially for the
> -      contents under Documentation/process and for trivial typo fixes.
> +      reviewed/merged at the Linux Docs and/or at the Linux Kernel mailing
> +      lists, especially for the contents under Documentation/process and for
> +      trivial typo fixes.
>  
>  Media Core Committers
>  ---------------------
>  
> -As described in Documentation/driver-api/media/maintainer-entry-profile.rst
> +A Media Core Committer is a Media Core Maintainer with commit rights.
> +
> +As described in Documentation/driver-api/media/maintainer-entry-profile.rst,
>  a Media Core Maintainer maintains media core frameworks as well, besides
> -just drivers, and so is able to change core files and the media subsystem's
> -Kernel API. A Media Core Committer is a Media Core Maintainer with commit
> -rights. The extent of the core committer's grants will be detailed by the
> +just drivers, and so is allowed to change core files and the media subsystem's
> +Kernel API. The extent of the core committer's grants will be detailed by the
>  Media Subsystem Maintainers when they nominate a Media Core Committer.
>  
>  Existing Media Committers may become Media Core Committers and vice versa.
> -Such decisions will be taken in consensus between the Media Subsystem
> +Such decisions will be taken in consensus among the Media Subsystem
>  Maintainers.
>  
>  Media committers rules
> @@ -148,16 +153,16 @@ shall be merged as soon as possible, aiming to be merged at the same Kernel
>  cycle the bug is reported.
>  
>  Media committers shall behave accordingly to the rights granted by
> -the Media Subsystem Maintainers, specially with regards of the scope of changes
> +the Media Subsystem Maintainers, especially with regards of the scope of changes
>  they may apply directly at the media-committers tree. That scope can
> -change over time on a mutual agreement between media committers and
> -maintainers.
> +change over time on a mutual agreement between Media Committers and
> +Media Subsystem Maintainers.
>  
>  The Media Committer workflow is described at :ref:`Media development workflow`.
>  
>  .. _Maintain Media Status:
>  
> -Maintaining media maintainer or committer status
> +Maintaining Media Maintainer or Committer status
>  ------------------------------------------------
>  
>  A community of maintainers working together to move the Linux Kernel
> @@ -165,27 +170,27 @@ forward is essential to creating successful projects that are rewarding
>  to work on. If there are problems or disagreements within the community,
>  they can usually be solved through healthy discussion and debate.
>  
> -In the unhappy event that a media maintainer or committer continues to
> +In the unhappy event that a Media Maintainer or Committer continues to
>  disregard good citizenship (or actively disrupts the project), we may need
>  to revoke that person's status. In such cases, if someone suggests the
> -revocation with a good reason, then after discussing this among the media
> -maintainers, the final decision is taken by the Media Subsystem Maintainers.
> -As the decision to become a media maintainer or committer comes from a
> -consensus between Media Subsystem Maintainers, a single subsystem maintainer
> -not trusting the media maintainer or committer anymore is enough to revoke
> -the maintenance/patchwork or commit rights.
> +revocation with a good reason, then after discussing this among the Media
> +Maintainers, the final decision is taken by the Media Subsystem Maintainers.
>  
> -A previous committer that had their commit rights revoked can keep
> -contributing to the subsystem via the pull request workflow as documented
> -at the :ref:`Media development workflow`, unless they were also removed as
> -Media Maintainer.
> +As the decision to become a Media Maintainer or Committer comes from a
> +consensus between Media Subsystem Maintainers, a single Media Subsystem
> +Maintainer not trusting the Media Maintainer or Committer anymore is enough
> +to revoke their maintenance, Patchwork grants and/or commit rights.
> +
> +Having commit rights revoked doesn't prevent Media Maintainers to keep
> +contributing to the subsystem either via the pull request or via email workflow
> +as documented at the :ref:`Media development workflow`.
>  
>  If a maintainer is inactive for more than a couple of Kernel cycles,
>  maintainers will try to reach you via e-mail. If not possible, they may
> -revoke your maintainer/patchwork and committer rights and update MAINTAINERS file
> -entries accordingly. If you wish to resume contributing later on, then contact
> -the Media Subsystem Maintainers to ask if your maintenance/patchwork and
> -commit rights can be restored.
> +revoke their maintainer/patchwork and committer rights and update MAINTAINERS
> +file entries accordingly. If you wish to resume contributing as maintainer
> +later on, then contact the Media Subsystem Maintainers to ask if your
> +maintenance, Patchwork grants and commit rights can be restored.
>  
>  References
>  ----------


Regards,

	Hans

Re: [PATCH 2/2] docs: media: media-committer: do some editorial changes

[Mauro Carvalho Chehab]

On Thu, Feb 05, 2026 at 12:52:35PM +0100, Hans Verkuil wrote:
> Hi Mauro,
> 
> For the most part I agree, but I have some suggestions regarding the point 4
> you added, since I think it just restates what is already mentioned in
> maintainer-entry-profile.rst.
> 
> Let me know what you think of my suggestions.
> 
> On 2/4/26 15:37, Mauro Carvalho Chehab wrote:
> > Do some editorial changes to make it look clearer:
> > 
> >   - media-committers tree references corrected from singular to plural;
> >   - updated commit rights wording and responsibilities;
> >   - fixed various typographical errors;
> >   - corrected “mailing list” and “Kernel” references;
> >   - improved core committer description;
> >   - updated documentation paths and URLs;
> >   - added missing “for” and improved sentence flow.
> > 
> > Perhaps the most relevant change is that i removed a word
> > that was requiring granting Patchwork rights some time before
> > adding commit rights (we may grant them altogether if makes
> > sense for us), and I added a 4th note to committer notes
> > list to let it clear that about what it is expected from a
> > committer with regards to updating Patchwork.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > ---
> >  .../driver-api/media/media-committer.rst      | 97 ++++++++++---------
> >  1 file changed, 51 insertions(+), 46 deletions(-)
> > 
> > diff --git a/Documentation/driver-api/media/media-committer.rst b/Documentation/driver-api/media/media-committer.rst
> > index 18cce6e06a2b..c83e94750e57 100644
> > --- a/Documentation/driver-api/media/media-committer.rst
> > +++ b/Documentation/driver-api/media/media-committer.rst
> > @@ -20,8 +20,8 @@ and the Linux Media community.
> >  
> >  .. Note::
> 
> Re-reading this I don't really think this should be a note at all. This just
> lists the additional responsibilities of a media committer, no need to
> present this as a 'note'.

Agreed.

> >  
> > -   1. Patches you authored must have a Signed-off-by, Reviewed-by or Acked-by
> > -      of another Media Maintainer;
> > +   1. Patches you authored must have a ``Signed-off-by``, ``Reviewed-by``
> > +      or ``Acked-by`` from another Media Maintainer;
> >     2. If a patch introduces a regression, then it is the Media Committer's
> >        responsibility to correct that as soon as possible. Typically the
> >        patch is either reverted, or an additional patch is committed to
> > @@ -29,14 +29,18 @@ and the Linux Media community.
> >     3. If patches are fixing bugs against already released Kernels, including
> >        the reverts above mentioned, the Media Committer shall add the needed
> >        tags. Please see :ref:`Media development workflow` for more details.
> > +   4. All Media Committers are responsible for maintaining
> > +      `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> > +      updating the state of the patches they review or merge.
> > +
> 
> I don't really agree with this. Not that it hurts, but maintaining patchwork
> is a job of media maintainers.

Not really: "normal" media driver maintainers don't need to do that, and, even
if we write they should, I doubt most would.

In practice, I expect only core maintainers, subsystem maitnainers and a couple
of driver maintainers to actually update it.

I'd like to keep a mention here, as we expect media committers to actually
read this file and understand what it is expected from them. As such,
it doesn't hurt letting something explicit here.

The point is: if a committer forgets to update it, we may end having the
same patch being reviewed by two people at different moments, wasting
precious review time. Worse than that, if a rejected patch was kept
as new on patchwork, another committer may end wrongly merging it.

> The only addition for committers is that they
> have to update patches in patchwork to 'Accepted' when they have committed
> them. That is certainly worth mentioning (including updating the maintainers
> profile to clearly state that only committers can set it to Accepted.

With the "committers hat", yes: most of the time it will be just "Accepted",
but, even so, if they pick a series with duplicated patches, other status
needs to be updated, like "duplicated" and "superseeded". 

> So in maintainer-entry-profile.rst in 1.3 I would change the description for
> the Accepted state to:
> 
> "Accepted: Once a patch is merged in the media-committers tree. Only Media
> Maintainers with commit rights can set this state."

Sounds good.

> And change point 4 to this:
> 
> 4. After committing a patch, the Media Committer must also update the
>    patch status to ``Accepted`` in
>    `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.

I would avoid restricting it - or if you want to verbose what status
type, those are the ones we currently have on patchwork(*):

	Under Review
	Accepted
	Rejected
	RFC
	Not Applicable
	Changes Requested
	Awaiting Upstream
	Superseded
	Deferred
	Obsoleted	
	TODO
	driver maintainer
	Duplicated

(*) Heh, there are some that we only used for a very short period of time,
    or maybe even never used, but we can't delete status there without
    causing potential issues to the database.

> 
> >  
> >  Becoming a Media Committer
> >  --------------------------
> >  
> >  Existing Media Committers can nominate a Media Maintainer to be granted
> > -commit rights. The Media Maintainer must already have patchwork access and
> > -have been in that role for some time, and has demonstrated a good
> > -understanding of the maintainer's duties and processes.
> > +commit rights. The Media Maintainer must have patchwork access,
> > +have been reviewing patches from third parties for some time, and has
> > +demonstrated a good understanding of the maintainer's duties and processes.
> >  
> >  The ultimate responsibility for accepting a nominated committer is up to
> >  the Media Subsystem Maintainers. The nominated committer must have earned a
> > @@ -61,8 +65,8 @@ Media Committer's agreement
> >  Once a nominated committer is accepted by all Media Subsystem Maintainers,
> >  they will ask if the developer is interested in the nomination and discuss
> >  what area(s) of the media subsystem the committer will be responsible for.
> > -Those areas will typically be the same as the areas that are already
> > -maintained by the nominated committer.
> > +Those areas will typically be the same as the areas that the nominated
> > +committer is already maintaining.
> >  
> >  When the developer accepts being a committer, the new committer shall
> >  explicitly accept the Kernel development policies described under its
> > @@ -77,7 +81,7 @@ following the model below::
> >  
> >     ...
> >  
> > -   For the purpose of committing patches to the media-committer's tree,
> > +   For the purpose of committing patches to the media-committers tree,
> >     I'll be using my user https://gitlab.freedesktop.org/users/<username>.
> >  
> >  Followed by a formal declaration of agreement with the Kernel development
> > @@ -85,7 +89,7 @@ rules::
> >  
> >     I agree to follow the Kernel development rules described at:
> >  
> > -   https://www.kernel.org/doc/html/latest/driver-api/media/media-committer.rst
> > +   https://www.kernel.org/doc/html/latest/driver-api/media/media-committers.rst
> 
> BTW, I agree that this file should be renamed to media-committers.rst. That matches
> the name of our git tree as well.

Good. Please check at the maintainers profile if we don't have a reference with
the singular when submitting v8, as I guess we have.

Regards,
Mauro

Re: [PATCH 1/2] docs: media: maintainer-entry-profile: do some editorial reviews

[Mauro Carvalho Chehab]

On Thu, Feb 05, 2026 at 12:25:39PM +0100, Hans Verkuil wrote:
> Hi Mauro,
> 
> Looks good. Just three minor issues (two typos, and one suggestion for a better word).

Good enough for me.

> 
> If there are no objections, then I will just make those changes and fold it into this
> patch for v8.
> 
> Regards,
> 
> 	Hans

Regards,
Mauro

> 
> On 2/4/26 15:37, Mauro Carvalho Chehab wrote:
> > Do some editorial improvements to the Media Subsystem Profile
> > documentation:
> > 
> > - Some English fixups and cleanups;
> > - Capitalize patchwork;
> > - Uncapitalize pull requests, as other occurrences are in lower case;
> > - Added bold markups to the 3 types of media maintainers;
> > - ensure that the document uses 80 chars per line;
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > ---
> >  .../media/maintainer-entry-profile.rst        | 157 +++++++++---------
> >  1 file changed, 80 insertions(+), 77 deletions(-)
> > 
> > diff --git a/Documentation/driver-api/media/maintainer-entry-profile.rst b/Documentation/driver-api/media/maintainer-entry-profile.rst
> > index 0024f85101b7..bb95611f0a84 100644
> > --- a/Documentation/driver-api/media/maintainer-entry-profile.rst
> > +++ b/Documentation/driver-api/media/maintainer-entry-profile.rst
> > @@ -4,7 +4,7 @@ Media Subsystem Profile
> >  Overview
> >  --------
> >  
> > -The Linux Media Community (aka: the LinuxTV Community) is formed of
> > +The Linux Media Community (aka: the LinuxTV Community) is formed by
> >  developers working on Linux Kernel Media Subsystem, together with users
> >  who also play an important role in testing the code.
> >  
> > @@ -27,7 +27,7 @@ tree:
> >  .. [1] Device tree bindings are maintained by the
> >         OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS maintainers
> >         (see the MAINTAINERS file). So, changes there must be reviewed
> > -       by them before being merged via the media subsystem's development
> > +       by them before being merged into the media subsystem's development
> >         tree.
> >  
> >  Both media userspace and Kernel APIs are documented and the documentation
> > @@ -38,32 +38,33 @@ corresponding API documentation.
> >  Media Maintainers
> >  -----------------
> >  
> > +Media Maintainers are not just people capable of writing code, but they
> > +are developers who have demonstrated their ability to collaborate with
> > +the team, get the most knowledgeable people to review code, contribute
> > +high-quality code, and follow through to fix issues (in code or tests).
> > +
> >  Due to the size and wide scope of the media subsystem, multiple layers of
> >  maintainers are required, each with their own areas of expertise:
> >  
> > -- Media Driver Maintainer:
> > -    Responsible for one or more drivers within the Media Subsystem. You
> > +- **Media Driver Maintainer**:
> > +    Responsible for one or more drivers within the Media Subsystem. They
> >      are listed in the MAINTAINERS file as maintainer for those drivers. Media
> >      Driver Maintainers review patches for those drivers, provide feedback if
> > -    the patches are not following the subsystem rules, or are not using the
> > -    media kernel or userspace APIs correctly, or have poor code quality.
> > +    patches do not follow the subsystem rules, or are not using the
> > +    media kernel or userspace APIs correctly, or if they have poor code
> > +    quality.
> >  
> > -    If you are the author of the patches, then you work with other Media
> > +    If you are the patch author, you work with other Media
> >      Maintainers to ensure your patches are reviewed.
> >  
> > -    Some Media Driver Maintainers have additional responsibilities.  They have
> > -    been granted patchwork access and keep
> > -    `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> > +    Some Media Driver Maintainers have additional responsibilities. They have
> > +    been granted Patchwork access and keep
> > +    `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> >      up to date, decide when patches are ready for merging, and create Pull
> >      Requests for the Media Subsystem Maintainers to merge.
> >  
> > -    Such Media Driver Maintainers are not just someone who is capable of creating code,
> > -    but someone who has demonstrated their ability to collaborate with the team,
> > -    get the most knowledgeable people to review code, contribute high-quality code,
> > -    and follow through to fix issues (in code or tests).
> > -
> > -- Media Core Maintainer:
> > -    Media Driver Maintainers with patchwork access who are also responsible for
> > +- **Media Core Maintainer**:
> > +    Media Driver Maintainers with Patchwork access who are also responsible for
> >      one or more media core frameworks.
> >  
> >      Core framework changes are done via consensus between the relevant Media
> > @@ -71,22 +72,21 @@ maintainers are required, each with their own areas of expertise:
> >      their Pull Requests if they are signed off by the relevant Media Core
> >      Maintainers.
> >  
> > -- Media Subsystem Maintainers:
> > -    Media Core Maintainers who are also responsible for the subsystem as a whole,
> > -    with access to the entire subsystem. Responsible for merging Pull Requests
> > -    from other Media Maintainers.
> > +- **Media Subsystem Maintainers**:
> > +    Media Core Maintainers who are also responsible for the subsystem as a
> > +    whole, with access to the entire subsystem. Responsible for merging Pull
> > +    Requests from other Media Maintainers.
> >  
> > -    Userspace API/ABI changes are done via consensus between Media Subsystem
> > +    Userspace API/ABI changes are made via consensus among Media Subsystem
> >      Maintainers\ [2]_. Media Maintainers may include API/ABI changes in
> > -    their Pull Requests if they are signed off by the all Media Subsystem
> > +    their pull requests if they are signed off by all Media Subsystem
> >      Maintainers.
> >  
> > -All Media Maintainers shall explicitly agree with the Kernel development process
> > -as described at Documentation/process/index.rst and to the Kernel
> > -development rules inside the Kernel documentation, including its code of
> > -conduct.
> > +All Media Maintainers shall agree with the Kernel development process as
> > +described in Documentation/process/index.rst and with the Kernel development
> > +rules in the Kernel documentation, including its code of conduct.
> >  
> > -Media Maintainers are reachable via the #linux-media IRC channel at OFTC.
> > +Media Maintainers are often reachable via the #linux-media IRC channel at OFTC.
> >  
> >  .. [2] Everything that would break backward compatibility with existing
> >         non-kernel code are API/ABI changes. This includes ioctl and sysfs
> > @@ -95,8 +95,8 @@ Media Maintainers are reachable via the #linux-media IRC channel at OFTC.
> >  Patchwork Access
> >  ----------------
> >  
> > -All Media Maintainers who have been granted patchwork access shall ensure that
> > -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> > +All Media Maintainers who have been granted Patchwork access shall ensure that
> > +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> >  will reflect the current status, e.g. patches shall be delegated to the Media
> >  Maintainer who is handling them and the patch status shall be updated according
> >  to these rules:
> > @@ -112,28 +112,28 @@ to these rules:
> >    tree (e.g. drm, dmabuf, upstream merge, etc.) but were cross-posted to the
> >    linux-media mailing list.
> >  
> > -If a Media Maintainer decides not to accept a patch, then reply by email to
> > -the patch authors, explaining why it is not accepted, and
> > -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_ shall be
> > -updated accordingly with either:
> > +If Media Maintainers decide not to accept a patch, they should reply to the
> > +patch authors by e‑mail, explaining why it is not accepted, and
> > +update `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> > +accordingly with one of the following statuses:
> >  
> >  - ``Changes Requested``: if a new revision was requested;
> >  - ``Rejected``: if the proposed change is not acceptable at all.
> >  
> >  .. Note::
> >  
> > -   Patchwork supports a couple of clients to help semi-automating
> > +   Patchwork supports a couple of clients to help semi-automate
> >     status updates via its REST interface:
> >  
> >     https://patchwork.readthedocs.io/en/latest/usage/clients/
> >  
> > -For those patches that fall in your area of responsibility you alse decide
> > -when those patches are ready for merging, and create Pull Requests for the
> > -Media Subsystem Maintainers to merge.
> > +For patches that fall within their area of responsibility a Media Maintainer
> > +also decide when those patches are ready for merging, and create Pull Requests
> 
> decide -> decides
> 
> > +for the Media Subsystem Maintainers to merge.
> >  
> > -The most important aspect of becoming a Media Maintainer with patchwork access
> > -is that you have demonstrated the ability to give good code reviews. So we are
> > -looking for whether or not we think you will be good at doing that.
> > +The most important aspect of becoming a Media Maintainer with Patchwork access
> > +is that you have demonstrated an ability to give good code reviews. We value
> > +your ability to deliver thorough, constructive code reviews.
> >  
> >  As such, potential maintainers must earn enough credibility and trust from the
> >  Linux Media Community. To do that, developers shall be familiar with the open
> > @@ -145,7 +145,7 @@ demonstrating your:
> >  
> >  - commitment to the project;
> >  - ability to collaborate with the team and communicate well;
> > -- understand of how upstream and the Linux Media Community work
> > +- understanding of how upstream and the Linux Media Community work
> >    (policies, processes for testing, code review, ...)
> >  - reasonable knowledge about:
> >  
> > @@ -160,9 +160,9 @@ demonstrating your:
> >  - ability to judge when a patch might be ready for review and to submit;
> >  - ability to write good code (last but certainly not least).
> >  
> > -Media Driver Maintainers that desire to get patchwork access are encouraged
> > +Media Driver Maintainers that desire to get Patchwork access are encouraged
> >  to participate at the yearly Linux Media Summit, typically co-located with
> > -a Linux related conference. These summits are announced on the linux-media
> > +a Linux-related conference. These summits are announced on the linux-media
> >  mailing list.
> >  
> >  If you are doing such tasks and have become a valued developer, an
> > @@ -170,8 +170,8 @@ existing Media Maintainer can nominate you to the Media Subsystem Maintainers.
> >  
> >  The ultimate responsibility for accepting a nominated maintainer is up to
> >  the subsystem's maintainers. The nominated maintainer must have earned a trust
> > -relationship with all Media Subsystem Maintainers, as, by being granted patchwork
> > -access, you will take over part of their maintenance tasks.
> > +relationship with all Media Subsystem Maintainers, as, by being granted
> > +Patchwork access, you will take over part of their maintenance tasks.
> >  
> >  Media Committers
> >  ----------------
> > @@ -191,14 +191,18 @@ The main development tree used by the media subsystem is hosted at
> >  https://gitlab.freedesktop.org/linux-media/.
> >  https://linuxtv.org/ hosts news about the subsystem,
> >  `wiki <https://www.linuxtv.org/wiki/index.php/Main_Page>`_ pages
> > -and a `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> > +and a `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> >  instance where we track patches though their lifetime.
> >  
> > -The main tree used by media developers is at:
> > +The stable tree used by media developers is at:
> > +
> > +https://git.linuxtv.org/media.git/
> > +
> > +Patches there are initially committed to the media committers tree:
> >  
> >  https://gitlab.freedesktop.org/linux-media/media-committers.git
> >  
> > -Please note that this tree can be rebased, although only as a last resort.
> > +Please note that the later can be rebased, although only as a last resort.
> 
> later -> latter
> 
> >  
> >  .. _Media development workflow:
> >  
> > @@ -217,11 +221,11 @@ you can find details about how to subscribe to it and to see its archives at:
> >  
> >  Emails with HTML will be automatically rejected by the mail server.
> >  
> > -It could be wise to also copy the Media Maintainer(s). You should use
> > +It could be wise to also copy the relevant Media Maintainer(s). You should use
> >  ``scripts/get_maintainers.pl`` to identify whom else needs to be copied.
> >  Please always copy driver's authors and maintainers.
> >  
> > -To minimize the chance of merge conflicts for your patch series, and make
> > +To minimize the chance of merge conflicts for your patch series, and make it
> >  easier to backport patches to stable Kernels, we recommend that you use the
> >  following baseline for your patch series:
> >  
> > @@ -267,13 +271,14 @@ workflows:
> >  a. Media Maintainers' workflow: Media Maintainers post the PRs, which are
> >     handled by the Media Subsystem Maintainers::
> >  
> > -     +-------+   +------------+   +------+   +-------+   +----------------------------+
> > -     |e-mail |-->|picked up by|-->|code  |-->|pull   |-->|Subsystem Maintainers merge |
> > -     |to LMML|   |patchwork   |   |review|   |request|   |in media-committers.git     |
> > -     +-------+   +------------+   +------+   +-------+   +----------------------------+
> > +     +-------+   +------------+   +------+   +-------+   +---------------------+
> > +     |e-mail |-->|picked up by|-->|code  |-->|pull   |-->|Subsystem Maintainers|
> > +     |to LMML|   |Patchwork   |   |review|   |request|   |merge in             |
> > +     |       |   |            |   |      |   |       |   |media-committers.git |
> > +     +-------+   +------------+   +------+   +-------+   +---------------------+
> >  
> >     For this workflow, pull requests are generated by Media Maintainers with
> > -   patchwork access.  If you do not have patchwork access, then please don't
> > +   Patchwork access.  If you do not have Patchwork access, then please don't
> >     submit pull requests, as they will not be processed.
> >  
> >  b. Media Committers' workflow: patches are handled by Media Maintainers with
> > @@ -281,15 +286,14 @@ b. Media Committers' workflow: patches are handled by Media Maintainers with
> >  
> >       +-------+   +------------+   +------+   +--------------------------+
> >       |e-mail |-->|picked up by|-->|code  |-->|Media Committers merge in |
> > -     |to LMML|   |patchwork   |   |review|   |media-committers.git      |
> > +     |to LMML|   |Patchwork   |   |review|   |media-committers.git      |
> >       +-------+   +------------+   +------+   +--------------------------+
> >  
> >  When patches are picked up by
> > -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> > -and when merged at media-committers,
> > -Media CI bots will check for errors and may provide e-mail feedback about
> > -patch problems. When this happens, the patch submitter must fix them or
> > -explain why the errors are false positives.
> > +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_
> > +and when merged at media-committers, Media CI bots will check for errors and
> > +may provide e-mail feedback about patch problems. When this happens, the patch
> > +submitter must fix them or explain why the errors are false positives.
> >  
> >  Patches will only be moved to the next stage in these two workflows if they
> >  pass on Media CI or if there are false-positives in the Media CI reports.
> > @@ -327,18 +331,17 @@ server has accepted your patch, by looking at:
> >     - https://lore.kernel.org/linux-media/
> >  
> >  If the patch is there and not at
> > -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> > -it is likely that your e-mailer
> > -mangled the patch. Patchwork internally has logic that checks if the
> > -received e-mail contains a valid patch. Any whitespace and new line
> > -breakages mangling the patch won't be recognized by
> > -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> > +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> > +it is likely that your e-mailer mangled the patch. Patchwork internally
> > +has logic that checks if the received e-mail contains a valid patch.
> > +Any whitespace and new line breakages mangling the patch won't be recognized by
> > +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
> >  and such a patch will be rejected.
> >  
> >  .. [3] It usually takes a few minutes for the patch to arrive, but
> > -       the e-mail server may be busy, so it may take up a longer time
> > +       the e-mail server may be busy, so it may take a longer time
> >         for a patch to be picked by
> > -       `patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.
> > +       `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.
> >  
> >  .. [4] If your email contains HTML, the mailing list server will simply
> >         drop it, without any further notice.
> > @@ -349,8 +352,8 @@ Authentication for pull and merge requests
> >  ++++++++++++++++++++++++++++++++++++++++++
> >  
> >  The authenticity of developers submitting pull requests and merge requests
> > -shall be validated by using PGP signing at some moment.
> > -See: :ref:`kernel_org_trust_repository`.
> > +shall be validated by using the Linux Kernel Web of Trust, with PGP signing
> > +at some moment. See: :ref:`kernel_org_trust_repository`.
> >  
> >  With the pull request workflow, pull requests shall use PGP-signed tags.
> >  
> > @@ -494,11 +497,11 @@ least, simply wrapping the lines.
> >  In particular, we accept lines with more than 80 columns:
> >  
> >      - on strings, as they shouldn't be broken due to line length limits;
> > -    - when a function or variable name need to have a big identifier name,
> > -      which keeps hard to honor the 80 columns limit;
> > +    - when a function or variable name needs to have a large identifier name,
> 
> large -> long ('long' makes much more sense in this context)
> 
> > +      which makes hard to honor the 80 columns limit;
> >      - on arithmetic expressions, when breaking lines makes them harder to
> >        read;
> > -    - when they avoid a line to end with an open parenthesis or an open
> > +    - when they avoid a line ending with an open parenthesis or an open
> >        bracket.
> >  
> >  Key Cycle Dates
> > @@ -512,7 +515,7 @@ Review Cadence
> >  --------------
> >  
> >  Provided that your patch has landed in
> > -`patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_, it
> > +`Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_, it
> >  should be sooner or later handled, so you don't need to re-submit a patch.
> >  
> >  Except for important bug fixes, we don't usually add new patches to the
> > @@ -525,4 +528,4 @@ other developers to publicly add ``Reviewed-by:`` and, more importantly,
> >  ``Tested-by:`` tags.
> >  
> >  Please note that we expect a detailed description for ``Tested-by:``,
> > -identifying what boards were used at the test and what it was tested.
> > +identifying what boards were used during the test and what it was tested.
> 

-- 
Thanks,
Mauro

Re: [PATCH 2/2] docs: media: media-committer: do some editorial changes

[Hans Verkuil]

On 2/5/26 14:51, Mauro Carvalho Chehab wrote:
> On Thu, Feb 05, 2026 at 12:52:35PM +0100, Hans Verkuil wrote:
>> Hi Mauro,
>>
>> For the most part I agree, but I have some suggestions regarding the point 4
>> you added, since I think it just restates what is already mentioned in
>> maintainer-entry-profile.rst.
>>
>> Let me know what you think of my suggestions.
>>
>> On 2/4/26 15:37, Mauro Carvalho Chehab wrote:
>>> Do some editorial changes to make it look clearer:
>>>
>>>   - media-committers tree references corrected from singular to plural;
>>>   - updated commit rights wording and responsibilities;
>>>   - fixed various typographical errors;
>>>   - corrected “mailing list” and “Kernel” references;
>>>   - improved core committer description;
>>>   - updated documentation paths and URLs;
>>>   - added missing “for” and improved sentence flow.
>>>
>>> Perhaps the most relevant change is that i removed a word
>>> that was requiring granting Patchwork rights some time before
>>> adding commit rights (we may grant them altogether if makes
>>> sense for us), and I added a 4th note to committer notes
>>> list to let it clear that about what it is expected from a
>>> committer with regards to updating Patchwork.
>>>
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>>> ---
>>>  .../driver-api/media/media-committer.rst      | 97 ++++++++++---------
>>>  1 file changed, 51 insertions(+), 46 deletions(-)
>>>
>>> diff --git a/Documentation/driver-api/media/media-committer.rst b/Documentation/driver-api/media/media-committer.rst
>>> index 18cce6e06a2b..c83e94750e57 100644
>>> --- a/Documentation/driver-api/media/media-committer.rst
>>> +++ b/Documentation/driver-api/media/media-committer.rst
>>> @@ -20,8 +20,8 @@ and the Linux Media community.
>>>  
>>>  .. Note::
>>
>> Re-reading this I don't really think this should be a note at all. This just
>> lists the additional responsibilities of a media committer, no need to
>> present this as a 'note'.
> 
> Agreed.
> 
>>>  
>>> -   1. Patches you authored must have a Signed-off-by, Reviewed-by or Acked-by
>>> -      of another Media Maintainer;
>>> +   1. Patches you authored must have a ``Signed-off-by``, ``Reviewed-by``
>>> +      or ``Acked-by`` from another Media Maintainer;
>>>     2. If a patch introduces a regression, then it is the Media Committer's
>>>        responsibility to correct that as soon as possible. Typically the
>>>        patch is either reverted, or an additional patch is committed to
>>> @@ -29,14 +29,18 @@ and the Linux Media community.
>>>     3. If patches are fixing bugs against already released Kernels, including
>>>        the reverts above mentioned, the Media Committer shall add the needed
>>>        tags. Please see :ref:`Media development workflow` for more details.
>>> +   4. All Media Committers are responsible for maintaining
>>> +      `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_,
>>> +      updating the state of the patches they review or merge.
>>> +
>>
>> I don't really agree with this. Not that it hurts, but maintaining patchwork
>> is a job of media maintainers.
> 
> Not really: "normal" media driver maintainers don't need to do that, and, even
> if we write they should, I doubt most would.

This applies to maintainers with patchwork rights. If you have patchwork access,
then I expect them to keep it up to date for those areas that they maintain.

> 
> In practice, I expect only core maintainers, subsystem maitnainers and a couple
> of driver maintainers to actually update it.

I.e., those with patchwork access.

> 
> I'd like to keep a mention here, as we expect media committers to actually
> read this file and understand what it is expected from them. As such,
> it doesn't hurt letting something explicit here.
> 
> The point is: if a committer forgets to update it, we may end having the
> same patch being reviewed by two people at different moments, wasting
> precious review time. Worse than that, if a rejected patch was kept
> as new on patchwork, another committer may end wrongly merging it.
> 
>> The only addition for committers is that they
>> have to update patches in patchwork to 'Accepted' when they have committed
>> them. That is certainly worth mentioning (including updating the maintainers
>> profile to clearly state that only committers can set it to Accepted.
> 
> With the "committers hat", yes: most of the time it will be just "Accepted",
> but, even so, if they pick a series with duplicated patches, other status
> needs to be updated, like "duplicated" and "superseeded". 
> 
>> So in maintainer-entry-profile.rst in 1.3 I would change the description for
>> the Accepted state to:
>>
>> "Accepted: Once a patch is merged in the media-committers tree. Only Media
>> Maintainers with commit rights can set this state."
> 
> Sounds good.
> 
>> And change point 4 to this:
>>
>> 4. After committing a patch, the Media Committer must also update the
>>    patch status to ``Accepted`` in
>>    `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_.
> 
> I would avoid restricting it - or if you want to verbose what status
> type, those are the ones we currently have on patchwork(*):

I'll just keep your point 4. In the end it doesn't hurt.

Regards,

	Hans

> 
> 	Under Review
> 	Accepted
> 	Rejected
> 	RFC
> 	Not Applicable
> 	Changes Requested
> 	Awaiting Upstream
> 	Superseded
> 	Deferred
> 	Obsoleted	
> 	TODO
> 	driver maintainer
> 	Duplicated
> 
> (*) Heh, there are some that we only used for a very short period of time,
>     or maybe even never used, but we can't delete status there without
>     causing potential issues to the database.
> 
>>
>>>  
>>>  Becoming a Media Committer
>>>  --------------------------
>>>  
>>>  Existing Media Committers can nominate a Media Maintainer to be granted
>>> -commit rights. The Media Maintainer must already have patchwork access and
>>> -have been in that role for some time, and has demonstrated a good
>>> -understanding of the maintainer's duties and processes.
>>> +commit rights. The Media Maintainer must have patchwork access,
>>> +have been reviewing patches from third parties for some time, and has
>>> +demonstrated a good understanding of the maintainer's duties and processes.
>>>  
>>>  The ultimate responsibility for accepting a nominated committer is up to
>>>  the Media Subsystem Maintainers. The nominated committer must have earned a
>>> @@ -61,8 +65,8 @@ Media Committer's agreement
>>>  Once a nominated committer is accepted by all Media Subsystem Maintainers,
>>>  they will ask if the developer is interested in the nomination and discuss
>>>  what area(s) of the media subsystem the committer will be responsible for.
>>> -Those areas will typically be the same as the areas that are already
>>> -maintained by the nominated committer.
>>> +Those areas will typically be the same as the areas that the nominated
>>> +committer is already maintaining.
>>>  
>>>  When the developer accepts being a committer, the new committer shall
>>>  explicitly accept the Kernel development policies described under its
>>> @@ -77,7 +81,7 @@ following the model below::
>>>  
>>>     ...
>>>  
>>> -   For the purpose of committing patches to the media-committer's tree,
>>> +   For the purpose of committing patches to the media-committers tree,
>>>     I'll be using my user https://gitlab.freedesktop.org/users/<username>.
>>>  
>>>  Followed by a formal declaration of agreement with the Kernel development
>>> @@ -85,7 +89,7 @@ rules::
>>>  
>>>     I agree to follow the Kernel development rules described at:
>>>  
>>> -   https://www.kernel.org/doc/html/latest/driver-api/media/media-committer.rst
>>> +   https://www.kernel.org/doc/html/latest/driver-api/media/media-committers.rst
>>
>> BTW, I agree that this file should be renamed to media-committers.rst. That matches
>> the name of our git tree as well.
> 
> Good. Please check at the maintainers profile if we don't have a reference with
> the singular when submitting v8, as I guess we have.
> 
> Regards,
> Mauro