From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E33E31A5B8B;
	Thu,  5 Feb 2026 01:26:31 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770254792; cv=none; b=PWh94Kv+T5STZINi0vLl/WDFAjm+QLxPEr/Jq248/UPNrUsTwaMZvNg5eqFP75qVGqo9Sb4NqwOOBQNq6bzcl1MopXX2CJCV+s+g7kTXwGCTBlPf4fn49jI3Q1UPDRAh836aneJ7gO29GvrKUVBy6bfcOxHvBgs2HEGAAu8hM2c=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770254792; c=relaxed/simple;
	bh=hjxysTPajKK2FZ1aXORytluX1M7dwqbn4j8lWHCg0/c=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=Y6TbEU7w6UsdEb83PHXePH7Wt7pzzjIp5jDgRAh4W1Z3a4GXTG9d+sm3myWPQ5GcQYzyqb2Arg9lvlZBt4pNlzkToO2cygWDAfKeCsCVmulyglSG+o+zkGSwDj/YNmet96E/PyaOkJrbKldkpN4qTa/hlG5FMIEREcPDBhjzwcY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GbBGR8QZ; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GbBGR8QZ"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD7CDC4CEF7;
	Thu,  5 Feb 2026 01:26:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770254791;
	bh=hjxysTPajKK2FZ1aXORytluX1M7dwqbn4j8lWHCg0/c=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=GbBGR8QZRyQf1w+JGOdQufOHYIHqbhaclPKXQu+FPwVTQlYMbyJh4dsZ74ICk/u7i
	 Yi+pqPsc7cWmSM5hwMlBzL2YH49kB5Bi+douYUfQnDepKf0Tr0ba2hOrn3+gGd87i4
	 I25scu4d1CtYK+hfjhOWyuOqbBmZkY+nvlq9TbMSChhO2tpFji4BLg/oNoLVtGIOf5
	 rHvFNsMv28+kKOAaOp+nh+43wyIFQ4TmylYSR17lufX08UxgD5ACPRVUmB1WM3iIaH
	 wV7D/1DSzi7r5DprXmNxWWz3xon3gs3HJOvy6uMbc+7QJ9t/+S0WxqhZo8qouhkizf
	 tJaDadsu0gvZg==
Date: Wed, 4 Feb 2026 17:26:28 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: bpf@vger.kernel.org, Claudiu Manoil <claudiu.manoil@nxp.com>, Vladimir
 Oltean <vladimir.oltean@nxp.com>, Wei Fang <wei.fang@nxp.com>, Clark Wang
 <xiaoning.wang@nxp.com>, Andrew Lunn <andrew+netdev@lunn.ch>, "David S.
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo
 Abeni <pabeni@redhat.com>, Tony Nguyen <anthony.l.nguyen@intel.com>,
 Przemek Kitszel <przemyslaw.kitszel@intel.com>, Alexei Starovoitov
 <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Jesper Dangaard
 Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>,
 Stanislav Fomichev <sdf@fomichev.me>, Andrii Nakryiko <andrii@kernel.org>,
 Martin KaFai Lau <martin.lau@linux.dev>, Eduard Zingerman
 <eddyz87@gmail.com>, Song Liu <song@kernel.org>, Yonghong Song
 <yonghong.song@linux.dev>, KP Singh <kpsingh@kernel.org>, Hao Luo
 <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, Simon Horman
 <horms@kernel.org>, Shuah Khan <shuah@kernel.org>, Alexander Lobakin
 <aleksander.lobakin@intel.com>, Maciej Fijalkowski
 <maciej.fijalkowski@intel.com>, "Bastien Curutchet (eBPF Foundation)"
 <bastien.curutchet@bootlin.com>, Tushar Vyavahare
 <tushar.vyavahare@intel.com>, Jason Xing <kernelxing@tencent.com>, "Ricardo
 B. =?UTF-8?B?TWFybGnDqHJl?=" <rbm@suse.com>, Eelco Chaudron
 <echaudro@redhat.com>, Lorenzo Bianconi <lorenzo@kernel.org>, Toke
 Hoiland-Jorgensen <toke@redhat.com>, imx@lists.linux.dev,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 intel-wired-lan@lists.osuosl.org, linux-kselftest@vger.kernel.org,
 Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH bpf 0/6] Address XDP frags having negative tailroom
Message-ID: <20260204172628.165ac4c8@kernel.org>
In-Reply-To: <20260203105417.2302672-1-larysa.zaremba@intel.com>
References: <20260203105417.2302672-1-larysa.zaremba@intel.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue,  3 Feb 2026 11:53:28 +0100 Larysa Zaremba wrote:
> Many ethernet drivers report xdp Rx queue frag size as being the same as
> DMA write size. However, the only user of this field, namely
> bpf_xdp_frags_increase_tail(), clearly expects a truesize.

truesize may not be the most fortunate term.
truesize is how much memory we charge to the skb (for memory management)
which may relate to frag size in strange ways for strange HW :S
I don't have a great term, but I have a feeling truesize already
confuses driver developers.

Note two our xdp.py tests covers tail adjust, I wonder if it would have
caught this for you. Looking at Intel's results the XDP tests don't run
due to missing BTF. Could you work with Adrian to address that?