From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55CD71FBCA7 for ; Thu, 5 Feb 2026 01:13:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770254018; cv=none; b=pylBoAx4+RorSDH+NqOzf0yCATsdGwpMoFwi39e3e+5YQmsc3FR48Aj6kNyCPWEWZIrS+nyalDF/zIiz/7eA0/6aFATxDb0a4fe0ksy+J4mJlh7mBdfl79+Q9JeY7lqDvYjA8OUmJaVkmDXgXpKQQ0e5PbY7ueAOIPHwGQVF8cQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770254018; c=relaxed/simple; bh=vJADyUOcqjwRV6DEcNkjCgVf8seqLpxNZ5PMOkYaC7A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ITw9xMP6vPtHCSjzAp6lRFdaXnLX/7bLXrIyLcstvmKRsmAaHq5up+XOH+a7CLCwynjetRIjcagdUXob7vugTNeuL/g418SySXYXyCwV+c98+uvA18i3xv5u7H+kv+bhlcg3YlIK7MTq3gm2fTm0MmbA2+QnE4hgf9e97aX878w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i4DBkxjm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i4DBkxjm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E3A0C16AAE; Thu, 5 Feb 2026 01:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770254017; bh=vJADyUOcqjwRV6DEcNkjCgVf8seqLpxNZ5PMOkYaC7A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i4DBkxjmdmi4sT5jg+10apvdLNCHGIr2e9CyhIQXkMhznZKeJDP7ElGLSbSPtg23h iWD0sRx4coGqbeGX8FRqYnnBcO8gFMgnON42tkPB7OXNF+ufUJ3TZXqX4BbsAIS0cj dAIfs/1fH8fPGhkK6OHU8VilspUnIwLgT8GyraQbvok5eWnlPfZ1zHhC92lHF2IeRo RnUyINkepqjbLrPqhs+Cs+cZ2sTj6HMsxxP/eTte22P3/YxgO4gfWzWzJqp0xtDBQH zxFmYb6oUpoLPfd8SSwrYnuuEEAF9qAx/U8BcGzzFdgOZYmx3oIbBkS1Pm+86U+vjw mctogAEhqcgPg== From: SeongJae Park To: Jiaqi Yan Cc: SeongJae Park , jane.chu@oracle.com, muchun.song@linux.dev, david@kernel.org, akpm@linux-foundation.org, osalvador@suse.de, william.roche@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fs: hugetlb: simplify remove_inode_hugepages() return type Date: Wed, 4 Feb 2026 17:13:29 -0800 Message-ID: <20260205011330.68096-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260204214741.3161520-1-jiaqiyan@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 4 Feb 2026 21:47:41 +0000 Jiaqi Yan wrote: > When remove_inode_hugepages is introduced in > commit c86272287bc6 ("hugetlb: create remove_inode_single_folio to remove single file folio") Why don't you wrap the above line for the 75 columns limit [1]? > it used to return a boolean to indicate if it bailed out due to race with > page faults. However, since the race is already solved by [1], > remove_inode_hugepages() doesn't have any path to return false anymore. > > Simplify remove_inode_hugepages() return type to void, remove the > unnecessary ret variable, and adjust the call site in > remove_inode_hugepages(). No functional change in this commit. > > Changelog > ========= > > v2 -> v1 [2] > > - Use two-tab alignment for parameters wrapped to new lines. > > - Remove return type in remove_inode_hugepages()'s comment. > > [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle.com > [2] https://lore.kernel.org/linux-mm/20260202233617.2350734-1-jiaqiyan@google.com I found David and Andrew replied the changelog will be removed in the final one, so will not add comment. > > Suggested-by: Jane Chu > Reviewed-by: Jane Chu > Reviewed-by: Muchun Song > Acked-by: David Hildenbrand (arm) > Signed-off-by: Jiaqi Yan The above comment is only trivial, and the diff looks good to me. So, Reviewed-by: SeongJae Park Thanks, SJ [...]