From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 641C030BB81 for ; Fri, 6 Feb 2026 14:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770389576; cv=none; b=GNQMhN9RM+e0X0gh5bJUOvsNRDZM4wSlMUYhy3zbVpTJY+HsvMoBt/scwzPXQLflUT46KTvadbkwBR+vWXlgC31E+6Ja7fU5d2FCdi7HvPWHj5XGnQruJ4adeawgasOWwOp6q+LULylj70/dwVwTwejv5Aa2srKtqlMCDXYIo4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770389576; c=relaxed/simple; bh=xPT/PnF3ipMXdL5HZ2UKdG57rjeVd9R8W089sYF7aAY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dYBUaTv48UCtJWgAhj9P3bI2cuNVUUqHfWlVi2k/asXrq24Kd/1SHHc+OsVhqOgpXGEbtfJmDm8Be6K8zkFphFRpJlrUUMzzUED/5WTP6VZk3NJ+GmUBMwVZs2me12xTYHBiK+RrP8ErZH8znh1Yx07gpb2ZrzbnFxm5OwoB9iI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=kMuTvzoB; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kMuTvzoB" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-894676e6863so23660376d6.2 for ; Fri, 06 Feb 2026 06:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1770389575; x=1770994375; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k4lWKDjYMmNvH5qtebOMTo91r7WdaMfGxrMq2YU34WE=; b=kMuTvzoBWnAtEBOwag3UlwLUmz68ceOGMATz5BkExynwKeWTSD6EhwXMstDhjzUBv3 DopLRy/OQd6zQ5fxtzHbFEVoGTDIxOuGUKY79JoZvSG7NN9kQKC6uZgfRS+eo8Gs8q7H c5dHrBnPZR1F5/lHSGaoB70DZhVc+eqzhY2Y0eEW3CTd/b/GaLvLOjnZQ0BxaTnnnVxm bf1AL5tEfT5SGuDfGdz08lA1KtbiPdoUemZttlZb7G3J7hdvCHFy4ECPqAmknb2Q2sRL WDjrozpchy4YeVwVstGh9SYMSJzGbLlzEbh36/u5mh8SvTEQvkZIDOezVJ4qF8bQxbzj ES8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770389575; x=1770994375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k4lWKDjYMmNvH5qtebOMTo91r7WdaMfGxrMq2YU34WE=; b=s8d3NkJcKgChmj3pZdTq2q/gM6UQ7qfNx46ED8Eint3sBmRwSDwQfX3cJo7Klq6pVn 5sk58VjJX+zj+vqKoFkwsW6KrWkMua1GEXmEH3+Fh82E/Us0eC8lZB0J6HiXMvCESMhG 8X2ybRgRXAP/RlEMcMEWTxvPoBhSr920BcuwPNzB0UQnnoJvAzw7Ht5UZk+tm70gnHMq kwRoByrSeLtB+o18jnR94NG4u3IAI8s29KNkfAtIGStqZ8djSiFXODk2FMov2x0R/DkG TYQKgoOrTse1yKM2TBGMIJ+tTWWQmYuq2p9igoYTMoBZ0D309ZirlR8sU+LQRY7so/+z 7d2A== X-Forwarded-Encrypted: i=1; AJvYcCWMgqdm20z+EBIx1vcwbW2piVd83Ec3UV2y1pdU7lZxJiAXa1Zpo4WIXyf3PvLfo+tFHiQGMbqJNZCFZ2w=@vger.kernel.org X-Gm-Message-State: AOJu0YzqipEpG0pBI6S5QRkaOjyaW6cr9xWMnSMhpOSpkR7gkVP0RTYk xfV+6Nht8pLkdNfd8aU+c3/Ldg7hR32//6PJ4vMN1UZnB0sjdQTdE8rMqkcPQxDdUG4= X-Gm-Gg: AZuq6aLHIYp8/FdybvCgxRTAaKPTezFfCA3dFPakQao1v6eBxH9Q6H7IEru8zUziwbq 7JZX1EL4JVGzXZDzRgAk77K/BVzEo8INzB9BRkj3YN9L+3GEkyXlXnHacJcrLnN4x8Lnu94x6Oy YEr7kmWVHU3O0ih8rKLd5ftY+tQys7L+09JrI2FtoxPT/1wgzxT97P+I8qdMj8bcokKp9QkVW0g bcos8hh5epTVHxwirFH1NlpHv0l57Fus7Bb0cupSU6xCD3PZM4b5GzfY5bHbez5YWas3xLtnBGk GgCKLnXUXd6gB3O7OMjLvaqe3OZrwY4kdVpOPmlpS6oUlhD6o2fNGrfK4qoRVSJpyL2pmnaSoUE KgX7CuNvUOhjIKS6yNlz/CSCHx2vcsd8/zvXDfyxIVS94/OCStgFThMLuAA6JSxK6A8gBHWl58c hV3/OT7PF9AO5c4Y3nVg+KAVp6ONiZ7G9Hthoe6II8/YC+kmOWBxlXly3ObswiT12zgiw= X-Received: by 2002:a05:6214:3004:b0:894:81db:af6d with SMTP id 6a1803df08f44-8953cb7e05dmr42467716d6.56.1770389575237; Fri, 06 Feb 2026 06:52:55 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50639e26b9fsm17413971cf.15.2026.02.06.06.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 06:52:54 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1voNCY-00000008V9M-0Hb9; Fri, 06 Feb 2026 10:52:54 -0400 Date: Fri, 6 Feb 2026 10:52:54 -0400 From: Jason Gunthorpe To: Bjorn Helgaas Cc: Manivannan Sadhasivam , Manivannan Sadhasivam , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Naresh Kamboju , Pavankumar Kondeti , Xingang Wang , Marek Szyprowski , Robin Murphy , Alex Williamson , James Puthukattukaran Subject: Re: [PATCH v3 3/4] PCI: Disable ACS SV capability for the broken IDT switches Message-ID: <20260206145254.GK943673@ziepe.ca> References: <20260206143014.GH943673@ziepe.ca> <20260206144651.GA57945@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260206144651.GA57945@bhelgaas> On Fri, Feb 06, 2026 at 08:46:51AM -0600, Bjorn Helgaas wrote: > IIUC the current situation is that for these IDT switches, ACS SV is > enabled when downstream devices are passed through to guests, but > after these patches, it will no longer be enabled. ACS SV is enabled at boot time if an IOMMU driver is present regardless if guests or virtualization is in use. Linux doesn't change ACS flags dynamically. > So my question is whether users are giving up some isolation. If so, > should we even allow devices to be passed through to guests? If we do > allow that, do users have any indication that they're not getting what > they expect? iommu_groups will correctly describe the system limitations with the ACS quirk path and so all of the above concerns are taken care of. Robin is saying the Juno SMMU forces a large iommu_group covering the switch anyhow today, so at least that platform is not affected. Jason