From: Greg KH <gregkh@linuxfoundation.org>
To: Nikolay Kulikov <nikolayof23@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rename camelCase variables
Date: Sat, 7 Feb 2026 14:43:16 +0100 [thread overview]
Message-ID: <2026020733-blatancy-periscope-e425@gregkh> (raw)
In-Reply-To: <20260206123013.15533-2-nikolayof23@gmail.com>
On Fri, Feb 06, 2026 at 03:25:53PM +0300, Nikolay Kulikov wrote:
> Rename "pHT_caps_ie" to "pht_caps_ie" and "pHT_info_ie" to "pht_info_ie"
> local variables to comply with Linux coding style.
Why did you pick these names? You kept the "p" prefix for some reason,
which is "Hungarian" notation, and is not a kernel coding style, so
shouldn't you just use a name that reflects what this variable is doing,
and not encode the type in it?
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-07 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 12:25 [PATCH] staging: rtl8723bs: rename camelCase variables Nikolay Kulikov
2026-02-07 13:43 ` Greg KH [this message]
2026-02-15 8:04 ` Nikolay Kulikov
2026-02-16 7:28 ` [PATCH v2] staging: rtl8723bs: rename camelCase variable Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020733-blatancy-periscope-e425@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox