From: Steven Rostedt <rostedt@goodmis.org>
To: Donglin Peng <dolinux.peng@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Donglin Peng <pengdonglin@xiaomi.com>,
linux-trace-kernel <linux-trace-kernel@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Eduard Zingerman <eddyz87@gmail.com>
Subject: Re: [PATCH 2/2] tracing: resolve enum names for function arguments via BTF
Date: Sun, 8 Feb 2026 10:27:42 -0500 [thread overview]
Message-ID: <20260208102742.2169de7a@robin> (raw)
In-Reply-To: <CAErzpmsajhJ45TkPx_TPwAPwN1fxO0cNYFTKFgLaosiPMo9wew@mail.gmail.com>
On Sun, 8 Feb 2026 21:07:37 +0800
Donglin Peng <dolinux.peng@gmail.com> wrote:
> Hi Steve,
>
> I noticed that trace-cmd 3.4 introduced a new feature:
>
> - Add support for showing parent functions in function graph
>
> If the "funcgraph-retaddr" option is set during function graph tracing,
> the parent functions will now be displayed:
>
> preempt_count_add(val=65536); /* <-irq_enter_rcu */ (ret=0x10001)
>
> However, it currently only prints the caller's entry point. I suggest
> enhancing this to include the **offset within the caller** as well. This
> would allow tools like `faddr2line` to locate the exact call site accurately.
Yeah, it makes sense to always show the offset of where it was called.
We can add that for 3.4.1.
>
> I implemented a tool named FuncGraph[1] to convert function_graph
> ftrace output into an interactive HTML file. It leverages fastfaddr2line
> to map return addresses (e.g., __sys_bpf+0x51/0x500) to their
> corresponding call sites, such as: __sys_bpfat kernel/bpf/syscall.c:6115.
>
> What do you think?
Sounds cool. Is this the vibe coding thing you talked about on Linked-In?
-- Steve
>
> Thanks,
> Donglin
>
> [1] https://github.com/pengdonglin137/FuncGraph
>
> >
> > -- Steve
> >
> >
> >
> > [1] https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tag/?h=trace-cmd-v3.4
next prev parent reply other threads:[~2026-02-08 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 11:15 [PATCH 0/2] tracing: resolve enum names for function arguments via BTF Donglin Peng
2026-02-02 11:15 ` [PATCH 1/2] btf: Add for_each_enum and for_each_enum64 helper macros Donglin Peng
2026-02-06 0:29 ` Masami Hiramatsu
2026-02-02 11:15 ` [PATCH 2/2] tracing: resolve enum names for function arguments via BTF Donglin Peng
2026-02-02 16:12 ` Steven Rostedt
2026-02-03 2:17 ` Donglin Peng
2026-02-03 13:50 ` Donglin Peng
2026-02-03 15:17 ` Steven Rostedt
2026-02-03 16:00 ` Alexei Starovoitov
2026-02-04 14:52 ` Donglin Peng
2026-02-05 9:21 ` Donglin Peng
2026-02-05 15:56 ` Alexei Starovoitov
2026-02-06 4:09 ` Donglin Peng
2026-02-06 16:04 ` Alexei Starovoitov
2026-02-08 13:08 ` Donglin Peng
2026-02-05 18:04 ` Steven Rostedt
2026-02-06 4:04 ` Donglin Peng
2026-02-08 13:07 ` Donglin Peng
2026-02-08 15:27 ` Steven Rostedt [this message]
2026-02-08 15:42 ` Donglin Peng
2026-02-08 16:47 ` Steven Rostedt
2026-02-04 14:16 ` Donglin Peng
2026-02-06 0:12 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260208102742.2169de7a@robin \
--to=rostedt@goodmis.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=eddyz87@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pengdonglin@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox