From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 404DF2701C4 for ; Sun, 8 Feb 2026 11:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770550441; cv=none; b=ahDePrS9x8Y7J6tIXdfNiZWGmWRSkVnilQJlLQxUav0uDMzvUhHi01fm3UjckqTHc8tLsnALeG/kzGzdiT8I9qp0Fta0RYdiOIy5USNc6/CCzvyFm35HQhWDZRHwhqJR+foa5GXd0Ahm/HCMDKLJNB8Pc3u81iPcng7ACFw/IQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770550441; c=relaxed/simple; bh=TXt7msKdyKU4ElYfsCcGfoDF8EptlbYD/39oUw8WyIU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zz5aSvsCsNlJifjwOjdCgxCXYsg/KWJc5EHJx4MPpN6fkGQFG2fnL3X1H7s5ucI/gABH1pU0gqLzL1xTvKJxdRJ5G+Kfi5c1F0R5xvDWeuxICEWVF1/hBx5B2Tu/sAi+e1IH2HDLrxh4K56pi80pDwJI5TTV3+FAsaohtTvpMJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QnsFEc6e; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QnsFEc6e" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4801eb2c0a5so33234115e9.3 for ; Sun, 08 Feb 2026 03:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770550439; x=1771155239; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=af8mUMYZ/JmD0MTutAA8ObrxGCRmddURs+0BPYHjdOk=; b=QnsFEc6eJNqSMxDSpjuwvGX0DBTDjaRp49R9Aay3Fur9ZmrI3lgR0Jkbh9z3atjHMM A63UNLcqGPztqJnyoadS7KQWyK+qKAyTpteFYcXDVd0wfMGiWISsJnG1vOzciACf/JgO 2XlQ1jY+iTGWS7bAdBxOkL/BKsDHCwb5F1YdouFBBIFioZGaJ+ZqJ5NEV0x/qgK2OGuo Q9cXMceeVbVUqOy30QeJASUf4UL02cHcHSGisSGIwNlnjW+xM1Hgd/DzhVEsVRwg3IJq Kvy/tht2WTeGpEmIOSoYqYV3mJrC5kIKE7Ishy5nKaU1YFnHWRyve0bKS485NjBzheXk S11Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770550439; x=1771155239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=af8mUMYZ/JmD0MTutAA8ObrxGCRmddURs+0BPYHjdOk=; b=az9HJzp5ZILIKVoHrp2poVT1y36V8gc1oqDUEGcVUHEfBrvY0dF5tj0rsVdyD39DZt 7vTkDjT3eXvnO7ULRyP0dPz/zmn23lnCZkn2VULgiQ2S7Ne8Xzr5LXFM7WjQRnh12032 c4uifUW8XFm/jVa2AGjqATEvpi2SIaBUsL6uFk5jHx2pbGy3H8z8tLOb68lzn7gwkzhp bBgV2lrXS5x2BP0DhTv+el7ulF2Y+VJFviLRR2rQ5z7GNZ/rrI94Hv8i2yEjNb+1gqjh FX8k6l+MxQHHrF6+Z1xntP1wmwR8qw14pherPfocOiQkQEPs2k+McCeTE+qvZUI5vaWt 0rSw== X-Forwarded-Encrypted: i=1; AJvYcCUvXLRG11Y3kJZceBOtjE9vrKdYkgomYEbpKnr2iuDzR+rBsNewVIsBO7uLCHqBgzsNYxJlC5FyF2DrU/g=@vger.kernel.org X-Gm-Message-State: AOJu0YxBW2Vt/E+C48rH9ogAH3J2FbMbKywuxdl7oDCwj4mAu+anBqPk c8MBQHDvgZuBVu807dkQcjMl3XIJDXViAcN2ZWGCr9nIjx1W5IbQAUXX X-Gm-Gg: AZuq6aIXeFJfT6LnSzEHRoIu2szpQKvkMx8SggUrDbz4Q3DtTe8diMqJ/T2VvXMZpDq tzbPUR7egbgA1SNTu7WUDArzU5nHNRJlja+p9vQOvJ0nk1VD5nykK8WSxxypnIlDpHk1qa28G1d 2mcKnfoks/LGgDIssmmD3itDfWwy52QsfYxyNZT73YHGLVWMEasr6Y5Dnzjkw3hJhHEHxgWVMiN 9/QMHAOj/C99XR7D7Njulr4Ejc69koYa6PjbY8d98VCuKribu8u6zSxJqRaC3xpTLcJJJN9rfnu PGIVVHEjqXBJQq7/qVO1QQn1PFlmx8YYXS1vOwZ+TcwXhTbmXWLu22R1KReQq7jrGSZB0aRxAiH djQH5Bmst4LSAwx4Cl1kIInKEm4/hO4RIfhBKipSLThZL4oGKdooMbn3PChcT1FusFM0AMxvCkC CpDH4el7db2KLRf+GJLhkjtvjKjiD2dQ4eqKEriB0P5yIovsSGmqVb X-Received: by 2002:a05:600c:848d:b0:477:9ce2:a0d8 with SMTP id 5b1f17b1804b1-48320181b22mr111950965e9.0.1770550439538; Sun, 08 Feb 2026 03:33:59 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d7a924sm378805275e9.10.2026.02.08.03.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Feb 2026 03:33:59 -0800 (PST) Date: Sun, 8 Feb 2026 11:33:57 +0000 From: David Laight To: Andrew Morton Cc: Peter Anvin , Andy Shevchenko , Arnd Bergmann , Christoph Hellwig , "Jason A . Donenfeld" , Herve Codina , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH next] minmax.h: Use auto for variables in __minmax_array() Message-ID: <20260208113357.62e769b8@pumpkin> In-Reply-To: <20260207182559.2223b2ab166877e80714449f@linux-foundation.org> References: <20260206222554.676171-1-david.laight.linux@gmail.com> <20260206144135.89b1edb4f25fed21b7a1ccc9@linux-foundation.org> <20260207102551.74a42680@pumpkin> <20260207182559.2223b2ab166877e80714449f@linux-foundation.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 7 Feb 2026 18:25:59 -0800 Andrew Morton wrote: > On Sat, 7 Feb 2026 10:25:51 +0000 David Laight wrote: > > > On Fri, 6 Feb 2026 14:41:35 -0800 > > Andrew Morton wrote: > > > > > On Fri, 6 Feb 2026 22:25:54 +0000 david.laight.linux@gmail.com wrote: > > > > > > > From: David Laight > > > > > > > > While 'auto __element = _array[--__len]' should remove 'const', > > > > gcc prior to version 11 are buggy and retain it. > > > > > > With what effect? > > > > If you have: > > int f(const int x) > > { > > auto y = x; > > y++; > > return y; > > } > > gcc prior to 11.0 error that y is const. > > So in this case the loop can't change __element. > > Still not undersanding, sorry. Does this patch fix a build issue with > any compiler/kernel combination? > > > > I'm not understanding the motivation for this change. Is there some > > > compilation issue to be addressed? > > > > Mainly unqual_scalar_typeof() being horrid. > > There is an ongoing long thread about its use in the arm64 LTO READ_ONCE(). > > Newer compilers do have a builtin, and there are some shorter alternatives > > that work in some places. > > But here is just isn't needed. > > So one less place to check. > > OK, so it's a cleanup. > > > I did mean to copy the main contributers to that thread, but forgot. > > I think a v2 would be good please, to clarify the effects of and > motivation for the change. Ok - I always expect to do a v2, the way of the world. David