From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Miguel Angel De la Vega Rodriguez <miguevrgo@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range
Date: Sun, 8 Feb 2026 15:35:43 +0100 [thread overview]
Message-ID: <2026020813-eleven-thee-a5e5@gregkh> (raw)
In-Reply-To: <20260208121500.164404-1-miguevrgo@gmail.com>
On Sun, Feb 08, 2026 at 01:15:00PM +0100, Miguel Angel De la Vega Rodriguez wrote:
> checkpatch.pl warns that msleep < 20ms can sleep for up to 20ms.
>
> This patch replaces msleep(10) with usleep_range(10000, 11000) to
> improve timer precision and allow the scheduler to coalesce interrupts.
>
> Signed-off-by: Miguel Angel De la Vega Rodriguez <miguevrgo@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index b2e7f479f72b..3f5b3ca2066d 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -214,7 +214,7 @@ void _rtw_free_evt_priv(struct evt_priv *pevtpriv)
> {
> _cancel_workitem_sync(&pevtpriv->c2h_wk);
> while (pevtpriv->c2h_wk_alive)
> - msleep(10);
> + usleep_range(10000, 11000);
>
> while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
> void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
> --
> 2.53.0
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You sent a patch that has been sent multiple times in the past, and is
identical to ones that have been rejected. Please always look at the
mailing list traffic to determine if you are duplicating other
people's work.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2026-02-08 14:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 12:15 [PATCH] staging: rtl8723bs: replace msleep with usleep_range Miguel Angel De la Vega Rodriguez
2026-02-08 14:35 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 19:54 [PATCH] staging: rtl8723bs: Replace " AyushMukkanwar
2026-03-19 20:23 ` Ethan Tidmore
2026-03-20 7:42 ` Andy Shevchenko
2026-03-14 5:11 [PATCH] staging: rtl8723bs: replace " Marcos Andrade
2026-03-14 20:56 ` Ethan Tidmore
2026-03-09 0:40 sluisr
2026-03-09 13:33 ` Bryant Boatright
2026-03-09 16:01 ` Greg KH
2026-02-14 17:31 Ofek Almog
2026-02-14 18:11 ` Ethan Tidmore
2026-02-14 18:24 ` Andy Shevchenko
2026-02-14 19:23 ` Ofek Almog
2026-02-15 6:52 ` Greg KH
2026-02-10 5:58 Vo Thanh Cong
2026-02-10 6:37 ` Greg Kroah-Hartman
2026-02-09 12:07 Ethan Lam
2026-02-09 12:35 ` Greg KH
2026-01-10 20:44 Işıkhan IŞIK
2026-01-11 12:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020813-eleven-thee-a5e5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=miguevrgo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox