From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CDA53BB44 for ; Sun, 8 Feb 2026 18:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770576083; cv=none; b=tR/jMhoEu9vElLw+EMPIspxbEU0Hmb0B8ZrTFn9iJF0hs9Vednmvu+5BCK8/EcNqfnh27PvaKyam5jaHV+dQGxF/NwtvUnJL5G8jrbkOAFOJM4WjV0r67CxCL0VWMAqtCEMl9MfbEaA9ogxNpzQ1lJknPxa3Blcl+aYVFOw6LQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770576083; c=relaxed/simple; bh=GdzGETrLU2IBeU/SwNS8qz9gSxTDBHT+Dqe4hEEgv2w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MdHSCnn/l6aS6XeyoEhGr0RUoAukfOD4Kq0DiMMGAmY9JHU5Q10CBHi5q72HC/hnlvxfHJqu0nzy0sGSfPsFO3scauKrUi7fhixz5K+2Yt4uMWE6QHQKZtCOfLENW5BPeybbzjIOIj/dcD1cE6CfsJRW1i+Adg8QRgMcoKqJx+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PoNCqr8N; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PoNCqr8N" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8c6d76b9145so405590385a.2 for ; Sun, 08 Feb 2026 10:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770576082; x=1771180882; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+vLocduT9sxG83OV4YuouV9GtkKzk4tUb38vRroJayM=; b=PoNCqr8Nc7nE8jvjhoMDIoJHaze7a7YWBvG+Vz6m22ma5SQ4YihWvuw1dESimwLoat i5/QfyJY/QQlL6DbBrAdQNKvpvWCmzvOB5k6+Xhi5YjOuBmqe0QV5mXUKxAUFVe25a6t 6rFOOBdWkwNVc0YpM70vh1Fg8zwtaVgQ0BEI2dViIZQxS60KuaRDc0q6rTEPtIT+ZoJx 8FHH648YwBJIXt9uDZ2l7hZJA2c6k0YUmMAjY9rpuGa3re3F2uFW2ldYF661PC+I3bko Ju9Fbmw39ddErbB71Hjjg5+9+B2sPBzewdBkbRsRkFnS4HwTVDTt+XER2HmfwhrvWGp2 6LIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770576082; x=1771180882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+vLocduT9sxG83OV4YuouV9GtkKzk4tUb38vRroJayM=; b=NDBg6kSwZY50LLVO63rl89y98jUseZhnS45KwOtLq8rrB0hqOe8wSugR8toTE0mR/k TYfb5m3uiQezjG6Z2Wtvt0TbE2nvxxZiW/HayaWS30MEZzTwDwebI4p99A0iwr4ggvJO d9tyOWZgUzDoF276xQprHlwm0Bk4NYfEZ/GkaFDYmwl1+/S2zTVm5q7Z+2dKNv1CpEpX 1eGi8t+wc4eAQmp0PhXQVOfc4WLDTp4Ko/wcUADoEvQfWBeAE2qGYxegBiIbWH/6h7Pm Tji7t/PIIJ17tqWmzCUaY7q5qKjfEX0UXEpdYOrkDj9BloMaYiVjydxQmNN1y9OLxfi+ 0oow== X-Forwarded-Encrypted: i=1; AJvYcCXcMM6/rcGqaYEtedHki8K1n6v2dyM66yQjs91GEM4mOeqkXhWOk9+7d7HY9EGdLWe0FJxSnXTDyf3L4do=@vger.kernel.org X-Gm-Message-State: AOJu0YyL2+0+pM3Bg2YTbYs1MIOlIQfdzptdpNWtGYDnfHaigB9bpMT4 1vA4hQ7mWtdnbE0OZ9HhDUmo+XXoDr4VIdOWYtJQ6t/jRlArcRISs2wQ X-Gm-Gg: AZuq6aKfJMUo0ekgbcCG8nVUu9VCXyTkIf4Jc8A3lllP7mHQYZUbLa8TnnHZ18c6UFD qymG/bt63lMeAzP2m8LIocSlkHBw4H4cLhXR8mJTYi2XN3hId4XlQEF3+XbaCTMUbKzD7cEMfGi 9JqLujeyy0DUGIsYqMF7u1S4y4Rk9iCz0PXB8A0fM0/iOEy18u9an//Wt98wpLNx0b5CgSWJ3NT 4Hmf+j1INb6orZSrgo9B6+Gz+oBT80R8+w7scKJYcnTmqClFRIuS9xhrq9ymheeQVyIS/IigLhw 2q1sNMdLl3uAeJ8X0RHgcazGtK332f1U1Plx6uMrekSgBAj3rTpGnR78Pu9+UyG/qaKghEes3ZD BKRhfMOWcHNpmwHp3qqhYXk1KB4W9OaRsT7t+6pmTD0e3nwA32XYct9dbmfGyi1TdAmlnkYQmdc a3yT4F/MAlWD/x0NN89iYsUnsCtgt0fg== X-Received: by 2002:a05:620a:458c:b0:8c6:d2ca:1d0e with SMTP id af79cd13be357-8caeef2f8c0mr1318700185a.11.1770576081874; Sun, 08 Feb 2026 10:41:21 -0800 (PST) Received: from localhost.localdomain ([50.21.71.60]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-896f9eda5c8sm15057556d6.12.2026.02.08.10.41.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 08 Feb 2026 10:41:21 -0800 (PST) From: Neel Bullywon To: joe@perches.com Cc: apw@canonical.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, andriy.shevchenko@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] checkpatch: suggest fsleep() for short msleep() calls Date: Sun, 8 Feb 2026 13:41:19 -0500 Message-ID: <20260208184119.74729-1-neelb2403@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <67577c238ead009b3b061a43d443dc69da2aee64.camel@perches.com> References: <67577c238ead009b3b061a43d443dc69da2aee64.camel@perches.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Sun, 2026-02-08 at 08:36 -0800, Joe Perches wrote: > maybe change msleep to a #define macro so if the argument is > constant call fsleep instead Thanks for the suggestion, I'd like to implement this for a v2 but want to clarify a few things. 1. fsleep() is static inline and calls msleep() on line 134 of delay.h. Since inline functions are expanded at the call site, the msleep() macro would expand inside fsleep() at every call site even if the macro is defined after fsleep(). I'd need to change that call to (msleep)() to suppress expansion. Same for ssleep() on line 103. Does that sound right? 2. Should this be a single patch or a small series of patches?