From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B736825DB12 for ; Mon, 9 Feb 2026 07:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770623451; cv=none; b=RpTS5bkNCTczDU1Y0F+Ect6E3sDSVaiLImMSOVQzbaaapcrzTCwvLnAMCGd+0I4liNatJeXofyae1kG2IBfoTDVITkfr/p/qHJgjAFK+qLaDJHwvjKj6C0ZwypPcanAsHldO8eB7Y0Gj74IMdXcFQzARTJLPiVHor2488BGEv6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770623451; c=relaxed/simple; bh=BSv9tRDpQOksao+1Q7yqai9E5ovtmNkBfPo/NJ4HzL4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fTDUlwJ2eE88R530FJ8lJjVYbgiJv8dZHEcoeujd7lhtt0fncfSs+RxxuQNAJt+Tb7RY4NSu52I79x7r1w9GGuh5hJxlj8jH401vWea4Sb/yfBjNr6nyz1F7QKOpPXeAHmQDmHZudKXp96Vr8pf7nS01Cje+1B2W/jd730Z9iiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=2PrvtuiD; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="2PrvtuiD" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 251044E42497 for ; Mon, 9 Feb 2026 07:50:43 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E43686074B; Mon, 9 Feb 2026 07:50:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 36883119D14CA; Mon, 9 Feb 2026 08:50:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770623442; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=8i56GTaGC/9+4V5YZ5iJPhAgIdFBtU7C0Akhyek3/LY=; b=2PrvtuiDY6gwTtoHPX1LiFaakxuI+sc52SUFwWRWHLSbLs1lFfcIXKcjtFyt92kfYmDe1H N/NFH/orRCnrW2cbOy1t4qx+hrAoRV88T3XYIrlfiWc4qj34Ib9NxWNHSKv3CN4Qle8BT/ XeO1CYtdVM7PItm4Pg1OQuTe9Q5I4cQtyM+JPPY0sQafefaoVf/sW3QPF1J4SRzhtwCqv+ SEgk5KZl93jdSPvWu7VqAJ31XX5d8l3gEwU792jRZaNgfdpmt3zIrDvF6Qbdc4hobV/LnJ VjV5cfcrJJ/+xfdkYDBRjGS5N27mT+iua0aUGJ9CqPaqiF2wKO8YIEv3TM8b4Q== Date: Mon, 9 Feb 2026 08:50:35 +0100 From: Herve Codina To: Chen Ni Cc: qiang.zhao@nxp.com, chleroy@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resources() Message-ID: <20260209085035.1d7db80a@bootlin.com> In-Reply-To: <20260209015904.871269-1-nichen@iscas.ac.cn> References: <20260209015904.871269-1-nichen@iscas.ac.cn> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Chen, On Mon, 9 Feb 2026 09:59:04 +0800 Chen Ni wrote: > Fix wrong variable used for error checking after devm_ioremap_resource() > call. The function checks qmc->scc_pram instead of qmc->dpram, which > could lead to incorrect error handling. > > Fixes: eb680d563089 ("soc: fsl: cpm1: qmc: Add support for QUICC Engine (QE) implementation") > Signed-off-by: Chen Ni > --- > drivers/soc/fsl/qe/qmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c > index c4587b32a59b..672adff8e35f 100644 > --- a/drivers/soc/fsl/qe/qmc.c > +++ b/drivers/soc/fsl/qe/qmc.c > @@ -1790,8 +1790,8 @@ static int qmc_qe_init_resources(struct qmc *qmc, struct platform_device *pdev) > return -EINVAL; > qmc->dpram_offset = res->start - qe_muram_dma(qe_muram_addr(0)); > qmc->dpram = devm_ioremap_resource(qmc->dev, res); > - if (IS_ERR(qmc->scc_pram)) > - return PTR_ERR(qmc->scc_pram); > + if (IS_ERR(qmc->dpram)) > + return PTR_ERR(qmc->dpram); > > return 0; > } Yes, indeed. Thanks for the fix. Acked-by: Herve Codina Best regards, Hervé