From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4142136F41B for ; Mon, 9 Feb 2026 11:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770636763; cv=none; b=kkG+zaOg+gjxkNG0xmGCF6a074xcjVhou8XSFGcKQzSKabqzcu66Xz5Z/JWnl96K4wSt0k6bHKS6LHEDeYVTM6tkVsKEusjEe73jXKqnEd/C/s/j5RAapLdkbl71CQcUJfdTyXDsZRquqHLkfMk3p5cD/Uor/IVssfAKlIqtSW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770636763; c=relaxed/simple; bh=66u1NkdMmjJnCO/QczK9JIyQQfycPkVqrwJGdeOcxfY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WYMRkRl0v6LRyNdb+JYryHxysI5B36gATJVzSoyLtrMT7bzCfAWqaG7E+J++k91Af9XTdw5aWS181SLaaYfmcVCp+tgFpznqBM74MY1YXXX7rm+XUzus7snnkkU4oNpbOvWWFAbElfKQZPWLGkyyDny+sw1j0f7fSQg7WBFRGgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hhA5xmi/; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hhA5xmi/" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-649e97f1e99so3725424d50.2 for ; Mon, 09 Feb 2026 03:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770636762; x=1771241562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yBBkEVXPXRQmgJvQuwj/kXUQfzs5IaXOQOuoI6wX6LM=; b=hhA5xmi/vMM1hOjGTBLqBIvGQqg97tjP7xi4wXNURRsu9/RfkHLgMtqE8h9J0FjTKT hqQJ1fF+Uh9yZystVpZEXv+eAsWz9P5JaU+LukF1OZX9RMsX47i4hcKqrmtY1b+uHddP YxEU62duioPtSkUEMNzrhjnJpTWUqokc4GEqZb+rYpmnyIKOjb9q1oA06+3o5FjMV7nU ikJf13/CdYAP43aLS009zVngKa10D9+pWwX+QvSCJ/bm/fmv38RsSDkSc56J2Sxke3uo 7lXiDIy3d73yrx3Dcp0dYATmy6GanChgBUzhy4Q85zlXwC1Od38HmK/TeeK41l4BEzzQ jCbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770636762; x=1771241562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yBBkEVXPXRQmgJvQuwj/kXUQfzs5IaXOQOuoI6wX6LM=; b=UgZAOedRgI96mjfE33m/bD8k7GtShyIoCnsVxX5gLkpZ0qwscb+Ob+J/mHdnCP9Lcc UFXRGK9P9uK6Ptx9Tli0XLagZIzGULQZuFSiKKDNegALB4kYhGh9a/9W4E62J55ms/fL Z9GqvO3anN5CPKaYtd/ZnrYIPmMm9ghqsh0GjjkpsuBEsCLsIVYQ9Lb0vv+YY/k13tEN QzJoyp4Qg4mNj1gMkwjH2sI+Q3iTAHlKe5R1y6WAKMBdTcCp8M1nim6GMsYFiyc1Nw/u Y2Ro1LAs+q1ioQ+nvah2Ss9B0Yyd4Ij5yLAwnR2wEbZ2C9RTu2H7BdFHCLDZPFLBwKbW 9x8g== X-Forwarded-Encrypted: i=1; AJvYcCXtING5inKnK15X0g2/UbZ2k4TZ8Na5jl+GSjOGqch+lKKxElU0kiGsi58fXmLrmepNI1xItJy1kBom0Fc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5U0Eny9onRtKnL9jzIQutTBIhdK7b3QjXbDNgoRNZY/BV/T3c RaZVJzrZyuwAj5o1YN77LEJnvRpKEqoJms9yfVqkRmZxOumtngQcuaUq X-Gm-Gg: AZuq6aIFQvwVZnHLxTq2JM3EIw2QAFhSWi/7dkWgDDyWQPMCnFMSNQMDa1YQfRDb2Hh CJnNCH1XxUt+UDwmkrK3GAPKOqd+L05yfWWQQiZJapbN8C1Zl28Bt60uPgurhL4cEH3Mn7lVxJE u9Tkc2aR0PFdKIJ6wdGwkDCC4nL/yqNCWRP0yEL/12JfwlcikeP2vCJKRw2fUbl2rSjxuRojI+3 hDEeEbQDLlowJfT7BLZNWqOQczGk2upPyj2c6ixUQ2GPCAttFRwAv9th94oZr2f9A/p9+OoTTLb 2gt/TspzIF5b6hRb/itymzPQFqHGQax1Prsz4vt3CXOCmfyzhhwDko+Kya/pjdhzm9C2qEPiB2n VBHFFIHzuZu2ppQGqxHiN2sULdqkK2HUH88qCz2HOe9DX0fULQIibKMQv0gVOcth13PD99VsVzk B2EGigFo6SWzimgC3k8B5VNuLK6XcwU6zvhiMnZxcUjxmSn8AxNTFwwUBQBcZo3InO X-Received: by 2002:a05:690e:c45:b0:649:4640:f8ee with SMTP id 956f58d0204a3-64a0b8e0724mr8825983d50.6.1770636762237; Mon, 09 Feb 2026 03:32:42 -0800 (PST) Received: from gustavo-arch ([2804:14c:f25a:845f:5b8d:2e7c:d238:2d28]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64acd247ee5sm8765595d50.6.2026.02.09.03.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 03:32:41 -0800 (PST) From: Gustavo Piaz da Silva To: gregkh@linuxfoundation.org, dan.carpenter@linaro.org Cc: ovidiu.panait.oss@gmail.com, gshahrouzi@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gustavo Piaz da Silva Subject: [PATCH v8 2/2] staging: axis-fifo: refactor device tree parsing Date: Mon, 9 Feb 2026 08:32:29 -0300 Message-ID: <20260209113229.7871-3-gustavopiazdasilva2102@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260209113229.7871-1-gustavopiazdasilva2102@gmail.com> References: <20260209113229.7871-1-gustavopiazdasilva2102@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor the device tree parsing logic in axis_fifo_probe() to reduce verbosity and simplify error handling. Remove the verbose error logging and goto logic. Instead, check of_property_read_u32() return values directly and propagate error codes immediately. This aligns the driver with modern kernel standards by removing unnecessary error messages during probe. Signed-off-by: Gustavo Piaz da Silva --- Changes in v8: - Reverted line wrapping changes to keep the diff focused strictly on logic refactoring and avoid unrelated whitespace noise. Changes in v7: - Reverted variable name and type from 'u32 width' back to the original 'unsigned int value' to minimize unnecessary diff noise. - Removed extra blank lines between function calls and error checks to keep the diff as compact as possible. Changes in v6: - Removed the axis_fifo_get_u32() helper function entirely. - Removed all dev_err() calls in axis_fifo_parse_dt() as the driver core already reports probe failures. - Kept the 'node' local variable to avoid checkpatch line length warnings. - Fixed checkpatch style warning (missing blank line after declarations). - Ensured a newline exists at the end of the file. Changes in v5: - Added missing newline at the end of axis-fifo.c. Changes in v4: - Removed extra blank lines in the commit message. - Added "rx" and "tx" prefixes to error messages (these messages were later removed in v6). Changes in v3: - Split the original monolithic v2 patch into two separate patches to isolate logic refactoring from type alignment. Changes in v2: - Fixed checkpatch.pl coding style issues regarding indents and line formatting. Changes in v1: - Initial submission. drivers/staging/axis-fifo/axis-fifo.c | 55 +++++++++------------------ 1 file changed, 17 insertions(+), 38 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index 7bc7bf191250..1f933ef87b60 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -490,60 +490,39 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width", &value); - if (ret) { - dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n"); - goto end; - } else if (value != 32) { - dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n"); - ret = -EIO; - goto end; - } + if (ret) + return ret; + if (value != 32) + return -EINVAL; ret = of_property_read_u32(node, "xlnx,axi-str-txd-tdata-width", &value); - if (ret) { - dev_err(fifo->dt_device, "missing xlnx,axi-str-txd-tdata-width property\n"); - goto end; - } else if (value != 32) { - dev_err(fifo->dt_device, "xlnx,axi-str-txd-tdata-width only supports 32 bits\n"); - ret = -EIO; - goto end; - } + if (ret) + return ret; + if (value != 32) + return -EINVAL; ret = of_property_read_u32(node, "xlnx,rx-fifo-depth", &fifo->rx_fifo_depth); - if (ret) { - dev_err(fifo->dt_device, "missing xlnx,rx-fifo-depth property\n"); - ret = -EIO; - goto end; - } + if (ret) + return ret; ret = of_property_read_u32(node, "xlnx,tx-fifo-depth", &fifo->tx_fifo_depth); - if (ret) { - dev_err(fifo->dt_device, "missing xlnx,tx-fifo-depth property\n"); - ret = -EIO; - goto end; - } + if (ret) + return ret; ret = of_property_read_u32(node, "xlnx,use-rx-data", &fifo->has_rx_fifo); - if (ret) { - dev_err(fifo->dt_device, "missing xlnx,use-rx-data property\n"); - ret = -EIO; - goto end; - } + if (ret) + return ret; ret = of_property_read_u32(node, "xlnx,use-tx-data", &fifo->has_tx_fifo); - if (ret) { - dev_err(fifo->dt_device, "missing xlnx,use-tx-data property\n"); - ret = -EIO; - goto end; - } + if (ret) + return ret; -end: - return ret; + return 0; } static int axis_fifo_probe(struct platform_device *pdev) -- 2.52.0