From: Greg KH <gregkh@linuxfoundation.org>
To: Azamat Rakhim <azamatrakhim8@gmail.com>
Cc: karanja99erick@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: simplify boolean test in rtw_btcoex_MediaStatusNotify
Date: Mon, 9 Feb 2026 07:49:38 +0100 [thread overview]
Message-ID: <2026020926-stegosaur-single-9cc3@gregkh> (raw)
In-Reply-To: <20260208175120.15717-1-azamatrakhim8@gmail.com>
On Sun, Feb 08, 2026 at 10:51:19PM +0500, Azamat Rakhim wrote:
> Remove unnecessary comparison to true and move logical operator
> to the end of the previous line.
>
> Signed-off-by: Azamat Rakhim <azamatrakhim8@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index f4b19ef7b341..444a602d2868 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -10,8 +10,8 @@
>
> void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
> {
> - if ((media_status == RT_MEDIA_CONNECT)
> - && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
> + if ((media_status == RT_MEDIA_CONNECT) &&
> + check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE)) {
> rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
> }
>
> --
> 2.52.0
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
prev parent reply other threads:[~2026-02-09 6:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 17:51 [PATCH v2 1/2] staging: rtl8723bs: simplify boolean test in rtw_btcoex_MediaStatusNotify Azamat Rakhim
2026-02-08 17:51 ` [PATCH v2 2/2] staging: rtl8723bs: remove extra blank lines in rtw_btcoex.c Azamat Rakhim
2026-02-08 21:22 ` Ethan Tidmore
2026-02-08 21:21 ` [PATCH v2 1/2] staging: rtl8723bs: simplify boolean test in rtw_btcoex_MediaStatusNotify Ethan Tidmore
2026-02-09 6:49 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020926-stegosaur-single-9cc3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=azamatrakhim8@gmail.com \
--cc=karanja99erick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox