From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C94352FA1 for ; Tue, 10 Feb 2026 10:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718798; cv=none; b=Gh0/NOx4QRry6WbiJgjGG8b73fp0hNHrorpE00utmRHZi+kTg0f89rpacazWntVVwSyYmXNQcKm7krO+PhLhSOW9PIsLnBGPBSYcTfNkAWsgzikomdk4a70BrdrWDi/skZAUDIAmMMFLWY8Et+AccuvRuVtoXzfzGUF+aGOTYfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718798; c=relaxed/simple; bh=a6vGBLE1u2hj1foMl06tHlMugPoZCqkWUUayvZUGFEM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kU2ORAmtn+9RIH3LR215qr/QdKVjswrtmqX6hfylTfoc3PNXixhT0YELpR2GrKJODKCkh+mMp2AeGe2D8DbmWKuFHhYCKsB3QFbCFbmAd2qzdhXumlmMaapmKonA+1RrHmTQuoweI8gQWSgSSfkTj0tKXI/HqPXd56DWfCs6ZRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GG4/EEtV; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GG4/EEtV" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47ff94b46afso51783575e9.1 for ; Tue, 10 Feb 2026 02:19:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770718795; x=1771323595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fPmvvfUUyQ4LIE9KNYKtxQHjVRED/OZWx09lHdwFmBY=; b=GG4/EEtVFumYu7AQ6KWnHWCaN9odoWlk5czvrcIsO2QAfE2FYmtwv671uLbSuLBrN8 x7H9NzZ5FOLoPwoFdwelhpm5vLKpElRZlPnagojw4H/tkRm9g/vQhp6ZmuXsgHHRKwRq u/S+RlFqwJOw15qk6l6tx5tJvhIGmbUPMwndjGDZH9saS1/OcXKD5RaoAFHel0vWlMAL hBMWeYHacNsPIvMXaGMvDX4n5sv1oD1hvgIHaWniA4Jycnamsa2rzOlrt5Btb4RCnvF7 d2Hk5yLExXR3ST/67LU9A28vuZbLv2NHKpz7DhzYUsMmfcr3+Ll2hTZM1cwqTgnrZSm4 NXuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770718795; x=1771323595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fPmvvfUUyQ4LIE9KNYKtxQHjVRED/OZWx09lHdwFmBY=; b=D6T9qRMURHSQItMJNHaijbZyFy8xWRpv6LFeODH36dlz4oY05abhDN+ZBIwzX+8jAd oVBsZ3lio9fmfytog4UpbGM/6vDg3o4mBaaPjhUiJcbsmZ6Qf/YTwFSJuRXSW8rir1u8 gomAzG8T0KQbM2ozOW4R5tVfAr9wqr2jPVoNWMoWm0eU+K5FUiUu/3dXfMrQWWO4/Y3u ZYGf6tOFQgR5egUjtF/NjIHyDT8xyZVryahO/BjNL+p8onsKBLVW87dbjxmNKsOc2Mb3 4w1Z1qn52fT+fBFQZpr6OqPLqWDrPcUNnjZwR4OFOLNv0fpVvOxp6VGpdBG7CWWYwpgN 4ahA== X-Forwarded-Encrypted: i=1; AJvYcCXGfvnqq60iG8yIOTU93gYPDHqrH95iThJJkTar4TjFU8Sgd/pVMirTPgJ3c7W5O/9cahMrs/2lNfqMBDI=@vger.kernel.org X-Gm-Message-State: AOJu0YzAP2XMrscFkm5lAXA1Oy7WGESJSYzpNBapXhV8vT4VfSrJxn0/ oMdiR5wS3hSZf3bywKDuW1aWYsm1eyrC1zk3DSvaAsPoqa96lJbl0043 X-Gm-Gg: AZuq6aJRtBpsYihYcomLyBcQ6tq6ktqAPffVRgyLa8brpwXQ9N5cUfngfSuAu7mW8Xx KyTo+1JzR16umZCd6/XZbhg/kR21DolVQ1oPKN8FqpYZS9RnM2mp8tAdwx3HV5FS88buYBbdBpO y/c2ZSR0JJc9nxWx1esMruRziR+coE3nADgXfluieKrqubxsCuU0NeSdALJwhr2mixBEUH7cYsW Hbhbn8zvEl6OB/701A+h1mgZI3nf3M8vvn4BxQ2vDtQllu1JcQ/TvZP2j1jAC+dbH8BnO/6rCqP H92Qw3jQq2Qeao/toxFpnhnhbAc6ML3J1IgWC95sAzxD36ikK9705CD74es7QxQKtusYMoAfSpg NXudJDvMfcN3HxFL+DoBmGjeik+UM4fGIeVCdpRtpqJDfg8tfKvzAdrEEjUMsGwCNsHnV+ZC+zR c0bQ3QcRsW3GGhgUgrv6X9HIHkNrb7TE+UEO2fl3B+4LPR/YywsYuAzq2ZILmHvWTd X-Received: by 2002:a05:600c:6c5:b0:47e:e48f:43b5 with SMTP id 5b1f17b1804b1-4834ffb25fdmr14935985e9.18.1770718795213; Tue, 10 Feb 2026 02:19:55 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436297462a8sm30950423f8f.30.2026.02.10.02.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 02:19:54 -0800 (PST) Date: Tue, 10 Feb 2026 10:19:52 +0000 From: David Laight To: Yoelvis Oliveros Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: octeon: type change from uint_t to u Message-ID: <20260210101952.631bf50c@pumpkin> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 10 Feb 2026 00:36:31 -0400 Yoelvis Oliveros wrote: > Runing the ckeckpatch.pl on the staging/octeon driver they where using > uint<8/16/32/64>_T as type declaration and the checkpatch.pl was > putting a [CHECK] flag on those and that they should be change to > u<8/16/32/64> > ... > struct { > - u64 bufs : 8; > - u64 ip_offset : 8; > - u64 vlan_valid : 1; > u64 vlan_stacked : 1; > - u64 unassigned : 1; > - u64 vlan_cfi : 1; > - u64 vlan_id : 12; > - u64 pr : 4; > - u64 unassigned2 : 8; > - u64 dec_ipcomp : 1; > - u64 tcp_or_udp : 1; > - u64 dec_ipsec : 1; > - u64 is_v6 : 1; > - u64 software : 1; > - u64 L4_error : 1; > - u64 is_frag : 1; > - u64 IP_exc : 1; > - u64 is_bcast : 1; > - u64 is_mcast : 1; > - u64 not_IP : 1; > - u64 rcv_error : 1; > - u64 err_code : 8; > } s; As a separate issue, what is the purpose of all these bit-field structures? You can't portably use C bit-fields to map hardware registers or network packets. It isn't just byte-order, the 'bit order' can differ even for the same endianness. It also doesn't seem ideal to base everything on u64. The (aligned) 8 bit fields should really be plain 'u8', there are places where it does make a difference. David