From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Pavlu <petr.pavlu@suse.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Tom Zanussi <zanussi@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] tracing: Clean up access to trace_event_file from a file pointer
Date: Wed, 11 Feb 2026 11:45:38 -0500 [thread overview]
Message-ID: <20260211114538.577122c8@fedora> (raw)
In-Reply-To: <20260210113427.1068932-5-petr.pavlu@suse.com>
On Tue, 10 Feb 2026 12:28:19 +0100
Petr Pavlu <petr.pavlu@suse.com> wrote:
> In the past, when removing an event directory in remove_event_file_dir(),
> the code set i_private to NULL for all event files and readers were
> expected to check for this state to recognize that the event is being
> removed. In the case of event_id_read(), the value was read using
> event_file_data() without acquiring the event_mutex. This required
> event_file_data() to use READ_ONCE() when retrieving the i_private data.
I'm OK with this change. Instead of removing the event_file_data() like
you did from event_id_read(), just open code it there. The id is
simple, let's keep it that way.
That is, something like:
int id = (long)READ_ONCE(file_inode(filp)->i_private);
Feel free to add comments to explain it.
Thanks,
-- Steve
next prev parent reply other threads:[~2026-02-11 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 11:28 [PATCH 0/5] Clean up access to trace_event_file from a file struct Petr Pavlu
2026-02-10 11:28 ` [PATCH 1/5] tracing: Fix checking of freed trace_event_file for hist files Petr Pavlu
2026-02-10 15:59 ` Masami Hiramatsu
2026-02-10 17:40 ` kernel test robot
2026-02-11 16:28 ` Steven Rostedt
2026-02-10 18:57 ` kernel test robot
2026-02-10 11:28 ` [PATCH 2/5] tracing: Fix checking of freed trace_event_file for id files Petr Pavlu
2026-02-11 16:37 ` Steven Rostedt
2026-02-12 8:15 ` Petr Pavlu
2026-02-10 11:28 ` [PATCH 3/5] tracing: Remove unnecessary check for EVENT_FILE_FL_FREED Petr Pavlu
2026-02-10 11:28 ` [PATCH 4/5] tracing: Clean up access to trace_event_file from a file pointer Petr Pavlu
2026-02-11 16:45 ` Steven Rostedt [this message]
2026-02-10 11:28 ` [PATCH 5/5] tracing: Free up file->private_data for use by individual events Petr Pavlu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211114538.577122c8@fedora \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox