From: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
To: hansg@kernel.org
Cc: atharvatiwarilinuxdev@gmail.com, ilpo.jarvinen@linux.intel.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3] apple-gmux: preserve brightness using EFI
Date: Wed, 11 Feb 2026 18:00:18 +0530 [thread overview]
Message-ID: <20260211123018.4910-1-atharvatiwarilinuxdev@gmail.com> (raw)
In-Reply-To: <44e9e403-55f6-4601-9ba5-991619d09d88@kernel.org>
> I think this is missing efivar_lock() + unlock() calls ?
actually, efivar_set_variable already holds the lock, so efivar_lock isint
required.
See: drivers/firmware/efi/vars.c:242 and drivers/firmware/efi/vars.c:184
next prev parent reply other threads:[~2026-02-11 12:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 9:26 [PATCH v3] apple-gmux: preserve brightness using EFI Atharva Tiwari
2026-02-11 12:01 ` Hans de Goede
2026-02-11 12:30 ` Atharva Tiwari [this message]
2026-02-11 12:32 ` Hans de Goede
2026-03-13 19:39 ` Atharva Tiwari
2026-03-14 20:06 ` Lukas Wunner
2026-02-11 12:48 ` Lukas Wunner
2026-03-14 22:45 ` Atharva Tiwari
2026-03-14 23:11 ` Armin Wolf
2026-03-15 22:08 ` Atharva Tiwari
2026-03-15 22:54 ` Armin Wolf
2026-03-16 15:37 ` Atharva Tiwari
2026-03-15 14:28 ` Lukas Wunner
2026-03-15 22:05 ` Atharva Tiwari
2026-02-11 17:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211123018.4910-1-atharvatiwarilinuxdev@gmail.com \
--to=atharvatiwarilinuxdev@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox