From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0E7933AD92; Wed, 11 Feb 2026 16:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770826384; cv=none; b=GLLKidb0gJvUa9fXRFHQzX7aR4cDD9QXhJnM0+mWlAFQ6qpQ/6J3UmpLej5mW3q8KCGTXyRp6VyFE1DKdx1AEAmcjuiOnI3NWBsx4bHLUvy6zj4+DAadYaAniWvPH0TnGA47fL2EdZ1Gqj8e9C8u0ve/aPn0Dru+zf8W0Wr4wwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770826384; c=relaxed/simple; bh=8iJls6/Nn0Nnf+3DxmQiylsNiVOG9+OgQ6KqV4bL0hw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WrLFIQuEJLmz19nuyZhjWIWIZVFxAROxyAXs7N4qjr8SaA/L9OHzNPK1D6mvGjAchANPA98Morw19U8Yqhh/23wLqgw8Kx+Oru5tJtKZNAhH9C6VSUmdDStgp0GGgS8FRnceeH3yGp68hH5/0k3Ju8G7O1XTPDCZgtqcfF4MWtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=iCrZKtLs; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="iCrZKtLs" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 273CB4E40C69; Wed, 11 Feb 2026 16:13:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id EED36606B1; Wed, 11 Feb 2026 16:12:59 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5630411948F67; Wed, 11 Feb 2026 17:12:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770826379; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=GLSoznGjK4wXaxCZZX7e0bNRIASf8PQPorLUxjFHDho=; b=iCrZKtLsdt3FHzFGi+EOo74a6rYrtDtBb2aFrSyV3NBJsEB8gvh7/rAHs4n1YnhJuKsZjf A7t1GeoYC6sv4DNkbbGdMPnuU1huqr1yxWhi6G/c5i/4aT6z6p4vFO0tgfRaVyMAhlcX3j ClmK5uqGTyZ5PlVAaHejKLtcQuh6zFDeh1z6aJGtjL9CySBLpmMfGYtFl0oAODlCf87Yeh kIKPsCGqwO4wGkmpaLp1OpFY54muV4qh63MmHZpgcqSqW+q14QUDb7c9wBpTNN5mW11Jl1 Rm/k8lblUU4Q5gpfpCnsZOTHtHBg/7yyzA7Mo79N2XqT9P/S0LvjkIXV5rQZHQ== Date: Wed, 11 Feb 2026 17:12:52 +0100 From: Herve Codina To: Ioana Ciornei Cc: Thomas Gleixner , Wolfram Sang , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Saravana Kannan , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni Subject: Re: [PATCH v8 3/8] irqchip/ls-extirq: Use for_each_of_imap_item iterator Message-ID: <20260211171252.34e4e6a1@bootlin.com> In-Reply-To: References: <20260114093938.1089936-1-herve.codina@bootlin.com> <20260114093938.1089936-4-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Ioana, On Wed, 11 Feb 2026 12:03:00 +0200 Ioana Ciornei wrote: > On Wed, Jan 14, 2026 at 10:39:32AM +0100, Herve Codina (Schneider Electric) wrote: > > The ls-extirq driver parses the interrupt-map property. It does it using > > open code. > > > > Recently for_each_of_imap_item iterator has been introduce to help > > drivers in this parsing. > > > > Convert the ls-extirq driver to use the for_each_of_imap_item > > iterator instead of open code. > > > > The ls-extirq uses interrupt-map but it's a non-standard use documented > in fsl,ls-extirq.yaml: > > # The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT > # function to parser interrupt-map. So it doesn't consider '#address-size' > # in parent interrupt controller, such as GIC. > # > # When dt-binding verify interrupt-map, item data matrix is spitted at > # incorrect position. Remove interrupt-map restriction because it always > # wrong. > > This means that by using for_each_of_imap_item and the underlying > of_irq_parse_imap_parent() on its interrupt-map property will > effectively break its functionality. > > Unfortunatelly, I am not sure how this can be fixed other than with a > revert. > Well, if this is the only solution due to non compliance with interrupt-map, I am not opposed to the revert of the following patch: 3ac6dfe3d7a23 ("irqchip/ls-extirq: Use for_each_of_imap_item iterator") (SHA taken from next-20260205 tag) Best regards, Hervé