* [PATCH] sched/rt: remove empty sched_rt_do_global() helper
@ 2025-12-17 7:37 Zhan Xusheng
0 siblings, 0 replies; 4+ messages in thread
From: Zhan Xusheng @ 2025-12-17 7:37 UTC (permalink / raw)
To: peterz
Cc: mingo, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, vschneid, linux-sched, linux-kernel,
Zhan Xusheng
sched_rt_do_global() is an empty helper that has no effect on
RT bandwidth sysctl handling.
Remove the unused function and its call site to simplify the
sysctl update path.
No functional change intended.
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
kernel/sched/rt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index f1867fe8e5c5..90f62de52f63 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2854,10 +2854,6 @@ static int sched_rt_global_validate(void)
return 0;
}
-static void sched_rt_do_global(void)
-{
-}
-
static int sched_rt_handler(const struct ctl_table *table, int write, void *buffer,
size_t *lenp, loff_t *ppos)
{
@@ -2885,7 +2881,6 @@ static int sched_rt_handler(const struct ctl_table *table, int write, void *buff
if (ret)
goto undo;
- sched_rt_do_global();
sched_dl_do_global();
}
if (0) {
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] sched/rt: Remove empty sched_rt_do_global() helper
@ 2026-02-11 7:11 Zhan Xusheng
2026-02-11 8:25 ` K Prateek Nayak
0 siblings, 1 reply; 4+ messages in thread
From: Zhan Xusheng @ 2026-02-11 7:11 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: Juri Lelli, linux-kernel, Zhan Xusheng, K Prateek Nayak
sched_rt_do_global() is an empty helper that has no effect on
RT bandwidth sysctl handling.
Historically, sched_rt_do_global() was responsible for managing
RT throttling parameters before the introduction of the fair
server. Since commit 5f6bd380c7bd ("sched/rt: Remove default
bandwidth control"), the function became obsolete, but the empty
helper and its call site were retained.
Remove the unused function and its call site to simplify the
sysctl update path.
No functional change intended.
Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
kernel/sched/rt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index a7680477fa6f..f49b75d36428 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2862,10 +2862,6 @@ static int sched_rt_global_validate(void)
return 0;
}
-static void sched_rt_do_global(void)
-{
-}
-
static int sched_rt_handler(const struct ctl_table *table, int write, void *buffer,
size_t *lenp, loff_t *ppos)
{
@@ -2893,7 +2889,6 @@ static int sched_rt_handler(const struct ctl_table *table, int write, void *buff
if (ret)
goto undo;
- sched_rt_do_global();
sched_dl_do_global();
}
if (0) {
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sched/rt: Remove empty sched_rt_do_global() helper
2026-02-11 7:11 [PATCH] sched/rt: Remove empty sched_rt_do_global() helper Zhan Xusheng
@ 2026-02-11 8:25 ` K Prateek Nayak
2026-02-12 2:05 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: K Prateek Nayak @ 2026-02-11 8:25 UTC (permalink / raw)
To: Zhan Xusheng, Peter Zijlstra
Cc: Juri Lelli, linux-kernel, Zhan Xusheng, Steven Rostedt
(+Steve)
Hello Zhan,
On 2/11/2026 12:41 PM, Zhan Xusheng wrote:
> sched_rt_do_global() is an empty helper that has no effect on
> RT bandwidth sysctl handling.
>
> Historically, sched_rt_do_global() was responsible for managing
> RT throttling parameters before the introduction of the fair
> server. Since commit 5f6bd380c7bd ("sched/rt: Remove default
> bandwidth control"), the function became obsolete, but the empty
> helper and its call site were retained.
>
> Remove the unused function and its call site to simplify the
> sysctl update path.
>
> No functional change intended.
>
> Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
I believe there is another competing cleanup by Michal at
https://lore.kernel.org/lkml/20260119-sched-rert_groups-v1-0-80c1e5269910@suse.com/
which is doing a little bit more.
I'll leave it to Peter / Steve to pick which one they prefer.
--
Thanks and Regards,
Prateek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sched/rt: Remove empty sched_rt_do_global() helper
2026-02-11 8:25 ` K Prateek Nayak
@ 2026-02-12 2:05 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2026-02-12 2:05 UTC (permalink / raw)
To: K Prateek Nayak
Cc: Zhan Xusheng, Peter Zijlstra, Juri Lelli, linux-kernel,
Zhan Xusheng
On Wed, 11 Feb 2026 13:55:12 +0530
K Prateek Nayak <kprateek.nayak@amd.com> wrote:
> I'll leave it to Peter / Steve to pick which one they prefer.
It should go through Peter.
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-12 2:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-11 7:11 [PATCH] sched/rt: Remove empty sched_rt_do_global() helper Zhan Xusheng
2026-02-11 8:25 ` K Prateek Nayak
2026-02-12 2:05 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2025-12-17 7:37 [PATCH] sched/rt: remove " Zhan Xusheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox