[PATCH 0/3] ASoC: codec: fixes for ak4458 and ak5558 codecs

[PATCH 0/3] ASoC: codec: fixes for ak4458 and ak5558 codecs

[Shengjiu Wang]

Fix the binding document of ak4458
Fix the supply name of ak4458 and ak5558

Shengjiu Wang (3):
  ASoC: dt-bindings: asahi-kasei,ak4458: set unevaluatedProperties:false
  ASoC: ak4458: Fix the supply names
  ASoC: ak5558: Fix the supply names

 .../devicetree/bindings/sound/asahi-kasei,ak4458.yaml         | 2 +-
 sound/soc/codecs/ak4458.c                                     | 4 ++--
 sound/soc/codecs/ak5558.c                                     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.34.1

[PATCH 1/3] ASoC: dt-bindings: asahi-kasei,ak4458: set unevaluatedProperties:false

[Shengjiu Wang]

When including the dai-common.yaml, should use unevaluatedProperties:false
according to writing-bindings.rst.

Fixes: 8d7de4a014f5 ("ASoC: dt-bindings: asahi-kasei,ak4458: Reference common DAI properties")
Cc: stable@vger.kernel.org
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
index 1fdbeecc5eff..259e97b7a3c0 100644
--- a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
+++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
@@ -60,7 +60,7 @@ allOf:
       properties:
         dsd-path: false
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.34.1

Re: [PATCH 1/3] ASoC: dt-bindings: asahi-kasei,ak4458: set unevaluatedProperties:false

[Rob Herring]

On Wed, Feb 11, 2026 at 05:35:25PM +0800, Shengjiu Wang wrote:
> When including the dai-common.yaml, should use unevaluatedProperties:false
> according to writing-bindings.rst.

Generally true, but not always. Do you have an actual problem? The only 
possible problem is you want to use "sound-name-prefix" property. 
Otherwise, you don't need this.

> 
> Fixes: 8d7de4a014f5 ("ASoC: dt-bindings: asahi-kasei,ak4458: Reference common DAI properties")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
> index 1fdbeecc5eff..259e97b7a3c0 100644
> --- a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
> +++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
> @@ -60,7 +60,7 @@ allOf:
>        properties:
>          dsd-path: false
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> -- 
> 2.34.1
> 

Re: [PATCH 1/3] ASoC: dt-bindings: asahi-kasei,ak4458: set unevaluatedProperties:false

[Shengjiu Wang]

On Thu, Feb 12, 2026 at 5:53 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Feb 11, 2026 at 05:35:25PM +0800, Shengjiu Wang wrote:
> > When including the dai-common.yaml, should use unevaluatedProperties:false
> > according to writing-bindings.rst.
>
> Generally true, but not always. Do you have an actual problem? The only
> possible problem is you want to use "sound-name-prefix" property.
> Otherwise, you don't need this.

Yes, I want to use "sound-name-prefix" and "#sound-dai-cells".

Best regards
Shengjiu Wang

>
> >
> > Fixes: 8d7de4a014f5 ("ASoC: dt-bindings: asahi-kasei,ak4458: Reference common DAI properties")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
> > index 1fdbeecc5eff..259e97b7a3c0 100644
> > --- a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
> > +++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
> > @@ -60,7 +60,7 @@ allOf:
> >        properties:
> >          dsd-path: false
> >
> > -additionalProperties: false
> > +unevaluatedProperties: false
> >
> >  examples:
> >    - |
> > --
> > 2.34.1
> >
>

Re: [PATCH 1/3] ASoC: dt-bindings: asahi-kasei,ak4458: set unevaluatedProperties:false

[Rob Herring]

On Wed, Feb 11, 2026 at 7:44 PM Shengjiu Wang <shengjiu.wang@gmail.com> wrote:
>
> On Thu, Feb 12, 2026 at 5:53 AM Rob Herring <robh@kernel.org> wrote:
> >
> > On Wed, Feb 11, 2026 at 05:35:25PM +0800, Shengjiu Wang wrote:
> > > When including the dai-common.yaml, should use unevaluatedProperties:false
> > > according to writing-bindings.rst.
> >
> > Generally true, but not always. Do you have an actual problem? The only
> > possible problem is you want to use "sound-name-prefix" property.
> > Otherwise, you don't need this.
>
> Yes, I want to use "sound-name-prefix" and "#sound-dai-cells".

Then please say that in the commit message. It's not really a fix
unless "sound-name-prefix" was already used.

Rob

Re: [PATCH 1/3] ASoC: dt-bindings: asahi-kasei,ak4458: set unevaluatedProperties:false

[Shengjiu Wang]

On Thu, Feb 12, 2026 at 10:38 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Feb 11, 2026 at 7:44 PM Shengjiu Wang <shengjiu.wang@gmail.com> wrote:
> >
> > On Thu, Feb 12, 2026 at 5:53 AM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Wed, Feb 11, 2026 at 05:35:25PM +0800, Shengjiu Wang wrote:
> > > > When including the dai-common.yaml, should use unevaluatedProperties:false
> > > > according to writing-bindings.rst.
> > >
> > > Generally true, but not always. Do you have an actual problem? The only
> > > possible problem is you want to use "sound-name-prefix" property.
> > > Otherwise, you don't need this.
> >
> > Yes, I want to use "sound-name-prefix" and "#sound-dai-cells".
>
> Then please say that in the commit message. It's not really a fix
> unless "sound-name-prefix" was already used.

Yes,  v2 has been sent.
Thanks.

Best regards
Shengjiu Wang
>
> Rob

[PATCH 2/3] ASoC: ak4458: Fix the supply names

[Shengjiu Wang]

According to the binding document, the supply name characters are
lowercase.

Fixes: 7e3096e8f823 ("ASoC: ak4458: Add regulator support")
Cc: stable@vger.kernel.org
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 sound/soc/codecs/ak4458.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
index f81cd8cebdd8..bfd4c039bbb7 100644
--- a/sound/soc/codecs/ak4458.c
+++ b/sound/soc/codecs/ak4458.c
@@ -24,8 +24,8 @@
 
 #define AK4458_NUM_SUPPLIES 2
 static const char *ak4458_supply_names[AK4458_NUM_SUPPLIES] = {
-	"DVDD",
-	"AVDD",
+	"dvdd",
+	"avdd",
 };
 
 enum ak4458_type {
-- 
2.34.1

Re: [PATCH 2/3] ASoC: ak4458: Fix the supply names

[Shengjiu Wang]

Hi

On Wed, Feb 11, 2026 at 5:37 PM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> According to the binding document, the supply name characters are
> lowercase.

According to the change history,  seems caused by the patch which
converts txt to dtschema
So should I fix the binding document for this case?

best regards
Shengjiu Wang
>
> Fixes: 7e3096e8f823 ("ASoC: ak4458: Add regulator support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  sound/soc/codecs/ak4458.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
> index f81cd8cebdd8..bfd4c039bbb7 100644
> --- a/sound/soc/codecs/ak4458.c
> +++ b/sound/soc/codecs/ak4458.c
> @@ -24,8 +24,8 @@
>
>  #define AK4458_NUM_SUPPLIES 2
>  static const char *ak4458_supply_names[AK4458_NUM_SUPPLIES] = {
> -       "DVDD",
> -       "AVDD",
> +       "dvdd",
> +       "avdd",
>  };
>
>  enum ak4458_type {
> --
> 2.34.1
>
>

Re: [PATCH 2/3] ASoC: ak4458: Fix the supply names

[Andy Shevchenko]

On Wed, Feb 11, 2026 at 05:35:26PM +0800, Shengjiu Wang wrote:
> According to the binding document, the supply name characters are
> lowercase.

...

>  static const char *ak4458_supply_names[AK4458_NUM_SUPPLIES] = {
> -	"DVDD",
> -	"AVDD",
> +	"dvdd",
> +	"avdd",
>  };

In kernel we also have

arch/arm/boot/dts/actions/owl-s500-roseapplepi.dts:123:                         regulator-name = "AVDD";
arch/arm/mach-s3c/mach-crag6410.c:631:  REGULATOR_SUPPLY("AVDD", "spi0.0"),
arch/arm/mach-s3c/mach-crag6410.c:632:  REGULATOR_SUPPLY("AVDD", "spi0.1"),
arch/arm/mach-s3c/mach-crag6410.c:655:  REGULATOR_SUPPLY("AVDD", "1-001a"),
arch/arm/mach-s3c/mach-crag6410.c:661:  REGULATOR_SUPPLY("AVDD", "1-003a"),

Are those related? Can they affect this one?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 2/3] ASoC: ak4458: Fix the supply names

[Charles Keepax]

On Wed, Feb 11, 2026 at 01:18:31PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 11, 2026 at 05:35:26PM +0800, Shengjiu Wang wrote:
> > According to the binding document, the supply name characters are
> > lowercase.
> 
> ...
> 
> >  static const char *ak4458_supply_names[AK4458_NUM_SUPPLIES] = {
> > -	"DVDD",
> > -	"AVDD",
> > +	"dvdd",
> > +	"avdd",
> >  };
> 
> In kernel we also have
> 
> arch/arm/boot/dts/actions/owl-s500-roseapplepi.dts:123:                         regulator-name = "AVDD";
> arch/arm/mach-s3c/mach-crag6410.c:631:  REGULATOR_SUPPLY("AVDD", "spi0.0"),
> arch/arm/mach-s3c/mach-crag6410.c:632:  REGULATOR_SUPPLY("AVDD", "spi0.1"),
> arch/arm/mach-s3c/mach-crag6410.c:655:  REGULATOR_SUPPLY("AVDD", "1-001a"),
> arch/arm/mach-s3c/mach-crag6410.c:661:  REGULATOR_SUPPLY("AVDD", "1-003a"),
> 
> Are those related? Can they affect this one?

No idea about the roseapplepi one but all the crag6410 ones
are totally different devices from this series.

Thanks,
Charles

[PATCH 3/3] ASoC: ak5558: Fix the supply names

[Shengjiu Wang]

According to the binding document, the supply name characters are
lowercase.

Fixes: 2ff6d5a108c6 ("ASoC: ak5558: Add regulator support")
Cc: stable@vger.kernel.org
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 sound/soc/codecs/ak5558.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/ak5558.c b/sound/soc/codecs/ak5558.c
index 73684fc5beb1..48a690d81047 100644
--- a/sound/soc/codecs/ak5558.c
+++ b/sound/soc/codecs/ak5558.c
@@ -31,8 +31,8 @@ enum ak555x_type {
 
 #define AK5558_NUM_SUPPLIES 2
 static const char *ak5558_supply_names[AK5558_NUM_SUPPLIES] = {
-	"DVDD",
-	"AVDD",
+	"dvdd",
+	"avdd",
 };
 
 /* AK5558 Codec Private Data */
-- 
2.34.1

Re: [PATCH 3/3] ASoC: ak5558: Fix the supply names

[Shengjiu Wang]

Hi

On Wed, Feb 11, 2026 at 5:37 PM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> According to the binding document, the supply name characters are
> lowercase.

According to the change history,  seems caused by the patch which
converts txt to dtschema
So should I fix the binding document for this case?

best regards
Shengjiu Wang
>
> Fixes: 2ff6d5a108c6 ("ASoC: ak5558: Add regulator support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  sound/soc/codecs/ak5558.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/ak5558.c b/sound/soc/codecs/ak5558.c
> index 73684fc5beb1..48a690d81047 100644
> --- a/sound/soc/codecs/ak5558.c
> +++ b/sound/soc/codecs/ak5558.c
> @@ -31,8 +31,8 @@ enum ak555x_type {
>
>  #define AK5558_NUM_SUPPLIES 2
>  static const char *ak5558_supply_names[AK5558_NUM_SUPPLIES] = {
> -       "DVDD",
> -       "AVDD",
> +       "dvdd",
> +       "avdd",
>  };
>
>  /* AK5558 Codec Private Data */
> --
> 2.34.1
>
>

Re: [PATCH 3/3] ASoC: ak5558: Fix the supply names

[Andy Shevchenko]

On Wed, Feb 11, 2026 at 07:18:26PM +0800, Shengjiu Wang wrote:
> On Wed, Feb 11, 2026 at 5:37 PM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
> >
> > According to the binding document, the supply name characters are
> > lowercase.
> 
> According to the change history,  seems caused by the patch which
> converts txt to dtschema
> So should I fix the binding document for this case?

It seems I just answered to your question.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 3/3] ASoC: ak5558: Fix the supply names

[Andy Shevchenko]

On Wed, Feb 11, 2026 at 05:35:27PM +0800, Shengjiu Wang wrote:
> According to the binding document, the supply name characters are
> lowercase.

Same question. If it's okay to convert, please elaborate that it doesn't have
any side-effects for in-kernel users. Also, check if these names may come from
DTS (some old DTS might have it, in such case it's a documentation issue, or
driver needs to support both).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 3/3] ASoC: ak5558: Fix the supply names

[Shengjiu Wang]

On Wed, Feb 11, 2026 at 7:21 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Feb 11, 2026 at 05:35:27PM +0800, Shengjiu Wang wrote:
> > According to the binding document, the supply name characters are
> > lowercase.
>
> Same question. If it's okay to convert, please elaborate that it doesn't have
> any side-effects for in-kernel users. Also, check if these names may come from
> DTS (some old DTS might have it, in such case it's a documentation issue, or
> driver needs to support both).

Thanks.

I go through all the DTS,  no DTS uses DVDD/AVDD or dvdd/avdd for ak4458 and
ak5558 codecs.  so there is no side-effect.

I just am thinking it is better to fix it in document,  it is caused
by converting txt to
dtschema.

Best regards
shengjiu Wang
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
>

Re: [PATCH 3/3] ASoC: ak5558: Fix the supply names

[Andy Shevchenko]

On Wed, Feb 11, 2026 at 07:29:42PM +0800, Shengjiu Wang wrote:
> On Wed, Feb 11, 2026 at 7:21 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Feb 11, 2026 at 05:35:27PM +0800, Shengjiu Wang wrote:
> > > According to the binding document, the supply name characters are
> > > lowercase.
> >
> > Same question. If it's okay to convert, please elaborate that it doesn't have
> > any side-effects for in-kernel users. Also, check if these names may come from
> > DTS (some old DTS might have it, in such case it's a documentation issue, or
> > driver needs to support both).
> 
> Thanks.
> 
> I go through all the DTS,  no DTS uses DVDD/AVDD or dvdd/avdd for ak4458 and
> ak5558 codecs.  so there is no side-effect.

You mean no "in-kernel" DTS. But my question was if any DTS in the world may
supply this as AVDD? If answer is yes, the binding must be changed. But then
the same issue may come due to somebody using a new binding somewhere. however
I don't understand how in that case it will work in Linux (only other projects
that use the same bindings as Linux kernel may be affected).

> I just am thinking it is better to fix it in document, it is caused
> by converting txt to dtschema.

I think this sounds at least like a safer change.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/3] ASoC: codec: fixes for ak4458 and ak5558 codecs

[Shengjiu Wang]

On Wed, Feb 11, 2026 at 5:34 PM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> Fix the binding document of ak4458
> Fix the supply name of ak4458 and ak5558

I will send v2 to fix the patch 2/3 and 3/3, to fix the binding doc instead.
Thanks.

Best regards
Shengjiu Wang
>
> Shengjiu Wang (3):
>   ASoC: dt-bindings: asahi-kasei,ak4458: set unevaluatedProperties:false
>   ASoC: ak4458: Fix the supply names
>   ASoC: ak5558: Fix the supply names
>
>  .../devicetree/bindings/sound/asahi-kasei,ak4458.yaml         | 2 +-
>  sound/soc/codecs/ak4458.c                                     | 4 ++--
>  sound/soc/codecs/ak5558.c                                     | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.34.1
>
>