From: Rob Herring <robh@kernel.org>
To: hehuan1@eswincomputing.com
Cc: ulf.hansson@linaro.org, krzk+dt@kernel.org, conor+dt@kernel.org,
jszhang@kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
ningyu@eswincomputing.com, linmin@eswincomputing.com,
pinkesh.vaghela@einfochips.com, xuxiang@eswincomputing.com,
Pritesh Patel <pritesh.patel@einfochips.com>
Subject: Re: [PATCH v1] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation
Date: Wed, 11 Feb 2026 16:10:17 -0600 [thread overview]
Message-ID: <20260211221017.GA3976151-robh@kernel.org> (raw)
In-Reply-To: <20260211094736.88-1-hehuan1@eswincomputing.com>
On Wed, Feb 11, 2026 at 05:47:36PM +0800, hehuan1@eswincomputing.com wrote:
> From: Huan He <hehuan1@eswincomputing.com>
>
> The binding defines tuple-style reset-names items for some
> compatibles, which implicitly enforces a fixed array length
> via JSON Schema.
>
> Defining global maxItems for resets and reset-names causes these
> constraints to be intersected via allOf, resulting in an effective
> minItems equal to the global maxItems. This leads to dtbs_check
> failures reporting reset arrays as too short, even when the DTS
> provides the correct number of entries.
>
> Remove the global maxItems constraints and let the per-compatible
> schema branches define the required reset array sizes explicitly.
>
> Fixes: 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
> Signed-off-by: Pritesh Patel <pritesh.patel@einfochips.com>
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>
> ---
> .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 7e7c55dc2440..8af55a53b569 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -49,12 +49,6 @@ properties:
> power-domains:
> maxItems: 1
>
> - resets:
> - maxItems: 5
> -
> - reset-names:
> - maxItems: 5
No, add 'minItems' that covers the whole range needed.
next prev parent reply other threads:[~2026-02-11 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 9:47 [PATCH v1] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation hehuan1
2026-02-11 22:10 ` Rob Herring [this message]
2026-02-12 7:37 ` Huan He
2026-02-12 17:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211221017.GA3976151-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hehuan1@eswincomputing.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=pinkesh.vaghela@einfochips.com \
--cc=pritesh.patel@einfochips.com \
--cc=ulf.hansson@linaro.org \
--cc=xuxiang@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox