* [PATCH] xfs: fixup some alignment issues in xfs_ondisk.c
@ 2026-02-12 2:04 Wilfred Mallawa
2026-02-12 10:14 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Wilfred Mallawa @ 2026-02-12 2:04 UTC (permalink / raw)
To: Carlos Maiolino, Darrick J . Wong
Cc: linux-xfs, linux-kernel, Christoph Hellwig, Wilfred Mallawa
From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Fixup some code alignment issues in xfs_ondisk.c
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
---
fs/xfs/libxfs/xfs_ondisk.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_ondisk.h b/fs/xfs/libxfs/xfs_ondisk.h
index 1914ffe59202..23cde1248f01 100644
--- a/fs/xfs/libxfs/xfs_ondisk.h
+++ b/fs/xfs/libxfs/xfs_ondisk.h
@@ -73,7 +73,7 @@ xfs_check_ondisk_structs(void)
XFS_CHECK_STRUCT_SIZE(struct xfs_dir3_free_hdr, 64);
XFS_CHECK_STRUCT_SIZE(struct xfs_dir3_leaf, 64);
XFS_CHECK_STRUCT_SIZE(struct xfs_dir3_leaf_hdr, 64);
- XFS_CHECK_STRUCT_SIZE(struct xfs_attr_leaf_entry, 8);
+ XFS_CHECK_STRUCT_SIZE(struct xfs_attr_leaf_entry, 8);
XFS_CHECK_STRUCT_SIZE(struct xfs_attr_leaf_hdr, 32);
XFS_CHECK_STRUCT_SIZE(struct xfs_attr_leaf_map, 4);
XFS_CHECK_STRUCT_SIZE(struct xfs_attr_leaf_name_local, 4);
@@ -116,7 +116,7 @@ xfs_check_ondisk_structs(void)
XFS_CHECK_STRUCT_SIZE(struct xfs_da_intnode, 16);
XFS_CHECK_STRUCT_SIZE(struct xfs_da_node_entry, 8);
XFS_CHECK_STRUCT_SIZE(struct xfs_da_node_hdr, 16);
- XFS_CHECK_STRUCT_SIZE(struct xfs_dir2_data_free, 4);
+ XFS_CHECK_STRUCT_SIZE(struct xfs_dir2_data_free, 4);
XFS_CHECK_STRUCT_SIZE(struct xfs_dir2_data_hdr, 16);
XFS_CHECK_OFFSET(struct xfs_dir2_data_unused, freetag, 0);
XFS_CHECK_OFFSET(struct xfs_dir2_data_unused, length, 2);
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: fixup some alignment issues in xfs_ondisk.c
2026-02-12 2:04 [PATCH] xfs: fixup some alignment issues in xfs_ondisk.c Wilfred Mallawa
@ 2026-02-12 10:14 ` Christoph Hellwig
2026-02-12 22:53 ` Wilfred Mallawa
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2026-02-12 10:14 UTC (permalink / raw)
To: Wilfred Mallawa
Cc: Carlos Maiolino, Darrick J . Wong, linux-xfs, linux-kernel,
Christoph Hellwig, Wilfred Mallawa
On Thu, Feb 12, 2026 at 12:04:38PM +1000, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Fixup some code alignment issues in xfs_ondisk.c
That code should probably go into the subject as well, as that
initially made me think of data structure or load/store alignment.
But maybe Carlos can just fix this up when applying.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: fixup some alignment issues in xfs_ondisk.c
2026-02-12 10:14 ` Christoph Hellwig
@ 2026-02-12 22:53 ` Wilfred Mallawa
0 siblings, 0 replies; 3+ messages in thread
From: Wilfred Mallawa @ 2026-02-12 22:53 UTC (permalink / raw)
To: hch
Cc: djwong@kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, cem@kernel.org
On Thu, 2026-02-12 at 11:14 +0100, Christoph Hellwig wrote:
> On Thu, Feb 12, 2026 at 12:04:38PM +1000, Wilfred Mallawa wrote:
> > From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> >
> > Fixup some code alignment issues in xfs_ondisk.c
>
> That code should probably go into the subject as well, as that
> initially made me think of data structure or load/store alignment.
>
Ah good point, I've fixed this in V2. Thanks!
Wilfred
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-12 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-12 2:04 [PATCH] xfs: fixup some alignment issues in xfs_ondisk.c Wilfred Mallawa
2026-02-12 10:14 ` Christoph Hellwig
2026-02-12 22:53 ` Wilfred Mallawa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox