From: Boris Brezillon <boris.brezillon@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Onur Özkan" <work@onurozkan.dev>,
daniel.almeida@collabora.com, aliceryhl@google.com,
dakr@kernel.org, airlied@gmail.com, simona@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, ojeda@kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/1] drm/tyr: make SRAM supply optional like panthor
Date: Thu, 12 Feb 2026 14:51:34 +0100 [thread overview]
Message-ID: <20260212145134.799bb6fa@fedora> (raw)
In-Reply-To: <a76b1e27-87ea-42e0-88f3-0512b2e1ac0b@sirena.org.uk>
On Thu, 12 Feb 2026 13:13:31 +0000
Mark Brown <broonie@kernel.org> wrote:
> On Thu, Feb 12, 2026 at 01:46:01PM +0100, Boris Brezillon wrote:
> > Mark Brown <broonie@kernel.org> wrote:
>
> > > The panthor driver is buggy here and should be fixed, the driver should
> > > treat the supply as mandatory and let the system integration work out
> > > how it's actually made available.
>
> > > Trying to open code this just breaks the error handling.
>
> > Maybe, but the thing is, the DT bindings have been accepted already,
> > and it's not something we can easily change. What we can do is make this
> > sram-supply mandatory for new compatibles, but we can't force it on
> > older/existing SoCs without breaking backward-DT compat.
>
> In practice you can because we do sub in a dummy regulator for missing
> supplies, it produces a warning but works fine. If we didn't do this
> it'd be basically impossible to add regulator support to anything at any
> point after the original merge which is clearly not reasonable.
Okay, I guess we need to fix panthor then...
next prev parent reply other threads:[~2026-02-12 13:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 10:05 [PATCH v2 0/1] drm/tyr: make SRAM supply optional like panthor Onur Özkan
2026-02-12 10:05 ` [PATCH v2 1/1] " Onur Özkan
2026-02-12 11:34 ` Mark Brown
2026-02-12 12:16 ` Onur Özkan
2026-02-12 12:21 ` Mark Brown
2026-02-12 12:46 ` Boris Brezillon
2026-02-12 13:13 ` Mark Brown
2026-02-12 13:51 ` Boris Brezillon [this message]
2026-02-12 18:30 ` Onur Özkan
2026-02-13 12:15 ` Liviu Dudau
2026-02-13 12:42 ` Boris Brezillon
2026-02-13 12:59 ` Onur Özkan
2026-02-13 10:57 ` Liviu Dudau
2026-02-13 15:54 ` Mark Brown
2026-02-12 12:22 ` Boris Brezillon
2026-02-12 13:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212145134.799bb6fa@fedora \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox