From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B72A922578A for ; Thu, 12 Feb 2026 16:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770915357; cv=none; b=f48TTE6DMlRzSJFOhSPQFF+P4kACi3hSuqeGd+pEtGxUEN5S4dMERNW6y3Z8gX/4gxJFXVP11GB4gkWLQFtQWHkvAcXyutzagEt3sUebQXQQoMSdcem6Keu0oBjVF7jLoU0KomzMdTriI36eORI+n8dKFKYrJ31JAJC2dxVej+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770915357; c=relaxed/simple; bh=tu6NH5KRiqpHmO7a2E4izBi9G/Voi5o3rIHojUhD3Gg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iU6xQhJDSaSDtNIMRw5/3TOs12CXHmAj17HclYUaB6wERb/noRoo4VY3uqZKKQZjNFVKJJxQSuf7/+P7UAN5EzAJyqdTgt4D9MiXRs6+bO2r1H/fgExsOGSRtruGZnSXBamsWlzMtlKwSmXKU/ljXHyOEwOUtvHoOrOzqOYdfho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fTZswQco; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fTZswQco" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4836fc075d2so52795e9.0 for ; Thu, 12 Feb 2026 08:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770915354; x=1771520154; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EWH52hHDoZsOt/pe7QFROJLUmHx4Nch/byKXwRcnIQ8=; b=fTZswQcoPhPY2MwfeoyuqlxNoTYAl0qUKn99RZyjRr2g+ftzh2xQif1T772pDf+/l+ rS3iB54Ion+rDYOB1szBqeS5EZUNBITcXM+WNKXgowlxXdtVOtObl+6xCgAKtkLb6yUe RgBXB7HWubZ2DefpQKJG/XrmXSU2Vj7Hv29iX270uIWPw2Bio4l3kHlxn5EQtBxcLcwM ZBB4izRx3DyNG5t4Ab+dPgGqn8NG1Pbb91++O4cyMBrc+gvDV3YtxxlmEgTe012KDGhN 94b9/UjtBAC9FTpT4b64Z1f9UqCK5TJVAtu3SkIo8x06MEYBUbEKMAk28weaxKjxfSvD l3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770915354; x=1771520154; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EWH52hHDoZsOt/pe7QFROJLUmHx4Nch/byKXwRcnIQ8=; b=tAGJoJixDEfcrWSc8WqjeiIzrxL2dADRilpfni3VGAFBC+qKBu1HuzpJRmEEqfhWf2 Ba+Jgpx6Kytpss9T8SxAXVUfdEroQS04BdCxA91w8WBAd5ufPor53Sjhl3sIaM6xxnbI MWhlTn7LpfISCuaPpb7mlOxNkGB5hJndiUc12+gndn3RmkrQfdwCecSlvnpOhZ7zofaa 06jtSpc9hJwEvxBJ7KaiSV4fhMAb9RFDzegUXI94vtyOZdKyRMlrbYW+ONjtR4fDh71k B5uWNUz5hQAVXw4hECfPfnwkwzhsT+LBm5qgIJ7We+sOFP77TAOM3gsH3B/37Sj47AcT cr4g== X-Forwarded-Encrypted: i=1; AJvYcCWo+oQ8hso8aDuN+Fk16/a1+LX0hVjDFHe+scmKgyeBNdPd5I0cXSUc068lviH6K7qgA/OMHz+zndQ3cL4=@vger.kernel.org X-Gm-Message-State: AOJu0YxToZKQscPOpJjscNKThcDFSVpHAILRotYB9R8g62Z7xHN6SjxJ PXPmS5rUOLs5k3KKzkJ7PmIPhN3fbwiT2hvvdAvT+YG1SPRev4iuIas8LhXhXQ== X-Gm-Gg: AZuq6aLOW98Y8P2c2yYmru5BMplSH+GaGGvkKVhks9+mENQjsY6GqHqAX2pp95pSwQ9 UiMesjI8W53pOsYyKQDi+kBJj0DUpAhL1zPosVtvrYtph0waM9JZCTs6SseujxhSGy5XhE/Xlg6 x2L4QNVJ3eACbKD/9dTANCIIPB/Bo6oNW1WkIP6NuRZF1AbacDCzEnoqSvDM5nvaShN3fAMMjyF 1IfXyJE3niHnRM7KphwBoybPofFkgDMpxdSAr25wMGevU3gpxcJL9a63+aA0cbPzehqoB+CG7Bg L+iDCNhGm+oIy0qazc2unuFsZcPqnOxnCHIitWVOSQ/dRwWt/7RumVwbC5oBHosbilrOw/b2Lr7 f0M42XB7Ewuk0H3Rlg96nxHuka0JOcQN+I/ixq1uNk7QtHHb6IjFg1VDneSgkyHzfKnJZE4aWR0 ZOt9/81xIadHB0LTc= X-Received: by 2002:a05:600c:a09:b0:477:9fa8:bc99 with SMTP id 5b1f17b1804b1-4836570e260mr29901335e9.4.1770915353815; Thu, 12 Feb 2026 08:55:53 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:2f75:bf70:f0b9:4586]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835dd20519sm222156105e9.15.2026.02.12.08.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 08:55:53 -0800 (PST) Date: Thu, 12 Feb 2026 18:55:50 +0200 From: Vladimir Oltean To: WeiHao Li Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] arm64: dts: rockchip: Add USB2.0 PHY for RK3368 Message-ID: <20260212165550.mju3377fvphdsqoe@skbuf> References: <20250909132958.26423-1-cn.liweihao@gmail.com> <20250909132958.26423-3-cn.liweihao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250909132958.26423-3-cn.liweihao@gmail.com> On Tue, Sep 09, 2025 at 09:29:56PM +0800, WeiHao Li wrote: > RK3368 has one USB2.0 PHY with two ports, This adds device tree node for > it. > > Signed-off-by: WeiHao Li > --- > arch/arm64/boot/dts/rockchip/rk3368.dtsi | 29 ++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi > index 1b21787269..b09e431a64 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi > @@ -766,11 +766,40 @@ cru: clock-controller@ff760000 { > grf: syscon@ff770000 { > compatible = "rockchip,rk3368-grf", "syscon", "simple-mfd"; > reg = <0x0 0xff770000 0x0 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; This introduces a device tree warning. You cannot mix nodes with no unit address (io-domains) with nodes with a unit address (usb2-phy@700) on the same hierarchical level. You have to pick a format and stick to it. > > io_domains: io-domains { > compatible = "rockchip,rk3368-io-voltage-domain"; > status = "disabled"; > }; > + > + u2phy: usb2-phy@700 { > + compatible = "rockchip,rk3368-usb2phy"; > + reg = <0x700 0x2c>; > + clocks = <&cru SCLK_OTGPHY0>; > + clock-names = "phyclk"; > + clock-output-names = "usb480m_phy"; > + #clock-cells = <0>; > + status = "disabled"; > + > + u2phy_otg: otg-port { > + interrupts = , > + , > + ; > + interrupt-names = "otg-bvalid", "otg-id", > + "linestate"; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > + u2phy_host: host-port { > + interrupts = ; > + interrupt-names = "linestate"; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + }; > }; > > wdt: watchdog@ff800000 { > -- > 2.47.2 > >