From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F12613A86C; Thu, 12 Feb 2026 17:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770918595; cv=none; b=D7M4K48wpaS0xQjlZLkWRHbdyEUGsZHX1kqx2dgHy7HeSTGX++sX1Bn1paPvWpTTk+U+fr1KNZh6pvHDbu/o3PQZVunv2+cdYwU5/zsXiVrXORNTVZso2Drzxk855TadIyx7ZJ+z7vBXtpA8/AhF+DGoPXoJKqO1yR2+6lkddhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770918595; c=relaxed/simple; bh=DJULQCBIOYoYFZiOD7NY6M6YiAlcP9swo3j9cbL0Ko0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XLKGILdil2cV53WdnwzLmVqDJYve2hv9hBy+0P60ves38ON1JWfKnKAfu0l8MQBhCFZHZ8gHqoKEaYYzouFX9DGW6lFscgf1cLLsE4oCg7JObfC4i1xSp9G0NpONz9vr7ihWBXDUgfetW3JV7VIM/WdOr05aSmsuZ1G0+85tVN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rijWrhG0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rijWrhG0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9999BC4CEF7; Thu, 12 Feb 2026 17:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770918595; bh=DJULQCBIOYoYFZiOD7NY6M6YiAlcP9swo3j9cbL0Ko0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rijWrhG0tnaAVAfoSCnB9xzdbBMrS5yXtsfdp/xtvKUpOO2LaiLPDvMp6Wktzp04u uwaoxXhM/tPymGk5vVRWrF6dw47VA/kk4H1VV10IUsUAluwE3LjDgeaYwkVeeVpkTh k+mCoL3CTXGSZvMpbQUtYoSc/q409owNRgGAtWmDrbIcQyexMjZGTQLC+Awi5+9nCc eJ7yIMHPCDbvhhlrVowBQ/VbM0itkA2dy/CnFoalQG7IkCn10Zw32rNoqOXTVUFGND LtKdnhoOtiUZcmwxzlIaurwyQ1em2QrWD1OvVu5JXirg4Lj4nw8EGVYaAGIXDTQXCv TRuFmfTs0IkjQ== Date: Thu, 12 Feb 2026 09:49:10 -0800 From: Eric Biggers To: Arnd Bergmann Cc: David Howells , Lukas Wunner , Ignat Korchagin , Herbert Xu , "David S. Miller" , Jarkko Sakkinen , Arnd Bergmann , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x509: select CONFIG_CRYPTO_LIB_SHA256 Message-ID: <20260212174910.GC2269@sol> References: <20260212102102.429181-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260212102102.429181-1-arnd@kernel.org> On Thu, Feb 12, 2026 at 11:20:55AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The x509 public key code gained a dependency on the sha256 hash > implementation, causing a rare link time failure in randconfig > builds: > > arm-linux-gnueabi-ld: crypto/asymmetric_keys/x509_public_key.o: in function `x509_get_sig_params': > x509_public_key.c:(.text.x509_get_sig_params+0x12): undefined reference to `sha256' > arm-linux-gnueabi-ld: (sha256): Unknown destination type (ARM/Thumb) in crypto/asymmetric_keys/x509_public_key.o > x509_public_key.c:(.text.x509_get_sig_params+0x12): dangerous relocation: unsupported relocation > > Select the necessary library code from Kconfig. > > Fixes: 2c62068ac86b ("x509: Separately calculate sha256 for blacklist") > Signed-off-by: Arnd Bergmann > --- > crypto/asymmetric_keys/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Biggers - Eric