public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Taha Ed-Dafili <0rayn.dev@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-mentees@lists.linuxfoundation.org, me@brighamcampbell.com,
	skhan@linuxfoundation.org, "Taha Ed-Dafili" <0rayn.dev@gmail.com>
Subject: [PATCH v1 0/2] iio: dac: ad5504: fix voltage scaling and add missing bindings
Date: Thu, 12 Feb 2026 19:19:53 +0100	[thread overview]
Message-ID: <20260212181955.42724-1-0rayn.dev@gmail.com> (raw)

This series fixes the voltage scale calculation for the AD5504 DAC and
updates the devicetree bindings to support the necessary hardware
configuration.

Previously, the driver calculated the scale based on the VCC supply
voltage.

However, as confirmed by the datasheet (Rev. B) and discussion on
the mailing list [1], the AD5504 has an integrated precision reference,
and the output range is determined strictly by the state of the
R_SEL pin (0-30V or 0-60V).

To address this:
1. Patch 1 adds `adi,output-range-volts` (and GPIO equivalents) to the
   bindings to describe the hardware state of the R_SEL pin, along with
   other missing properties (vlogic, clear, ldac).
2. Patch 2 updates the driver to use this property for scale calculation,
   falling back to the 60V range if unspecified, while retaining the VCC
   regulator enable for power.

Link: https://lore.kernel.org/linux-iio/20260210121032.4630-1-0rayn.dev@gmail.com/ [1]

Taha Ed-Dafili (2):
  dt-bindings: iio: dac: ad5504: add output-range and missing gpios
  iio: dac: ad5504: use adi,output-range-volts for scale calculation

 Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml | 20 ++++++++++++++++++++
 drivers/iio/dac/ad5504.c                                  | 15 ++++++++++-----
 2 files changed, 30 insertions(+), 5 deletions(-)

Taha Ed-Dafili (2):
  dt-bindings: iio: dac: ad5504: add output-range and missing gpios
  iio: dac: ad5504: use adi,output-range-volts for scale calculation

 .../bindings/iio/dac/adi,ad5504.yaml          | 38 +++++++++++++++++++
 drivers/iio/dac/ad5504.c                      | 26 ++++++++-----
 2 files changed, 54 insertions(+), 10 deletions(-)

-- 
2.47.3


             reply	other threads:[~2026-02-12 18:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 18:19 Taha Ed-Dafili [this message]
2026-02-12 18:19 ` [PATCH v1 1/2] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Taha Ed-Dafili
2026-02-13  8:11   ` Krzysztof Kozlowski
2026-02-13 17:05     ` Taha Ed-Dafili
2026-02-13 17:07       ` Krzysztof Kozlowski
2026-02-12 18:19 ` [PATCH v1 2/2] iio: dac: ad5504: use adi,output-range-volts for scale calculation Taha Ed-Dafili
2026-02-12 20:15   ` Andy Shevchenko
2026-02-13 17:05     ` Taha Ed-Dafili
2026-02-15 18:03       ` Jonathan Cameron
2026-02-15 18:05     ` Jonathan Cameron
2026-02-16  7:21       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260212181955.42724-1-0rayn.dev@gmail.com \
    --to=0rayn.dev@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mentees@lists.linuxfoundation.org \
    --cc=me@brighamcampbell.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox