Re: [PATCH v2 0/4] soc: qcom: ice: Remove platform_driver support and expose as a pure library

Manivannan Sadhasivam
2026-02-10T13:54:29Z

On Tue, Feb 10, 2026 at 02:43:53PM +0100, Ulf Hansson wrote:
> On Tue, 10 Feb 2026 at 07:56, Manivannan Sadhasivam via B4 Relay
> <devnull+manivannan.sadhasivam.oss.qualcomm.com@kernel.org> wrote:
> >
> > Hi,
> >
> > This series removes the platform_driver support from Qcom ICE driver and
> > exposes it as a pure library to the clients to avoid race conditions with ICE
> > SCM call availability.
> >
> > Merge Strategy
> > ==============
> >
> > ICE patches (1,2) through Qcom tree and MMC/UFS patches (3,4) through respective
> > subsystem trees as there is no dependency.
>
> Just wanted to double check that this is really correct....
>
> The propagated error codes (or NULL) are changed in patch1/patch2, so
> is it really okay to pick the mmc/ufs patches (patch3 and patch4)
> independently?
>

Darn... No, I was being stupid here. Without patch 2, removing NULL check in
patches 3 and 4 will break the respective drivers, but patch 1 is fine though.

Thanks for spotting this. All patches should go at once through Qcom tree.

- Mani

> Kind regards
> Uffe
>
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> > ---
> > Changes in v2:
> >
> > * Added MODULE_* macros back
> > * Removed spurious platform_device_put()
> > * Added patches to remove NULL return
> >
> > ---
> > Manivannan Sadhasivam (4):
> > soc: qcom: ice: Remove platform_driver support and expose as a pure library
> > soc: qcom: ice: Return proper error codes from devm_of_qcom_ice_get() instead of NULL
> > mmc: sdhci-msm: Remove NULL check from devm_of_qcom_ice_get()
> > scsi: ufs: ufs-qcom: Remove NULL check from devm_of_qcom_ice_get()
> >
> > drivers/mmc/host/sdhci-msm.c | 10 ++--
> > drivers/soc/qcom/ice.c | 127 ++++++++++++++++---------------------------
> > drivers/ufs/host/ufs-qcom.c | 10 ++--
> > 3 files changed, 58 insertions(+), 89 deletions(-)
> > ---
> > base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> > change-id: 20260210-qcom-ice-fix-d2a3a045b32d
> >
> > Best regards,
> > --
> > Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> >
> >

--
மணிவண்ணன் சதாசிவம்