From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BB6C303A01 for ; Fri, 13 Feb 2026 07:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770968503; cv=none; b=rrS7xqw7kwRJanbr3Z7PNUk/wh/J1ELZXDSNXv7/1NWe/E7kk4EeuBCDFsaoIiWtfqlkJmMCjYPTQ0Zxgvi9CgeYN53FTrX5TA65aA5AP71wukCjPzF3DB5rufUSz4jNjE1IA5NAg8zOmA9C74GgIxCtppzEECVtnYkrjcnMSmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770968503; c=relaxed/simple; bh=z54r9BiaBtrqmr0blO/Ckj//Ge6xUZCgVsY4BmUDmdg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Auyz6HS1n0okGf3c0Zww9pxTqJUpIRbIoNFwPITZa8UqEY7CqYYRqJVau8Yc0kyXatgwJTDlOoMbnsVbdcise/zKK71obNjcj3r8y0Zqf5Ou91vs6uCXUU+BDHC/81bSvO2WVIRaeuFWyfiyRIqP7lX38ez4lZ5277HDS7kkWRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=loD0WOl4; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="loD0WOl4" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2aadac3e23dso2856505ad.2 for ; Thu, 12 Feb 2026 23:41:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770968501; x=1771573301; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=woL8X4enbfD6EKj11BHDMpTNsFBM7WNAUYZ7xSdzqf0=; b=loD0WOl4c5o5MW9+joogIjDQFRnBQt3gwc2IyKeeAL6OXWTUNU1HZFllu75EnSntmi IoTJr9O1Msy5o4RW86szvMgLx6cCYV6mP2sraQTf1C6liPap3AdLK3lIBW10qXQ8JxA1 Ir0Mt63PnqXWoyWKvcLnRXNeLUMbH4ilv7vvIngM+IzgDWSTFl0DYM/+e6ZQc9RGYOKd yONkGVBRQyELbkBb/Qmwmk7HJH+qdw6SsANMmzh2a1cTAD3ZzOYKByqmZvrEcqsUh6uU IJ0OHdsm4rFG131+24ejoTFl+QXWjDCsf4n8qQcNmfvWMGQlBH1VwkclV8r8gH14t5ld GkXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770968501; x=1771573301; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=woL8X4enbfD6EKj11BHDMpTNsFBM7WNAUYZ7xSdzqf0=; b=Wlk81o9ckSdBsbFGdgcuig3wRfWgcG4dWBNdcnXlwIWcsUP3Ou8cA1JFR7tuVB7FJE YiLf77ND9hIiL7NQ1bAUx0vhw+lyJDmQ7DcGc2nx7+aQnBvJkYebuP/hlVCYvmMX/pZ2 zOe7kpH3ganklULq43WgNMSzPjKtB8umO4o0UcxTyR/H5TxPCH7M0oKDZx1Q/FRvbxa7 TtOutH+fEwarZvR18N0/FLVh9QaoHqamIr96MBZfSAWil4JMrJ34F5M3c53j5fldFJN5 0RhMzMNykMArYZPa+1Zt7UAs18sQ4XA0pm/SGwT/xfirqzuEaiE+ITkSXL0eu7AkvF/r HisQ== X-Forwarded-Encrypted: i=1; AJvYcCUFXcSTpFBYMBnbBFM59DApQM4jCYn+Pu1vx6WQUPLLmuAo2tQ+KcAi/qAuNK+0ygo3RL4N8uuqb2r976Q=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm/qKSilhb+WC024Du2VUG43yXX6CZ0W+ewmlKi2NvN7wWCPEh uAyhjy54gDT4sev83AZ0+7/rZF4Ijof3TCt8X1bJTshyg+ofJqhlVC3U X-Gm-Gg: AZuq6aKHq49ICtCeTQpGrVPzQqE0spyOPc2FKKFkUjhnZfnYp/IYFL4uvM+fQ2urXtD u0F++qCrGLiJl4OdIFuge//CDTvsrVWw1aux4ikr3dRr5G8w1945/GMCbKkJ8KVEaELqjMtN2Vx cA7qL+Am5bNcGtKnmrWH46VA+bnjmKyTHWkSegWLpItCCQuxU5GgS3Q7RbqMelpui5oQ77fVXCO +luf4XXhXP1ejiPyRjNTlEY8WlXeeNd4OxjnIvjKr2atR6dIFVwwtAmBy1QdGmuk/Pb6GiN4IJF 8gZIBlIccHm9FinEwddJEaHt0Q08PcS6o+bU89ijtjktwTu3w90s/eLefuUXOeMvT6mHXuN6psh zBCAYjR3UCgnpyxBR9hKYjwNZ31KvZXJHT0NWkGbSaLLWTaRMDQb7n8APpqIssQPWS3lW530GUv 8/RVMJgcL+BO1F20TQ1AAj+sf+T+vB59uL9vsDrOjJlcnO3QbQEA== X-Received: by 2002:a17:902:fc45:b0:2a9:4316:7557 with SMTP id d9443c01a7336-2ab5057c597mr9850765ad.33.1770968500705; Thu, 12 Feb 2026 23:41:40 -0800 (PST) Received: from lima-ubuntu.hz.ali.com ([47.246.98.214]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ab2986efa0sm70939225ad.32.2026.02.12.23.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 23:41:40 -0800 (PST) From: Qing Wang To: syzbot+cff8e1b82d7911dd051c@syzkaller.appspotmail.com Cc: agruenba@redhat.com, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2) Date: Fri, 13 Feb 2026 15:41:35 +0800 Message-Id: <20260213074135.2389369-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <6978bb60.050a0220.c9109.001c.GAE@google.com> References: <6978bb60.050a0220.c9109.001c.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index e4356198d8d8..8c3d0a83cb98 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c @@ -346,16 +346,16 @@ void gfs2_remove_from_journal(struct buffer_head *bh, int meta) struct gfs2_trans *tr = current->journal_info; int was_pinned = 0; - if (test_clear_buffer_pinned(bh)) { - trace_gfs2_pin(bd, 0); - atomic_dec(&sdp->sd_log_pinned); - list_del_init(&bd->bd_list); - if (meta == REMOVE_META) - tr->tr_num_buf_rm++; - else - tr->tr_num_databuf_rm++; - set_bit(TR_TOUCHED, &tr->tr_flags); - was_pinned = 1; + if (test_clear_buffer_pinned(bh) && bd) { + trace_gfs2_pin(bd, 0); + atomic_dec(&sdp->sd_log_pinned); + list_del_init(&bd->bd_list); + if (meta == REMOVE_META) + tr->tr_num_buf_rm++; + else + tr->tr_num_databuf_rm++; + set_bit(TR_TOUCHED, &tr->tr_flags); + was_pinned = 1; brelse(bh); } if (bd) {