public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Rob Herring <robh@kernel.org>,
	linux-gpio@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alexander Stein <linux@ew.tq-group.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible
Date: Fri, 13 Feb 2026 09:29:14 +0100	[thread overview]
Message-ID: <20260213092914.79790cb9@bootlin.com> (raw)
In-Reply-To: <89c0dd51-fdd5-4368-b5f5-615143ffd166@kernel.org>

Hi all,

On Fri, 13 Feb 2026 08:31:21 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> > 
> > Or is the issue just with the name of the compatible I used being
> > called "gpio-aggregator"?  
> 
> No, the issue is that there is no hardware you are trying represent in DTS.

Except if you have a piece of hardware that invert the gpio line.

In that case you need to set GPIO_ACTIVE_LOW somewhere.

The aggregator allows to describe this line inverter.

Of course, if the gpio is connected to a hardware component handled by the
kernel, the DT node describing this hardware can set the flag.

The issue is for GPIOs that are just GPIOs and should by a user-space
application as GPIOs.

Some bindings exist for GPIO and do not describe the hardware but the
feature. For instance:
https://elixir.bootlin.com/linux/v6.18/source/Documentation/devicetree/bindings/trigger-source/gpio-trigger.yaml
https://elixir.bootlin.com/linux/v6.18/source/Documentation/devicetree/bindings/power/reset/gpio-poweroff.yaml
https://elixir.bootlin.com/linux/v6.18/source/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml

Can we consider the gpio-aggregator describing the wires that should be
grouped together.

Industrial board can have some GPIOs grouped together and used as inputs or
ouputs of this industrial board.

As output they command an external system. As input, they get feedback from
this system.

gpio-aggregator describes those lines.

In that sense, it describes hardware.
Maybe the "gpio-aggregator" name doesn't reflect that and a compatible such as
"gpio-equipment" could make sense.


Best regards,
Hervé

  parent reply	other threads:[~2026-02-13  8:29 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11  8:13 [PATCH v2 1/2] dt-bindings: gpio: add gpio-aggregator binding James Hilliard
2026-02-11  8:13 ` [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible James Hilliard
2026-02-11  9:47   ` Bartosz Golaszewski
2026-02-11  9:50     ` Geert Uytterhoeven
2026-02-11 10:38       ` Bartosz Golaszewski
2026-02-11 10:48         ` Krzysztof Kozlowski
2026-02-11 11:00           ` Bartosz Golaszewski
2026-02-11 10:13     ` Krzysztof Kozlowski
2026-02-11 10:36       ` Bartosz Golaszewski
2026-02-11 10:42         ` Krzysztof Kozlowski
2026-02-11 10:44           ` Krzysztof Kozlowski
2026-02-11 21:47         ` Rob Herring
2026-02-11 21:49           ` James Hilliard
2026-02-12  7:18             ` Krzysztof Kozlowski
2026-02-12 19:16               ` James Hilliard
2026-02-13  7:31                 ` Krzysztof Kozlowski
2026-02-13  8:02                   ` James Hilliard
2026-02-13  8:21                     ` Krzysztof Kozlowski
2026-02-13  8:29                   ` Herve Codina [this message]
2026-02-13  8:49                     ` Krzysztof Kozlowski
2026-02-13 23:03                       ` James Hilliard
2026-02-11  8:17 ` [PATCH v2 1/2] dt-bindings: gpio: add gpio-aggregator binding Krzysztof Kozlowski
2026-02-11  8:19   ` Krzysztof Kozlowski
2026-02-11  8:28     ` James Hilliard
2026-02-11  8:44       ` Krzysztof Kozlowski
2026-02-11 17:01         ` James Hilliard
2026-02-12 14:49           ` Geert Uytterhoeven
2026-02-12 16:53             ` James Hilliard
2026-02-12 19:54           ` Rob Herring
2026-02-12 21:22             ` James Hilliard
2026-02-13  8:24               ` Geert Uytterhoeven
2026-02-13 18:34                 ` James Hilliard
2026-02-16  9:05                   ` Geert Uytterhoeven
2026-02-19 18:00                     ` Linus Walleij
2026-02-19 18:29                       ` Rob Herring
2026-02-19 22:14                         ` Linus Walleij
2026-02-19 22:28                           ` James Hilliard
2026-02-19 23:00                             ` Linus Walleij
2026-02-19 23:06                               ` James Hilliard
2026-02-19 23:12                             ` Rob Herring
2026-02-20  4:57                               ` James Hilliard
2026-02-20  8:24                                 ` Linus Walleij
2026-02-20 11:33                                   ` Bartosz Golaszewski
2026-02-13 14:34               ` Rob Herring
2026-02-13 22:49                 ` James Hilliard
2026-02-16  9:10                   ` Geert Uytterhoeven
2026-02-19 17:57                 ` Linus Walleij
2026-02-20  8:17                   ` Herve Codina
2026-02-20  8:35                     ` Linus Walleij
2026-02-20  9:15                       ` Geert Uytterhoeven
2026-02-20 13:07                         ` Herve Codina
2026-02-20 13:28                           ` Geert Uytterhoeven
2026-02-11  8:25 ` Geert Uytterhoeven
2026-02-11  8:34   ` James Hilliard
2026-02-11  9:47     ` Geert Uytterhoeven
2026-02-11  9:57       ` Herve Codina
2026-02-11 10:01         ` Geert Uytterhoeven
2026-02-11 10:58           ` Herve Codina
2026-02-11 13:30             ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260213092914.79790cb9@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=james.hilliard1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox