From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C67D3128C0 for ; Fri, 13 Feb 2026 10:01:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770976865; cv=none; b=twPyuCPgqn2I3HQKKZ1OvXWiL8ylVfp10H3fveL0KHAlPa7OS7YBQxRWA2Ht1S1Pc4Byf2I6bC6Zj4JzSjTn3LHDD9uch1jFayCYvaekAa57DULgLRU6bZ8WxUnWyJ4erIYYdwdqNOoiXT8X4OdNzQJeOE0HZNIYc2J0fM1DO88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770976865; c=relaxed/simple; bh=OdRA4DG5OOf+5AnhZfSl4AISrH0uQ/SUrYRi2Dd9XK4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bTAXIXTLEMUwyMXyfE7LNQMeceFfCUUm/vC9TlVV2theE4k7gEir8WaaTbd8HG50d0wphPSJgby2POTjF0+9HtT4fNIr2ZC1PuSi0EztaWh6yWdS6QTEEs2LKNv7ZNBKEXo0K5nd8oP4eBiwge+kMKF/gJkiHyMtziPnpRaKXCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XC4t+eoV; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XC4t+eoV" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2aad9b03745so3893755ad.0 for ; Fri, 13 Feb 2026 02:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770976863; x=1771581663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1mXtU2ce2k7fXz2CpTEP52iCA/+RFfW2aqzRrKiZWDo=; b=XC4t+eoVy2aVvug+Ik3DsokepJqLP7H8SlpvnRtrcywI7YDH/mMJlKehSyZtD138P7 /5GNvUh1etZJ8QSMavJZwEkI9SGzcU3IeclCSYjSmTtZ7b10v60jNeKdOj5VXZvoK/MQ HEkwE1tOB4bUex5eY4/Og5Pu4H8PHL50+N2wWNQoMLixcMaBUmYRXbrtlRpbRlxZoibu nI9uNlITRiWxRrJoUku9U7ykdI7PLBR+idZ6QUSbdjOQTGsvUXeBYi7Et73M9d+oX+mT AHp1+i+phqIJfxZ/dfR459MoXv1etnDmN9F5dhyriRKZFhV9RQOzYTc2GuyOmYaP428D r2GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770976863; x=1771581663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1mXtU2ce2k7fXz2CpTEP52iCA/+RFfW2aqzRrKiZWDo=; b=MK00gYgwTru/H0v171Z+agxUTUmqDfZ/W71WNWsQih1+xq7FpXph+3BXMJELxWaZCO MTm+XKQNzh1tPEU9rC3SDzxKwLkjNko81ZXQOWo30xiutLTjbIJ2Qn3ZeHJbYemgjLH4 nUY+2C/bC5qmdtq72ThDy+F1sW63Le9iRntIYKJ8L0gxp7bAChXAcCgkUt1aXZneR7uv xzSP4SgeB3hH42GjukXg38FSx7AtBWfFcZd0ummqeYfn6QBPr8ieMrykyFKh3j4IlGEj cKRbQkCGiPKwTXzlkxrjBHWv+GbXxxBToZOGrt+InLINW8+ffvXoLiDXKLODegDp7FJp SFtg== X-Forwarded-Encrypted: i=1; AJvYcCUaC/e/2/NNUhkpijEj40+vGkkxGPeyiCM73wMErk8L8s+Pz+d77nJIVOVwuNy9HQ6oU1hj7QogH3iY53E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/aJXD3Wwlr085RdP3t0a5+rUkd+PkcxoCe1StI5HGZFfF9yX4 TPfXGZich56agX14VyXInawoubMXthS1OZl/VUfGZKbzy7KJAAsg8/mK X-Gm-Gg: AZuq6aKK+13kwd7ytBNkzEgr9/TyqIJkwCtT7gWsmCDJ/63h74JigtoZJXK7/6ZU2p9 5ZY/BJkRSwEHnyg9nFl2MMn70pFAQVhHyebWojkPtpfK23VxpzgoLpLAZJevzoWhGNuBlHkjeMV SlBdUB0WU5qdKXjr3pSYm4pwI7N/g7/zMdZOR20nlCg4W0StpCiSWgZWE0E8QVVuX4q+5YlLKrU rZXeFIJdqTjchqTRMUfYU2oQR4iFQxzQQ9SrtwLqYH38NwdyP59tI3pDPMy5ZcpgZwC6H0+SBj7 KVgMsGS1MMYaursIhK0nsU5zhHVgCzlf5zUEh8bxMLSkawwS8V6F+V3DB5yhK2iySGQT4mee5b1 NROgMISC5IcKICtcavEgj8dPWvrxK/LFMiTHRuFbWPJ1f6en0wU69XQ3p/5cfHyyXPYA5Dl8hVR mYLnYaapbEdjWFZaSCVEFVe+gNw7CjNpyvm6cG/oRgvBTcwQ7+FA== X-Received: by 2002:a17:903:3bcf:b0:2aa:e238:e20c with SMTP id d9443c01a7336-2ab4ffa4ecbmr14086605ad.19.1770976863205; Fri, 13 Feb 2026 02:01:03 -0800 (PST) Received: from lima-ubuntu.hz.ali.com ([47.246.98.214]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ab29998c45sm77240755ad.88.2026.02.13.02.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 02:01:02 -0800 (PST) From: Qing Wang To: syzbot+cff8e1b82d7911dd051c@syzkaller.appspotmail.com Cc: agruenba@redhat.com, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2) Date: Fri, 13 Feb 2026 18:00:58 +0800 Message-Id: <20260213100058.2457892-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <6978bb60.050a0220.c9109.001c.GAE@google.com> References: <6978bb60.050a0220.c9109.001c.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index e4356198d8d8..f459ad89b641 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c @@ -350,11 +350,13 @@ void gfs2_remove_from_journal(struct buffer_head *bh, int meta) trace_gfs2_pin(bd, 0); atomic_dec(&sdp->sd_log_pinned); list_del_init(&bd->bd_list); - if (meta == REMOVE_META) - tr->tr_num_buf_rm++; - else - tr->tr_num_databuf_rm++; - set_bit(TR_TOUCHED, &tr->tr_flags); + if (tr) { + if (meta == REMOVE_META) + tr->tr_num_buf_rm++; + else + tr->tr_num_databuf_rm++; + set_bit(TR_TOUCHED, &tr->tr_flags); + } was_pinned = 1; brelse(bh); }