From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA412283FDB for ; Sat, 14 Feb 2026 02:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771036714; cv=none; b=MVKuYN5hURzqQNAhzcIM+Td1xOq6X+4PY6rauhD9YbLMLgl+MCQ24O9hUZcnFsEakbNjx3Cn8AcFJQXANxSnm00NEbEQfh5g4Fmz2leaFxX9Bn3xbtp0IPwYaFZfERawu2ZdyZCc1CAgpoz613PdmumTKrcjQp9+nV+y9e9XAvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771036714; c=relaxed/simple; bh=LX+jgVLAJJI+bgvDumhNI5og1UdPfr3cpthR3+NZTuI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ul3H7QPIEADuvjtMP4pSQRV8T8hf+GAdlwFzjXwqELLafQ2Z19r3F3Lnj9OABpnvavAv1EXko/OB94yHntmaJqwe8P1gk1MwYIwhgH65tFAk0bAhORTEtoQm0mFJlEpMybldp4ZT1o9wKf8g/1zeg0Ky/QHkVgQyceQF6UMhi8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aWH/rgDN; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aWH/rgDN" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771036711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SRA0PW/CLHVVDqNCVWQE4q8KgPW8Hb1oRAscCsU9AWY=; b=aWH/rgDNCvqRtisIRzbd/1S2iXyOyQSnDvXQJBqhVHjiOhYybL4735aq2SZjekhcl3tIwY upwXPDaRX22no2M5bkvjtGYoEfqKB0p0+vPfAnCTtr28ENFODPTvTp/Zpexs46KClSDEg6 bkL5H65bOUYZ5vMBUJ3xQ4rFakRxGOU= From: Kunwu Chan To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Conor Dooley , Alexandre Ghiti , Anup Patel , Atish Patra , Zong Li , Deepak Gupta , Zhouyi Zhou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: [PATCH RESEND 1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue Date: Sat, 14 Feb 2026 10:38:03 +0800 Message-Id: <20260214023804.677127-2-kunwu.chan@linux.dev> In-Reply-To: <20260214023804.677127-1-kunwu.chan@linux.dev> References: <20260214023804.677127-1-kunwu.chan@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Fix two minor issues in XIP_FIXUP_OFFSET macro: - The comment describes the fixup formula as "reg += CONFIG_PHYS_RAM_BASE - _start", but the actual assembly code subtracts _sdata, not _start. Fix the comment to match. - Replace spaces with a tab for the "add" instruction to keep consistent indentation with surrounding lines. Reviewed-by: Zhouyi Zhou Signed-off-by: Kunwu Chan --- arch/riscv/include/asm/xip_fixup.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/include/asm/xip_fixup.h b/arch/riscv/include/asm/xip_fixup.h index f3d56299bc22..56db595b0e14 100644 --- a/arch/riscv/include/asm/xip_fixup.h +++ b/arch/riscv/include/asm/xip_fixup.h @@ -16,10 +16,10 @@ * * The start of data in Flash is _sdata and the start of data in RAM is * CONFIG_PHYS_RAM_BASE. So this fix-up essentially does this: - * reg += CONFIG_PHYS_RAM_BASE - _start + * reg += CONFIG_PHYS_RAM_BASE - _sdata */ li t0, CONFIG_PHYS_RAM_BASE - add \reg, \reg, t0 + add \reg, \reg, t0 la t0, _sdata sub \reg, \reg, t0 .endm -- 2.25.1