From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC9C30BF69 for ; Sat, 14 Feb 2026 18:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771093201; cv=none; b=TeqeAce0YbTS2ZMCeUd1bGF1mxvJ4+8wIjOn1dSXxomRtBPMp64OlRe5yUz1p5yp9wYxY/xT6ap067KZq+sxbdmMTCKqoez9nfGPK0TNTSdg3uyzFb2iFJRYdPDac/IZFylauu1pyH1EbWYIXJIdHLYHKTjw90K5muWAn7FfrTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771093201; c=relaxed/simple; bh=PfOygATA+OcMrjg0RKh13yWvltWb+BH/5KX/xERXXEY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gp+c1EBNqZCCjEf+6ZE04c8o6qFsZpzmAcnVvj9u5cLyU7g5tqwQHFvQSRctWaIoiFogiJoVwvRPMpD8i93op3vEFzD+69GNNcvsM73M/4FN6LnG8XiSDqMyG80hT/MqpD1D1E8SE2VmS9CHrcohAsUmxG+/S/gPJ8MN2wyb0Bw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R0f2/QQV; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R0f2/QQV" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-2a8a7269547so18699785ad.0 for ; Sat, 14 Feb 2026 10:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771093200; x=1771698000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aN6kFZ271/Vjt9LuqJxvnwus9JIfHbc3XvmUWyOckqs=; b=R0f2/QQVFZTGJj4H1FmLzqu1IkLe9gxNYzR5+WFZWeOOEJ5XRcGlc99gC9+abkefeU byoSOpwjRTO0zKUfmBUQrxUaahEEM3DRJ0YeYdT+jIbynFY5jrPeUaVXGzxSn5froMtP AiXMwAmJNsIjpDX77ZF8KOi0kBsqjBzey0uWweJun3HEheZatndnFwQ2cSK4ISy0izQW dmMxJznMCgUP6v1orknIxx+khZCRrENRki9ynwtE/quIB/RnBu7XK/IsyD2urTI0QDkj 8WZdNuOPZEQkhdsV1J8wEYGErTVQwiQ2y1pxN1rHhpNbakeFxNMmo/HXtP8o1weWnf57 rmFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771093200; x=1771698000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aN6kFZ271/Vjt9LuqJxvnwus9JIfHbc3XvmUWyOckqs=; b=CC92ICzxZWUpx93Q0gVpH5mN1Kf5xiXqQFksOPD8ygZr3B781hGO3us0Bxxbe5ImHp CpFCtqvtx3b6vBBNR5cVid/yBqp3IVso/JKAbjNjtatTyib1uTH15CAkbZyGUORJlSim CFTiXeHIm7/Ne4TQDQMErjUviyrd36WNCbKXQEEdjYJQmAco6geF6RwlxaqqFRD0q9xL Omwj/PJPS2cL/GSFuIiETTJt5gcET0IyJ2OQekDtSdonKNn8CXDGid86y565sFHhi4v3 HzAX0hjnO/8UILqPcZzrWQlpDdp5CYzDyxq6r3DxfnLSsrEONJLlGeK02TjgCotGcB5v T/xg== X-Forwarded-Encrypted: i=1; AJvYcCW56ygUnl7sNYdPhEig8vi80+peCMkmo9IhEb1CDuEoqyXzytQrIk2PoDPH5iyd0SAW0U9WaKs4oCgKGy0=@vger.kernel.org X-Gm-Message-State: AOJu0YwzI5B0r3vk2+PUvFxE1xo35L/7DucAlV1kEGI3PnRkqXba4QzU QMfl1h9JeD7bl8xfqmvUcNZLGPBSQNZMCFN4zlCqreHx9z2EE2h574WO X-Gm-Gg: AZuq6aIWPwmAcEdtfkjhjgZbFnucpBEjBD4YQIEQLjGhFu+6Er/9JjVz58Gea29QVlg iymSev5+5bpBGkLPuAmFCK9vwRotLOanCcB0ET4N6S0IhatHzwIzO1AE9yhnSVir+sQ2Nl5S2vw vyMCqpDJl2P7dZcEFFPptn1KSygwUlTTD+cK2Ob05vjvLjwbTcX5soMFisRDWgdrDMpxHyujs0X SiMM8xEnBfTFJ+3OUi2bMSIAnWHdbIgthSksDaRYMDXpDAuS9u8hUxIctl1OJH+xec0CwwpmK2v BVd8Vv9tHaGrFgspi7cUNvPLIT1Qf+J7yODTUAC/IHzxvv3i/WXq1NVeNOkUHXoXvnSaqPz4zAf PnG5iXDfIOpGiV09zDGxBl2UGl/G13SLppx7qCCa1dzOnT0JXyfnu2l/RL2qaWngTfpvJvMJjBk YvgLvMRf5a81VT1y8pNxk= X-Received: by 2002:a17:902:dacd:b0:2aa:f2f3:bca1 with SMTP id d9443c01a7336-2ab4cf4f72amr54134195ad.9.1771093199695; Sat, 14 Feb 2026 10:19:59 -0800 (PST) Received: from rockpi-5b ([45.112.0.78]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a9d5e06sm28406615ad.50.2026.02.14.10.19.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Feb 2026 10:19:58 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v8 3/9] thermal/drivers/exynos: Remove redundant IS_ERR() checks for clk_sec clock Date: Sat, 14 Feb 2026 23:49:00 +0530 Message-ID: <20260214181930.238981-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260214181930.238981-1-linux.amoon@gmail.com> References: <20260214181930.238981-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove unnecessary IS_ERR() checks for the clk_sec clock, the clk_enable() and clk_disable() functions can handle NULL clock pointers, so the additional checks are redundant and have been removed to simplify the code. Reviewed-by: Lukasz Luba Signed-off-by: Anand Moon --- v8: None v7: None v6: Add Rb - Lukasz and Fix the typo in the subject v5: None v4: drop IE_ERR() for clk_unprepare() as its handle in earlier code. v3: improve the commit message. --- drivers/thermal/samsung/exynos_tmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index aa0726b33c84..5f017a78f437 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) mutex_lock(&data->lock); clk_enable(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_enable(data->clk_sec); + clk_enable(data->clk_sec); status = readb(data->base + EXYNOS_TMU_REG_STATUS); if (!status) { @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) data->tmu_clear_irqs(data); } - if (!IS_ERR(data->clk_sec)) - clk_disable(data->clk_sec); + clk_disable(data->clk_sec); clk_disable(data->clk); mutex_unlock(&data->lock); -- 2.50.1