From: Greg KH <gregkh@linuxfoundation.org>
To: Ofek Almog <ofekalm100@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Ethan Tidmore <ethantidmore06@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
s9430939@naver.com, architanant5@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range
Date: Sun, 15 Feb 2026 07:52:22 +0100 [thread overview]
Message-ID: <2026021552-animate-nest-26c6@gregkh> (raw)
In-Reply-To: <CAKXVhcLWrTq3vLyoyL7r_J-+3q1SZUtmaVYsC-ZHvYPUas36Lg@mail.gmail.com>
On Sat, Feb 14, 2026 at 09:23:45PM +0200, Ofek Almog wrote:
> (Resending as plain text, apologies if you received a previous HTML version)
>
> Hi Andy, Ethan,
>
> Thank you both for the review.
>
> Regarding the fsleep() suggestion - understood, that clearly seems
> like the right helper to use here.
>
> Regarding the completion mechanism logic - I completely agree that the
> current infinite loop polling is fragile. However, as this is my very
> first contribution and I do not have the hardware to verify logic
> changes, I am hesitant to refactor the synchronization mechanism
> blindly.
>
> Would you prefer I send a v2 that strictly switches to fsleep() as an
> incremental improvement over msleep(), or should I drop this patch
> altogether until someone with the hardware can refactor the logic
> properly?
Please drop it, see the archives for why (you need someone with the
hardare and specs to figure out what needs to be done.)
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-15 6:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 17:31 [PATCH] staging: rtl8723bs: replace msleep with usleep_range Ofek Almog
2026-02-14 18:11 ` Ethan Tidmore
2026-02-14 18:24 ` Andy Shevchenko
2026-02-14 19:23 ` Ofek Almog
2026-02-15 6:52 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 19:54 [PATCH] staging: rtl8723bs: Replace " AyushMukkanwar
2026-03-19 20:23 ` Ethan Tidmore
2026-03-20 7:42 ` Andy Shevchenko
2026-03-14 5:11 [PATCH] staging: rtl8723bs: replace " Marcos Andrade
2026-03-14 20:56 ` Ethan Tidmore
2026-03-09 0:40 sluisr
2026-03-09 13:33 ` Bryant Boatright
2026-03-09 16:01 ` Greg KH
2026-02-10 5:58 Vo Thanh Cong
2026-02-10 6:37 ` Greg Kroah-Hartman
2026-02-09 12:07 Ethan Lam
2026-02-09 12:35 ` Greg KH
2026-02-08 12:15 Miguel Angel De la Vega Rodriguez
2026-02-08 14:35 ` Greg Kroah-Hartman
2026-01-10 20:44 Işıkhan IŞIK
2026-01-11 12:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026021552-animate-nest-26c6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=architanant5@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ofekalm100@gmail.com \
--cc=s9430939@naver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox