From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D4742BD01B for ; Tue, 17 Feb 2026 19:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771357688; cv=none; b=it49YbuXlb+6qEAfiMwFOV63KnL4WOy123Pb5ZecG8mwdgBhhYp5mTZcttCxxnetNIpu7Mm92oUk3xwt8qOlATFU33FmyOMtfGbutHRFPkxC0sq7BkN4X7Flac4GI9Yg7W110ZN326Cxkuz1HiDy4Hz5q4ZhCsNV/piu/bK7sSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771357688; c=relaxed/simple; bh=D5f8/Gr/O0b9inTSR3XNvVfVH3KXirsPTUvKD2MFk1w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HG81I9uvRI/n+uYeMcw0hXuedTKd5LIIXvDwZsBZz5DwI0ODidY0JqiDc9guku/w+0sCsNxUgia6EZIIRq0AqcJ7Xavr9SSgQBc1YsV1ZIyWOm1USwE1dIarH7xye9pviiA4Vc27RV4zgKiP/wEiWkAd1GVdCdmcSdSgnq2gTTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JRWMCFSF; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JRWMCFSF" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4836f363ad2so51417975e9.1 for ; Tue, 17 Feb 2026 11:48:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771357686; x=1771962486; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DUY1ecNXu12uPW+cfzylhAHwZ7NpxvHQxRZIOvn8UBY=; b=JRWMCFSF3R7zwLd1WXGilqBpVLYpJKoy2wcob03v1JWRqYZ6BNXGlkUs6aCfSBMxZN vSUoJ2o5MIWeItfOsqRsdiyccEPwEznOizg47EZe89h7OHShrLt/YK8IPrMKljCE0Y0K r5Nzja8bcR2ruNjEHt8az5yXleesJZ0z3uwDmDPBvl3wuxXHC2OabqxzMZZT+K8bLO6D Wnn1xcp6SKa7bXaODmiHWW8ytWhwGBuqZJ4cT9taxhbkEqoKW1mb5SAylTF+XoEoIWWN 0GVedh1dj/EnIfdOUgNDcPCeAtm99DUYcdu0nG9TwoZowZIYIY9FK511jhC11V5/+seS oZZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771357686; x=1771962486; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DUY1ecNXu12uPW+cfzylhAHwZ7NpxvHQxRZIOvn8UBY=; b=X6Di96BZK17MId0qqfeJ0wo6Vh3pi0yJcWJ/HRWDnoQCy5aYiAHnc/X0z8frcGubO5 5ryymwpvLHBwRESGqECex3v7AjsD86cQe+jX+DGIYNfBaBMbVcYJs53ZY1dh2fHRPbXi TFcCQNLo+jNnEzOohj4riJI5VAL7O2FO/DU7cqb6pA1s5fE9hCbqMOyy+X4H7nxaGAQp l9S1OZm2eHxYCAz4eG7zKHqtmW+l2FZmSZfGMbKv2za1RPbZr+LvITWzg3Os1ui+dkbh HsJZdQb1vSp6NqBbk4At/8921k8mVcstNVFmeBSva8lxZ8NNpMXDFpaai/Rya51dIxTd M92Q== X-Gm-Message-State: AOJu0YxYFUSfji61KrziGj8Au+C0nUDaYbFhQtjfQgS2Vr+8vIsIRUHB zxrvX739UEjc/Q7gRdqbiMKps/WLg8va4YrJ9n3qAl7vIZKIBEMjqBhD X-Gm-Gg: AZuq6aINnuAfsZCtkQcJtxJtuaR4x/Q28bw5FUjE2yXeKLsBQj1BR8bfhkmfoX2nzX3 MdHz+b5RvgTMqgNER5fLd7OM0MKbGti2WKFL4J/cum92uaCUTObZ0EDcX+YzmNeFBevGIgxuMl/ +zbGdVOen2mlTks3LiB1TqG2QefM1APV/0YJWfQKX+iXXlhb2GjTcSTVL4u5H7y+6PZxe4J4LEp pXK4q4TPk6nmPHfwMyi1uV0FSENVJkFQ3QMBrnFJNdHd0QvAOJKmUsgSdXsSAsKOQhjNgzV5OBw T7P6YWF+1goqovIVOTN9bo1GJUx+9+9rwMBHkRWX4n0NWeXiwu3gcHDuUkQekg2oy5bdlnLT6DN 8VxgL75SuhsWz45VQD2xWBzqQkB5EDrwWvpEVaCUg+3OBmEuv0nDfyDjeK2YJ2//2KdtgHLL5KQ WkWIVqjIZXREbpU8b8rGEjEb3yg7xpQnYR1tOo+FffcBX7wPfaFFcFLLD4lwW9lPoWUYqzveEMr plaim7pRHBawaOe9ZLV X-Received: by 2002:a05:600c:8706:b0:480:6999:27ec with SMTP id 5b1f17b1804b1-48373a0b559mr240434665e9.13.1771357685486; Tue, 17 Feb 2026 11:48:05 -0800 (PST) Received: from rozandragon.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4837b68e5adsm338885875e9.9.2026.02.17.11.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 11:48:04 -0800 (PST) From: David Carlier To: Tejun Heo , David Vernet Cc: linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] tools/sched_ext: scx_central: fix CPU_SET and skeleton leak on early exit Date: Tue, 17 Feb 2026 19:48:00 +0000 Message-ID: <20260217194800.87403-1-devnexen@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use CPU_SET_S() instead of CPU_SET() on the dynamically allocated cpuset to avoid a potential out-of-bounds write when nr_cpu_ids exceeds CPU_SETSIZE. Also destroy the skeleton before returning on invalid central CPU ID to prevent a resource leak. Signed-off-by: David Carlier --- tools/sched_ext/scx_central.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/sched_ext/scx_central.c b/tools/sched_ext/scx_central.c index a6dfd45de70c..39f21b00a208 100644 --- a/tools/sched_ext/scx_central.c +++ b/tools/sched_ext/scx_central.c @@ -74,6 +74,7 @@ int main(int argc, char **argv) u32 central_cpu = strtoul(optarg, NULL, 0); if (central_cpu >= skel->rodata->nr_cpu_ids) { fprintf(stderr, "invalid central CPU id value, %u given (%u max)\n", central_cpu, skel->rodata->nr_cpu_ids); + scx_central__destroy(skel); return -1; } skel->rodata->central_cpu = (s32)central_cpu; @@ -109,7 +110,7 @@ int main(int argc, char **argv) SCX_BUG_ON(!cpuset, "Failed to allocate cpuset"); cpuset_size = CPU_ALLOC_SIZE(skel->rodata->nr_cpu_ids); CPU_ZERO_S(cpuset_size, cpuset); - CPU_SET(skel->rodata->central_cpu, cpuset); + CPU_SET_S(skel->rodata->central_cpu, cpuset_size, cpuset); SCX_BUG_ON(sched_setaffinity(0, cpuset_size, cpuset), "Failed to affinitize to central CPU %d (max %d)", skel->rodata->central_cpu, skel->rodata->nr_cpu_ids - 1); -- 2.51.0