From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alisa-Dariana Roman <alisa.roman@analog.com>
Cc: "Nuno Sá" <noname.nuno@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Harshit Mogalapalli" <harshit.m.mogalapalli@oracle.com>
Subject: Re: [PATCH v1 1/1] iio: adc: ad7192: Revert "properly check spi_get_device_match_data()"
Date: Wed, 18 Feb 2026 09:58:20 +0000 [thread overview]
Message-ID: <20260218095820.00005750@huawei.com> (raw)
In-Reply-To: <aZWI-80-K7xfuEBY@smile.fi.intel.com>
On Wed, 18 Feb 2026 11:40:11 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Feb 18, 2026 at 09:12:03AM +0000, Nuno Sá wrote:
> > On Tue, 2026-02-17 at 17:06 +0200, Andy Shevchenko wrote:
> > > On Tue, Feb 17, 2026 at 01:47:59PM +0000, Nuno Sá wrote:
> > > > On Tue, 2026-02-17 at 09:05 +0100, Andy Shevchenko wrote:
>
> ...
>
> > > > I'm ok with this but as long as we get some consistency agreed on. So far,
> > > > IIRC, the policy was to check for the NULL case even for the cases where that
> > > > was not possible to happen.
> > >
> > > Is it kernel-wide policy?
> >
> > Nope... Just IIO IIRC. Actually, I'm pretty sure we had patches in the past
> > just adding the check.
>
> Like you said we need clearer policy.
>
> > But again, I'm fine with the above as long as we are consistent from now on.
>
> Exactly!
> Jonathan, David, others?
As long as no compilers or static analyzers trip up on it and start spouting false warnings,
I'm fine with not checking these. I'm not sure I'm bothered about going through the tree
removing the checks though. This one is so small I don't mind if it gets copied
into new drivers. If this is all that needs tidying up I'll tweak it whilst applying.
Jonathan
>
next prev parent reply other threads:[~2026-02-18 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 8:05 [PATCH v1 1/1] iio: adc: ad7192: Revert "properly check spi_get_device_match_data()" Andy Shevchenko
2026-02-17 13:47 ` Nuno Sá
2026-02-17 15:06 ` Andy Shevchenko
2026-02-18 9:12 ` Nuno Sá
2026-02-18 9:40 ` Andy Shevchenko
2026-02-18 9:58 ` Jonathan Cameron [this message]
2026-02-20 10:55 ` Jonathan Cameron
2026-02-20 11:05 ` Andy Shevchenko
2026-02-22 13:22 ` Jonathan Cameron
2026-02-23 8:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218095820.00005750@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=alisa.roman@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox