* [PATCH 3/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support
@ 2026-02-18 10:19 Ronald Claveau
2026-02-18 10:20 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Ronald Claveau @ 2026-02-18 10:19 UTC (permalink / raw)
To: linux-amlogic
Cc: Ronald Claveau, Neil Armstrong, Jerome Brunet, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jian Hu, Xianwei Zhao, linux-clk, devicetree, linux-kernel
Add PLL for the clock controller of the Amlogic T7 SoC family.
Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
.../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
index 49c61f65deff..6a1598e6c359 100644
--- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
+++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
@@ -23,6 +23,7 @@ properties:
- amlogic,t7-mpll
- amlogic,t7-hdmi-pll
- amlogic,t7-mclk-pll
+ - amlogic,t7-fpll
reg:
maxItems: 1
@@ -42,6 +43,7 @@ properties:
- const: in0
- const: in1
- const: in2
+ - const: xtal
minItems: 1
required:
@@ -72,11 +74,12 @@ allOf:
contains:
enum:
- amlogic,t7-gp0-pll
- - amlogic,t7-gp1--pll
+ - amlogic,t7-gp1-pll
- amlogic,t7-hifi-pll
- amlogic,t7-pcie-pll
- amlogic,t7-mpll
- amlogic,t7-hdmi-pll
+ - amlogic,t7-fpll
then:
properties:
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support
2026-02-18 10:19 [PATCH 3/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support Ronald Claveau
@ 2026-02-18 10:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-18 10:20 UTC (permalink / raw)
To: Ronald Claveau, linux-amlogic
Cc: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jian Hu,
Xianwei Zhao, linux-clk, devicetree, linux-kernel
On 18/02/2026 11:19, Ronald Claveau wrote:
> Add PLL for the clock controller of the Amlogic T7 SoC family.
>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
Your patchset lacks threading. Please use standard tools to send patches
(e.g. git format-patch + git send-email or b4).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support
2026-02-18 10:17 [PATCH 1/7] drivers: " Ronald Claveau
@ 2026-02-18 10:57 ` Ronald Claveau
2026-02-18 18:13 ` Jerome Brunet
0 siblings, 1 reply; 4+ messages in thread
From: Ronald Claveau @ 2026-02-18 10:57 UTC (permalink / raw)
To: linux-amlogic
Cc: Ronald Claveau, Neil Armstrong, Jerome Brunet, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jian Hu, Xianwei Zhao, linux-clk, devicetree, linux-kernel
Add PLL for the clock controller of the Amlogic T7 SoC family.
Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
.../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
index 49c61f65deff..6a1598e6c359 100644
--- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
+++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
@@ -23,6 +23,7 @@ properties:
- amlogic,t7-mpll
- amlogic,t7-hdmi-pll
- amlogic,t7-mclk-pll
+ - amlogic,t7-fpll
reg:
maxItems: 1
@@ -42,6 +43,7 @@ properties:
- const: in0
- const: in1
- const: in2
+ - const: xtal
minItems: 1
required:
@@ -72,11 +74,12 @@ allOf:
contains:
enum:
- amlogic,t7-gp0-pll
- - amlogic,t7-gp1--pll
+ - amlogic,t7-gp1-pll
- amlogic,t7-hifi-pll
- amlogic,t7-pcie-pll
- amlogic,t7-mpll
- amlogic,t7-hdmi-pll
+ - amlogic,t7-fpll
then:
properties:
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support
2026-02-18 10:57 ` [PATCH 3/7] dt-bindings: " Ronald Claveau
@ 2026-02-18 18:13 ` Jerome Brunet
0 siblings, 0 replies; 4+ messages in thread
From: Jerome Brunet @ 2026-02-18 18:13 UTC (permalink / raw)
To: Ronald Claveau
Cc: linux-amlogic, Neil Armstrong, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jian Hu,
Xianwei Zhao, linux-clk, devicetree, linux-kernel
On mer. 18 févr. 2026 at 11:57, Ronald Claveau <linux-kernel-dev@aliel.fr> wrote:
> Add PLL for the clock controller of the Amlogic T7 SoC family.
Assuming the 3 first patch are actually needed (I don't think they are)
I think patch 2 and 3 should be squashed together
>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> ---
> .../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
> index 49c61f65deff..6a1598e6c359 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
> +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
> @@ -23,6 +23,7 @@ properties:
> - amlogic,t7-mpll
> - amlogic,t7-hdmi-pll
> - amlogic,t7-mclk-pll
> + - amlogic,t7-fpll
>
> reg:
> maxItems: 1
> @@ -42,6 +43,7 @@ properties:
> - const: in0
> - const: in1
> - const: in2
> + - const: xtal
Fishy. Maybe it will get more clear with a more detailed commit description
> minItems: 1
>
> required:
> @@ -72,11 +74,12 @@ allOf:
> contains:
> enum:
> - amlogic,t7-gp0-pll
> - - amlogic,t7-gp1--pll
> + - amlogic,t7-gp1-pll
Indeed that's not good ! but you need specific patch for this, and Fixes
tag. You can send this separately.
> - amlogic,t7-hifi-pll
> - amlogic,t7-pcie-pll
> - amlogic,t7-mpll
> - amlogic,t7-hdmi-pll
> + - amlogic,t7-fpll
>
> then:
> properties:
--
Jerome
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-18 18:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-18 10:19 [PATCH 3/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support Ronald Claveau
2026-02-18 10:20 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2026-02-18 10:17 [PATCH 1/7] drivers: " Ronald Claveau
2026-02-18 10:57 ` [PATCH 3/7] dt-bindings: " Ronald Claveau
2026-02-18 18:13 ` Jerome Brunet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox