From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0DE2313524 for ; Wed, 18 Feb 2026 19:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771442562; cv=none; b=j9VOV4EZOLAYd5xH55aBnbshv1WfxHhw66DsB8nxVoR8L344jqu7OmDVQUtBe6g9cxqcDZpf8pkvd2NtTvj8q5vxnwkRudv6UwCypYCRKa8tKZUWtWLJxH1ljj4GJ7DuS689jshRJrNpzdwss7Ltjh4Y6XTtXDTQcXxKLOIoMGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771442562; c=relaxed/simple; bh=lP+CNXaFhMf8YZnXCXm6Xs2/QQVVhHXBYrq9//M/m3E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SLqPlvP3fvtISNmy3uAul7VPMkO7J1CTyRz8m9OD/rtP/CbRXPMGBI8pU+VWX8dzrkvRNKn6gik7rGDGZRy8goIVNSNv/wOkfr9ZO8dnGgx4R7/FyKTeWy0K39B3IH9kvGHyeTMujBmi2RmLRHBo4Psgy7ECqOMfGW9A0HY2yYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FYWz3fZy; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FYWz3fZy" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48069a48629so1885135e9.0 for ; Wed, 18 Feb 2026 11:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771442559; x=1772047359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gGGbzieM9R1PhBPo2PjiNEjVS65TV6g7Saqe/rvADjA=; b=FYWz3fZypWTIT59uy+zxGbJyBwECZul7RQ+OAQNhhzT9fQpna+cZZL3PXdgaF0Ty6J 0dC2jOfFsW7/gtKez3W8VNmzu5vkk4Ks5cqJVdnUf/KhjFAY/hc8WoiwlQdRQWf7wIlI zeUJRoM8Kso+GL4ZYelUHg5X3WYntD65DA0tmg3FWWCeLD1zySsArCBohnGbRgCtVePm 7pOqFW3nCAGubZqhSVuLAXIMThHT7KbLCxCHXq40O1cn/Ho/rRezpUX0WbMGpLOr/FSp ZDvHeX+7QX9d5xIscEYN0IarpDrR5RnaFlu/kFbg7jL7YFiVWqZhC5tvntNQ1iNkVbqW YkgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771442559; x=1772047359; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gGGbzieM9R1PhBPo2PjiNEjVS65TV6g7Saqe/rvADjA=; b=dld6uwDpsuM0W2gV4HeF4PxpbOz7CDAw7dCzUxAwAftSI2y3FHLz8lugNlUuVIMwFa CJ7ivS3wX4hCdP271lhvrzS7vj1LaJ08Yhm7xE+yGf3VP95lmSXjjK+DOEls3pGjJsxq cFSEMqwll+GtXEj0oREDoWqnsQHYyfUNE7Am5US8VkRFg3PFlwsZfPGimHmlqaL7s0sG SiCVI1/PbMpG7idJOoLbG6Q7Ch8L5/Ysl7xG1IaJo/SHWm1XZo3YUZatOHX0oDfxDSeM COaveIlKpPH+AjHdVWorQk+9dfCl6qxys4yHIVwb9ZA2RpPBmKYgBOUF3ZEB4ejpDT+W ZBkg== X-Gm-Message-State: AOJu0YwPJchTb2BiXvdNEoSwUDR2FKPeDRHlmYqULA6j6BFBrYMreqw+ iCfA3Omj9QwDWVZwy08AtsJhLj3MPlMerIPtOhbEAymf/gYyY0nszhLbcYIeKPlL X-Gm-Gg: AZuq6aI4fWKre5Emip95nLvOT2T9dsHlyqJokx63LXywP/QHleT5WFi9wlbN0ZWLJ/E RQ8tuAqOCo26bupy+FuCYCkKIb/ea+WSEAbqIEvf4oaFEDLXPVn9m4iUqyB7Tf89nIcWHeqFgUF TT4dY6q+y2SWFjnBNex7LmOieez1TOQLH5+KairTkE6ZnYavBqxftHNyLZwlmB5ZiBPPA0Pk5yu AjcOXYem1yxOX/l0P1EqXkVzmOWnLyqlsE56Dmn/GpBsX4iEMbvp4K2PmNXL6wsXbt9/3xIy6d7 dWouOHB0rQC+DiyOrIBS4g8Uz61ZbCpOiv/GN1hPt/NCGb+Sq5r+0ZMDaPBzCgXBqY6TswerxLC QuUxZXxEmHT02nO6AJTKW/EHp9Jr0Lartux5ingaLdtndsQSJs7hcqAZeM/Qkx6Pi5n5cOQXnt9 /YFZ8zsLb2b8YrJIu9BZlBWiEBikf+6h4mIEhFkc3mCTvFv/L6fs0p8q7JI19WrdZupc+s1AF1u +bOrDpMG1YTej1/DoQM X-Received: by 2002:a05:600c:6211:b0:477:93f7:bbc5 with SMTP id 5b1f17b1804b1-48373a09741mr327794125e9.10.1771442558903; Wed, 18 Feb 2026 11:22:38 -0800 (PST) Received: from rozandragon.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a6b563sm43339445f8f.12.2026.02.18.11.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 11:22:38 -0800 (PST) From: David Carlier To: Tejun Heo , David Vernet Cc: linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] tools/sched_ext: fix getopt not re-parsed on restart Date: Wed, 18 Feb 2026 19:22:35 +0000 Message-ID: <20260218192235.8699-1-devnexen@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit After goto restart, optind retains its advanced position from the previous getopt loop, causing getopt() to immediately return -1. This silently drops all command-line options on the restarted skeleton. Reset optind to 1 at the restart label so options are re-parsed. Affected schedulers: scx_simple, scx_central, scx_flatcg, scx_pair, scx_sdt, scx_cpu0. Signed-off-by: David Carlier --- tools/sched_ext/scx_central.c | 1 + tools/sched_ext/scx_cpu0.c | 1 + tools/sched_ext/scx_flatcg.c | 1 + tools/sched_ext/scx_pair.c | 1 + tools/sched_ext/scx_sdt.c | 1 + tools/sched_ext/scx_simple.c | 1 + 6 files changed, 6 insertions(+) diff --git a/tools/sched_ext/scx_central.c b/tools/sched_ext/scx_central.c index 39f21b00a208..2a805f1d6c8f 100644 --- a/tools/sched_ext/scx_central.c +++ b/tools/sched_ext/scx_central.c @@ -56,6 +56,7 @@ int main(int argc, char **argv) signal(SIGINT, sigint_handler); signal(SIGTERM, sigint_handler); restart: + optind = 1; skel = SCX_OPS_OPEN(central_ops, scx_central); skel->rodata->central_cpu = 0; diff --git a/tools/sched_ext/scx_cpu0.c b/tools/sched_ext/scx_cpu0.c index 1e4fa4ab8da9..a6fba9978b9c 100644 --- a/tools/sched_ext/scx_cpu0.c +++ b/tools/sched_ext/scx_cpu0.c @@ -69,6 +69,7 @@ int main(int argc, char **argv) signal(SIGINT, sigint_handler); signal(SIGTERM, sigint_handler); restart: + optind = 1; skel = SCX_OPS_OPEN(cpu0_ops, scx_cpu0); skel->rodata->nr_cpus = libbpf_num_possible_cpus(); diff --git a/tools/sched_ext/scx_flatcg.c b/tools/sched_ext/scx_flatcg.c index a8446509949e..d865c381589b 100644 --- a/tools/sched_ext/scx_flatcg.c +++ b/tools/sched_ext/scx_flatcg.c @@ -141,6 +141,7 @@ int main(int argc, char **argv) signal(SIGINT, sigint_handler); signal(SIGTERM, sigint_handler); restart: + optind = 1; skel = SCX_OPS_OPEN(flatcg_ops, scx_flatcg); skel->rodata->nr_cpus = libbpf_num_possible_cpus(); diff --git a/tools/sched_ext/scx_pair.c b/tools/sched_ext/scx_pair.c index 2a82d8a8a0aa..2e509391f3da 100644 --- a/tools/sched_ext/scx_pair.c +++ b/tools/sched_ext/scx_pair.c @@ -53,6 +53,7 @@ int main(int argc, char **argv) signal(SIGINT, sigint_handler); signal(SIGTERM, sigint_handler); restart: + optind = 1; skel = SCX_OPS_OPEN(pair_ops, scx_pair); skel->rodata->nr_cpu_ids = libbpf_num_possible_cpus(); diff --git a/tools/sched_ext/scx_sdt.c b/tools/sched_ext/scx_sdt.c index b0363363476d..d8ca9aa316a5 100644 --- a/tools/sched_ext/scx_sdt.c +++ b/tools/sched_ext/scx_sdt.c @@ -51,6 +51,7 @@ int main(int argc, char **argv) signal(SIGINT, sigint_handler); signal(SIGTERM, sigint_handler); restart: + optind = 1; skel = SCX_OPS_OPEN(sdt_ops, scx_sdt); while ((opt = getopt(argc, argv, "fvh")) != -1) { diff --git a/tools/sched_ext/scx_simple.c b/tools/sched_ext/scx_simple.c index 06d4b13bf76b..c3b48611712b 100644 --- a/tools/sched_ext/scx_simple.c +++ b/tools/sched_ext/scx_simple.c @@ -71,6 +71,7 @@ int main(int argc, char **argv) signal(SIGINT, sigint_handler); signal(SIGTERM, sigint_handler); restart: + optind = 1; skel = SCX_OPS_OPEN(simple_ops, scx_simple); while ((opt = getopt(argc, argv, "fvh")) != -1) { -- 2.51.0