From: Ethan Tidmore <ethantidmore06@gmail.com>
To: Andreas Gruenbacher <agruenba@redhat.com>,
Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
gfs2@lists.linux.dev, linux-kernel@vger.kernel.org,
Ethan Tidmore <ethantidmore06@gmail.com>
Subject: [PATCH] gfs2: Fix error pointer dereference
Date: Wed, 18 Feb 2026 14:06:45 -0600 [thread overview]
Message-ID: <20260218200645.15713-1-ethantidmore06@gmail.com> (raw)
The function __filemap_get_folio() can return an error pointer and is
not checked for one. Add check for error pointer.
Detected by Smatch:
fs/gfs2/meta_io.c:147 gfs2_getbuf() error:
'folio' dereferencing possible ERR_PTR()
Fixes: 0eb751791df86 ("gfs2: convert gfs2_getbuf() to folios")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
fs/gfs2/meta_io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index 3c8e4553102d..9c0ba4c3cb29 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -144,6 +144,8 @@ struct buffer_head *gfs2_getbuf(struct gfs2_glock *gl, u64 blkno, int create)
folio = __filemap_get_folio(mapping, index,
FGP_LOCK | FGP_ACCESSED | FGP_CREAT,
mapping_gfp_mask(mapping) | __GFP_NOFAIL);
+ if (IS_ERR(folio))
+ return NULL;
bh = folio_buffers(folio);
if (!bh)
bh = create_empty_buffers(folio,
--
2.53.0
next reply other threads:[~2026-02-18 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 20:06 Ethan Tidmore [this message]
2026-02-18 21:14 ` [PATCH] gfs2: Fix error pointer dereference Matthew Wilcox
2026-02-18 21:53 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218200645.15713-1-ethantidmore06@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox