public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Shubhang Kaushik <shubhang@os.amperecomputing.com>
Cc: mingo@kernel.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	vschneid@redhat.com, linux-kernel@vger.kernel.org,
	wangtao554@huawei.com, quzicheng@huawei.com,
	kprateek.nayak@amd.com, wuyun.abel@bytedance.com,
	dsmythies@telus.net
Subject: Re: [PATCH 0/4] sched: Various reweight_entity() fixes
Date: Thu, 19 Feb 2026 08:53:07 +0100	[thread overview]
Message-ID: <20260219075307.GD1395266@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ef11f4a7-b063-d5e5-61b9-348aec6cb6e1@os.amperecomputing.com>

On Wed, Feb 18, 2026 at 10:37:19AM -0800, Shubhang Kaushik wrote:
> Hello Peter,
> 
> On Fri, 30 Jan 2026, Peter Zijlstra wrote:
> 
> > Two issues related to reweight_entity() were raised; poking at all that got me
> > these patches.
> > 
> > They're in queue.git/sched/core and I spend most of yesterday staring at traces
> > trying to find anything wrong. So far, so good.
> > 
> > Please test.
> > 
> > 
> 
> Analysis of commit bdba3187771c ("sched/fair: Use full weight to
> __calc_delta()") confirms it resolves a scaling bottleneck present in the
> v7.0-rc baseline (cee73b1e840c).
> 
> On Ampere Altra (80 cores) non-SMT SMP with CONFIG_NOHZ_FULL and
> CONFIG_SCHED_CLUSTER enabled, the baseline suffered from vruntime distortion
> that caused significant scheduling jitter, resulting in measurable
> performance cliffs under high parallel load.
> 
> Llama AIO for Inference Scaling : The baseline shows a performance cliffs at
> high thread counts, due to the scheduler miscalculating time slices for tail
> threads, which forced the entire synchronous inference batch to wait. The
> patch corrects the delta calculation for predictable scaling.
> 
> n_threads	Baseline (cee73b1e840c)	Patched (bdba3187771c)	Diff
> 51		8.46 t/s		12.12 t/s		+43.3%
> 52		17.75 t/s		22.26 t/s		+25.4%
> 64		12.40 t/s		14.66 t/s		+18.2%
> 
> Hackbench scaling in the baseline was non-linear indicating excessive
> scheduling overhead as process counts increased. By using the full weight
> for delta calculations, the patch reduces unnecessary migrations and
> improves message throughput.
> 
> Task Count	Baseline(sec)	Patched(sec)	Throughput
> 16 Processes	51.25s		44.09s		+16.2%
> 32 Processes	92.42s		78.09s		+18.3%
> 
> Tested-by: Shubhang Kaushik <shubhang@os.amperecomputing.com>

These are excellent results, thanks!

Let me finally get around to posting them.

      reply	other threads:[~2026-02-19  7:53 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30  9:34 [PATCH 0/4] sched: Various reweight_entity() fixes Peter Zijlstra
2026-01-30  9:34 ` [PATCH 1/4] sched/fair: Only set slice protection at pick time Peter Zijlstra
2026-01-30 15:52   ` Vincent Guittot
2026-01-30  9:34 ` [PATCH 2/4] sched/eevdf: Update se->vprot in reweight_entity() Peter Zijlstra
2026-01-30 16:20   ` Vincent Guittot
2026-01-30  9:34 ` [PATCH 3/4] sched/fair: Increase weight bits for avg_vruntime Peter Zijlstra
2026-01-30  9:34 ` [PATCH 4/4] sched/fair: Revert 6d71a9c61604 ("sched/fair: Fix EEVDF entity placement bug causing scheduling lag") Peter Zijlstra
2026-01-31  1:47   ` Zhang Qiao
2026-01-31 15:21     ` Peter Zijlstra
2026-02-02  9:12       ` Peter Zijlstra
2026-02-02  9:24         ` Peter Zijlstra
2026-02-02 11:23         ` Zhang Qiao
2026-02-01 17:13 ` [PATCH 0/4] sched: Various reweight_entity() fixes Doug Smythies
2026-02-03  6:45 ` K Prateek Nayak
2026-02-03 11:11   ` Peter Zijlstra
2026-02-03 12:19     ` K Prateek Nayak
2026-02-03 16:36       ` Doug Smythies
2026-02-10 18:13         ` Peter Zijlstra
2026-02-11  5:51           ` Doug Smythies
2026-02-04 10:15       ` K Prateek Nayak
2026-02-09 15:47         ` Peter Zijlstra
2026-02-09 16:52           ` K Prateek Nayak
2026-02-10  5:16           ` K Prateek Nayak
2026-02-10 10:29             ` Peter Zijlstra
2026-02-10 15:41           ` Doug Smythies
2026-02-10 18:09             ` K Prateek Nayak
2026-02-10 18:35               ` Peter Zijlstra
2026-02-10 20:04                 ` K Prateek Nayak
2026-02-11  6:28                   ` K Prateek Nayak
2026-02-11  8:50                     ` K Prateek Nayak
2026-02-11 23:09               ` Doug Smythies
2026-02-10 18:52             ` Peter Zijlstra
2026-02-10 20:52           ` Vincent Guittot
2026-02-11  5:21             ` Doug Smythies
2026-02-11  8:49               ` Vincent Guittot
2026-02-11  9:01                 ` Peter Zijlstra
2026-02-11 10:48                   ` Peter Zijlstra
2026-02-11 10:49                     ` Peter Zijlstra
2026-02-11 11:15                     ` Vincent Guittot
2026-02-11 16:28                       ` Peter Zijlstra
2026-02-12  7:43                         ` K Prateek Nayak
2026-02-12 11:59                           ` Peter Zijlstra
2026-02-12 17:16                             ` Peter Zijlstra
2026-02-12 17:24                               ` Vincent Guittot
2026-02-12 19:31                                 ` Peter Zijlstra
2026-02-13  5:22                                   ` K Prateek Nayak
2026-02-13  6:44                                     ` Peter Zijlstra
2026-02-13 10:50                                       ` Peter Zijlstra
2026-02-13 14:29                                         ` K Prateek Nayak
2026-02-14  6:31                                         ` Doug Smythies
2026-02-21 22:51                                           ` Doug Smythies
2026-02-12 19:29                               ` Peter Zijlstra
2026-02-12 19:37                                 ` Doug Smythies
2026-02-13  6:04                                 ` K Prateek Nayak
2026-02-11 16:21                     ` Peter Zijlstra
2026-02-12  5:54                       ` Doug Smythies
2026-02-12  7:51                         ` Peter Zijlstra
2026-02-12 15:47                           ` Doug Smythies
2026-02-12  7:46                       ` Peter Zijlstra
2026-02-11 23:25                     ` Doug Smythies
2026-02-11  8:48             ` Peter Zijlstra
2026-02-04 10:44       ` Peter Zijlstra
2026-02-14  7:20 ` Shubhang Kaushik
2026-02-16  3:14   ` K Prateek Nayak
2026-02-16 10:59     ` Dietmar Eggemann
2026-02-17 14:37       ` Dietmar Eggemann
2026-02-17 22:02     ` Shubhang Kaushik
2026-02-17  4:20 ` K Prateek Nayak
2026-02-18 18:37 ` Shubhang Kaushik
2026-02-19  7:53   ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260219075307.GD1395266@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=dsmythies@telus.net \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=quzicheng@huawei.com \
    --cc=rostedt@goodmis.org \
    --cc=shubhang@os.amperecomputing.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=wangtao554@huawei.com \
    --cc=wuyun.abel@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox