From: Jeongjun Park <aha310510@gmail.com>
To: stable@vger.kernel.org
Cc: gregkh@linuxfoundation.org, tglx@linutronix.de,
Julia.Lawall@inria.fr, akpm@linux-foundation.org,
anna-maria@linutronix.de, arnd@arndb.de,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, luiz.dentz@gmail.com, marcel@holtmann.org,
maz@kernel.org, peterz@infradead.org, rostedt@goodmis.org,
sboyd@kernel.org, viresh.kumar@linaro.org, zouyipeng@huawei.com,
aha310510@gmail.com, linux-staging@lists.linux.dev,
Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH 5.10.y 02/15] ARM: spear: Do not use timer namespace for timer_shutdown() function
Date: Fri, 20 Feb 2026 02:12:57 +0900 [thread overview]
Message-ID: <20260219171310.118170-3-aha310510@gmail.com> (raw)
In-Reply-To: <20260219171310.118170-1-aha310510@gmail.com>
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
[ Upstream commit 80b55772d41d8afec68dbc4ff0368a9fe5d1f390 ]
A new "shutdown" timer state is being added to the generic timer code. One
of the functions to change the timer into the state is called
"timer_shutdown()". This means that there can not be other functions called
"timer_shutdown()" as the timer code owns the "timer_*" name space.
Rename timer_shutdown() to spear_timer_shutdown() to avoid this conflict.
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lkml.kernel.org/r/20221106212701.822440504@goodmis.org
Link: https://lore.kernel.org/all/20221105060155.228348078@goodmis.org/
Link: https://lore.kernel.org/r/20221110064146.810953418@goodmis.org
Link: https://lore.kernel.org/r/20221123201624.513863211@linutronix.de
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
---
arch/arm/mach-spear/time.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c
index e979e2197f8e..5371c824786d 100644
--- a/arch/arm/mach-spear/time.c
+++ b/arch/arm/mach-spear/time.c
@@ -90,7 +90,7 @@ static void __init spear_clocksource_init(void)
200, 16, clocksource_mmio_readw_up);
}
-static inline void timer_shutdown(struct clock_event_device *evt)
+static inline void spear_timer_shutdown(struct clock_event_device *evt)
{
u16 val = readw(gpt_base + CR(CLKEVT));
@@ -101,7 +101,7 @@ static inline void timer_shutdown(struct clock_event_device *evt)
static int spear_shutdown(struct clock_event_device *evt)
{
- timer_shutdown(evt);
+ spear_timer_shutdown(evt);
return 0;
}
@@ -111,7 +111,7 @@ static int spear_set_oneshot(struct clock_event_device *evt)
u16 val;
/* stop the timer */
- timer_shutdown(evt);
+ spear_timer_shutdown(evt);
val = readw(gpt_base + CR(CLKEVT));
val |= CTRL_ONE_SHOT;
@@ -126,7 +126,7 @@ static int spear_set_periodic(struct clock_event_device *evt)
u16 val;
/* stop the timer */
- timer_shutdown(evt);
+ spear_timer_shutdown(evt);
period = clk_get_rate(gpt_clk) / HZ;
period >>= CTRL_PRESCALER16;
--
next prev parent reply other threads:[~2026-02-19 17:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 17:12 [PATCH 5.10.y 00/15] timers: Provide timer_shutdown[_sync]() Jeongjun Park
2026-02-19 17:12 ` [PATCH 5.10.y 01/15] Documentation: Remove bogus claim about del_timer_sync() Jeongjun Park
2026-02-19 17:12 ` Jeongjun Park [this message]
2026-02-19 17:12 ` [PATCH 5.10.y 03/15] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function Jeongjun Park
2026-02-19 17:12 ` [PATCH 5.10.y 04/15] clocksource/drivers/sp804: " Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 05/15] timers: Get rid of del_singleshot_timer_sync() Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 06/15] timers: Replace BUG_ON()s Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 07/15] timers: Rename del_timer() to timer_delete() Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 08/15] Documentation: Replace del_timer/del_timer_sync() Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 09/15] timers: Silently ignore timers with a NULL function Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 10/15] timers: Split [try_to_]del_timer[_sync]() to prepare for shutdown mode Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 11/15] timers: Add shutdown mechanism to the internal functions Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 12/15] timers: Provide timer_shutdown[_sync]() Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 13/15] timers: Update the documentation to reflect on the new timer_shutdown() API Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 14/15] Bluetooth: hci_qca: Fix the teardown problem for real Jeongjun Park
2026-02-19 17:13 ` [PATCH 5.10.y 15/15] timers: Fix NULL function pointer race in timer_shutdown_sync() Jeongjun Park
2026-02-19 17:17 ` Jeongjun Park
2026-04-23 12:49 ` [PATCH 5.10.y 00/15] timers: Provide timer_shutdown[_sync]() Greg KH
2026-04-23 13:36 ` Jeongjun Park
2026-04-23 13:43 ` Greg KH
2026-04-23 14:07 ` Jeongjun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219171310.118170-3-aha310510@gmail.com \
--to=aha310510@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@roeck-us.net \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=maz@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=zouyipeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox