From: bhargav <rougueprince47@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
rougueprince47@gmail.com
Subject: [PATCH v3 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions
Date: Fri, 20 Feb 2026 03:05:49 +0530 [thread overview]
Message-ID: <20260219213549.59645-4-rougueprince47@gmail.com> (raw)
In-Reply-To: <20260219213549.59645-1-rougueprince47@gmail.com>
The driver currently defines device attributes using
symbolic permission flags (S_IRUGO and S_IWUSR).
Update these to use octal permissions (0444 and 0200) to resolve
checkpatch warnings.
Signed-off-by: bhargav <rougueprince47@gmail.com>
---
Changes in v3:
-reduced unwanted vertical spacing
-fixed broken indentation
drivers/iio/frequency/ad9523.c | 78 +++++++++++++---------------------
1 file changed, 29 insertions(+), 49 deletions(-)
diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
index 6daa2ea354a8..ad32eb66edca 100644
--- a/drivers/iio/frequency/ad9523.c
+++ b/drivers/iio/frequency/ad9523.c
@@ -558,55 +558,35 @@ static ssize_t ad9523_show(struct device *dev,
return ret;
}
-static IIO_DEVICE_ATTR(pll1_locked, S_IRUGO,
- ad9523_show,
- NULL,
- AD9523_STAT_PLL1_LD);
-
-static IIO_DEVICE_ATTR(pll2_locked, S_IRUGO,
- ad9523_show,
- NULL,
- AD9523_STAT_PLL2_LD);
-
-static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, S_IRUGO,
- ad9523_show,
- NULL,
- AD9523_STAT_REFA);
-
-static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, S_IRUGO,
- ad9523_show,
- NULL,
- AD9523_STAT_REFB);
-
-static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, S_IRUGO,
- ad9523_show,
- NULL,
- AD9523_STAT_REF_TEST);
-
-static IIO_DEVICE_ATTR(vcxo_clk_present, S_IRUGO,
- ad9523_show,
- NULL,
- AD9523_STAT_VCXO);
-
-static IIO_DEVICE_ATTR(pll2_feedback_clk_present, S_IRUGO,
- ad9523_show,
- NULL,
- AD9523_STAT_PLL2_FB_CLK);
-
-static IIO_DEVICE_ATTR(pll2_reference_clk_present, S_IRUGO,
- ad9523_show,
- NULL,
- AD9523_STAT_PLL2_REF_CLK);
-
-static IIO_DEVICE_ATTR(sync_dividers, S_IWUSR,
- NULL,
- ad9523_store,
- AD9523_SYNC);
-
-static IIO_DEVICE_ATTR(store_eeprom, S_IWUSR,
- NULL,
- ad9523_store,
- AD9523_EEPROM);
+static IIO_DEVICE_ATTR(pll1_locked, 0444, ad9523_show, NULL,
+ AD9523_STAT_PLL1_LD);
+
+static IIO_DEVICE_ATTR(pll2_locked, 0444, ad9523_show, NULL,
+ AD9523_STAT_PLL2_LD);
+
+static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, 0444, ad9523_show, NULL,
+ AD9523_STAT_REFA);
+
+static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, 0444, ad9523_show, NULL,
+ AD9523_STAT_REFB);
+
+static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, 0444, ad9523_show, NULL,
+ AD9523_STAT_REF_TEST);
+
+static IIO_DEVICE_ATTR(vcxo_clk_present, 0444, ad9523_show, NULL,
+ AD9523_STAT_VCXO);
+
+static IIO_DEVICE_ATTR(pll2_feedback_clk_present, 0444, ad9523_show, NULL,
+ AD9523_STAT_PLL2_FB_CLK);
+
+static IIO_DEVICE_ATTR(pll2_reference_clk_present, 0444, ad9523_show, NULL,
+ AD9523_STAT_PLL2_REF_CLK);
+
+static IIO_DEVICE_ATTR(sync_dividers, 0200, NULL, ad9523_store,
+ AD9523_SYNC);
+
+static IIO_DEVICE_ATTR(store_eeprom, 0200, NULL, ad9523_store,
+ AD9523_EEPROM);
static struct attribute *ad9523_attributes[] = {
&iio_dev_attr_sync_dividers.dev_attr.attr,
--
2.53.0
next prev parent reply other threads:[~2026-02-19 21:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 1:02 [PATCH] iio:frequency:ad9523:convert symbolic permissions to octal and remove unwanted arguments in macro bhargav
2026-02-19 7:44 ` Andy Shevchenko
2026-02-19 20:32 ` [PATCH v2 0/3] iio: frequency: ad9523: fix checkpatch warnings bhargav
2026-02-19 20:32 ` [PATCH v2 1/3] iio: frequency: ad9523: fix implicit variable usage in macros bhargav
2026-02-19 20:36 ` Andy Shevchenko
2026-02-19 20:32 ` [PATCH v2 2/3] iio: frequency: ad9523: avoid multiple line dereferences for pdata bhargav
2026-02-19 20:38 ` Andy Shevchenko
2026-02-19 20:32 ` [PATCH v2 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions bhargav
2026-02-19 20:46 ` Andy Shevchenko
2026-02-19 21:35 ` [PATCH v3 0/3] iio: frequency: ad9523: fix checkpatch warnings bhargav
2026-02-19 21:35 ` [PATCH v3 1/3] iio: frequency: ad9523: fix implicit variable usage in macros bhargav
2026-02-20 7:21 ` Andy Shevchenko
2026-02-19 21:35 ` [PATCH v3 2/3] iio: frequency: ad9523: avoid multiple line dereferences for pdata bhargav
2026-02-19 21:35 ` bhargav [this message]
2026-02-20 7:24 ` [PATCH v3 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions Andy Shevchenko
2026-02-20 7:22 ` [PATCH v3 0/3] iio: frequency: ad9523: fix checkpatch warnings Andy Shevchenko
2026-02-22 13:50 ` Jonathan Cameron
2026-02-22 13:58 ` Jonathan Cameron
2026-02-22 21:19 ` Rogue prince
2026-02-23 8:35 ` Andy Shevchenko
2026-02-23 20:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219213549.59645-4-rougueprince47@gmail.com \
--to=rougueprince47@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox