From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Damien Le Moal <dlemoal@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Niklas Cassel <cassel@kernel.org>
Subject: [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
Date: Fri, 20 Feb 2026 11:42:08 +0100 [thread overview]
Message-ID: <20260220104208.2326568-1-andriy.shevchenko@linux.intel.com> (raw)
As noticed in the discussion [1] the Baikal SoC and platforms
are not going to be finalized, hence remove stale code.
Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@infradead.org/ [1]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/ata/Kconfig | 1 -
drivers/ata/ahci_dwc.c | 54 ------------------------------------------
2 files changed, 55 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 2349bca136e0..fff305ec1e78 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -194,7 +194,6 @@ config AHCI_DM816
config AHCI_DWC
tristate "Synopsys DWC AHCI SATA support"
select SATA_HOST
- select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST)
help
This option enables support for the Synopsys DWC AHCI SATA
controller implementation.
diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c
index 64abf865bb67..436041c57f73 100644
--- a/drivers/ata/ahci_dwc.c
+++ b/drivers/ata/ahci_dwc.c
@@ -13,7 +13,6 @@
#include <linux/kernel.h>
#include <linux/libata.h>
#include <linux/log2.h>
-#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
@@ -92,20 +91,6 @@
#define AHCI_DWC_PORT_PHYCR 0x74
#define AHCI_DWC_PORT_PHYSR 0x78
-/* Baikal-T1 AHCI SATA specific registers */
-#define AHCI_BT1_HOST_PHYCR AHCI_DWC_HOST_GPCR
-#define AHCI_BT1_HOST_MPLM_MASK GENMASK(29, 23)
-#define AHCI_BT1_HOST_LOSDT_MASK GENMASK(22, 20)
-#define AHCI_BT1_HOST_CRR BIT(19)
-#define AHCI_BT1_HOST_CRW BIT(18)
-#define AHCI_BT1_HOST_CRCD BIT(17)
-#define AHCI_BT1_HOST_CRCA BIT(16)
-#define AHCI_BT1_HOST_CRDI_MASK GENMASK(15, 0)
-
-#define AHCI_BT1_HOST_PHYSR AHCI_DWC_HOST_GPSR
-#define AHCI_BT1_HOST_CRA BIT(16)
-#define AHCI_BT1_HOST_CRDO_MASK GENMASK(15, 0)
-
struct ahci_dwc_plat_data {
unsigned int pflags;
unsigned int hflags;
@@ -122,39 +107,6 @@ struct ahci_dwc_host_priv {
u32 dmacr[AHCI_MAX_PORTS];
};
-static int ahci_bt1_init(struct ahci_host_priv *hpriv)
-{
- struct ahci_dwc_host_priv *dpriv = hpriv->plat_data;
- int ret;
-
- /* APB, application and reference clocks are required */
- if (!ahci_platform_find_clk(hpriv, "pclk") ||
- !ahci_platform_find_clk(hpriv, "aclk") ||
- !ahci_platform_find_clk(hpriv, "ref")) {
- dev_err(&dpriv->pdev->dev, "No system clocks specified\n");
- return -EINVAL;
- }
-
- /*
- * Fully reset the SATA AXI and ref clocks domain to ensure the state
- * machine is working from scratch especially if the reference clocks
- * source has been changed.
- */
- ret = ahci_platform_assert_rsts(hpriv);
- if (ret) {
- dev_err(&dpriv->pdev->dev, "Couldn't assert the resets\n");
- return ret;
- }
-
- ret = ahci_platform_deassert_rsts(hpriv);
- if (ret) {
- dev_err(&dpriv->pdev->dev, "Couldn't de-assert the resets\n");
- return ret;
- }
-
- return 0;
-}
-
static struct ahci_host_priv *ahci_dwc_get_resources(struct platform_device *pdev)
{
struct ahci_dwc_host_priv *dpriv;
@@ -457,15 +409,9 @@ static struct ahci_dwc_plat_data ahci_dwc_plat = {
.pflags = AHCI_PLATFORM_GET_RESETS,
};
-static struct ahci_dwc_plat_data ahci_bt1_plat = {
- .pflags = AHCI_PLATFORM_GET_RESETS | AHCI_PLATFORM_RST_TRIGGER,
- .init = ahci_bt1_init,
-};
-
static const struct of_device_id ahci_dwc_of_match[] = {
{ .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
{ .compatible = "snps,spear-ahci", &ahci_dwc_plat },
- { .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },
{},
};
MODULE_DEVICE_TABLE(of, ahci_dwc_of_match);
--
2.50.1
next reply other threads:[~2026-02-20 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 10:42 Andy Shevchenko [this message]
2026-02-20 13:27 ` [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC Niklas Cassel
2026-02-20 13:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220104208.2326568-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox