From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FFBB241695
	for <linux-kernel@vger.kernel.org>; Fri, 20 Feb 2026 16:07:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1771603664; cv=none; b=gX/b16gbEYPvzq1D23jUYguYfoChSmhfmLXYJGxR0iCO/ru4oxwTJWtnobO3ao74hxZe1649p/BuGk0XAuUBCBUEQmqmihXmuFGguwqyYi7xPnYKCrEUQ53doezpa1q8fHs3LNHpiJn+ReP7X+QsIK+3/6mrbdGb6m4fuP061Iw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1771603664; c=relaxed/simple;
	bh=+i2XC0l31rMhiu5cLXDdP05zrx+Jck+c7jkSvZl1P6I=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=Aer9RjU0vjOdf+CIsiF7BSZTXWrKKmCiCa1oRK0wt5g6Qj2FK2NuOsVPqB/azjFA1HdZTryiJQTWanMH5IKRtol2TfbPn+6ETku4FcDQroBPKwoEvtmYPfZ44i3tHlGfVGleyrbW4KUKwb272RczhHYjZjFwCrEVvUzFURB/Yls=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 84DE668B05; Fri, 20 Feb 2026 17:07:41 +0100 (CET)
Date: Fri, 20 Feb 2026 17:07:41 +0100
From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] nvme: update nvme_id_ns OPTPERF constants
Message-ID: <20260220160741.GC15071@lst.de>
References: <20260220032809.758089-1-csander@purestorage.com> <20260220032809.758089-3-csander@purestorage.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260220032809.758089-3-csander@purestorage.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Feb 19, 2026 at 08:28:05PM -0700, Caleb Sander Mateos wrote:
> Since NVM Command Spec 1.1, OPTPERF comprises both bits 4 and 5 of
> NSFEAT in the Identify Namespace structure. Replace NVME_NS_FEAT_IO_OPT,
> which represented only bit 4, with NVME_NS_FEAT_OPTPERF_SHIFT and
> NVME_NS_FEAT_OPTPERF_MASK.

As you're deeper in this than me:  do the older specs require the
other bit to be cleared to zero and this is all compatible?  Or do
we need to guard it somehow?

Otherwise looks good.