From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E0A0241695 for ; Fri, 20 Feb 2026 16:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771603713; cv=none; b=Vu6lV4sGr1JsK93GiZM9aEwsvucewvoj/icPg5Ga5a1TIy7d0sRquzcRHpA4eBkHqbjPUg1dUqhTIdpnqs+PMVD25l4+jVIwKtuxXRrv8hy4PfGI3j/u+vBIz459EjYT1dvKnhamQCsGr73CdOwFLJBlPf+pt3r7UJOJe+r6OZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771603713; c=relaxed/simple; bh=15RSoQEN6dCwvTA4QLiZZqxkYLNzZvn8sIyEvGSNQ6g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oqDpFLUomjbkaRFfo2s7tqvtpYVeMkKbocqeTu30sSS+6eFUH6j04BXdM6ojCO4Z0WPnUjGUstoW09qYbYr91A9Kkh90KTFlJ0fkUqm0OZH1pIsjmhmmqrVFHn7aqptq6/EpwkU4cWxec8x6SCsBuNkAqhV5Z3aFObi8H150fYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 542BE68B05; Fri, 20 Feb 2026 17:08:30 +0100 (CET) Date: Fri, 20 Feb 2026 17:08:30 +0100 From: Christoph Hellwig To: Caleb Sander Mateos Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] nvme: always issue I/O Command Set specific Identify Namespace Message-ID: <20260220160830.GD15071@lst.de> References: <20260220032809.758089-1-csander@purestorage.com> <20260220032809.758089-4-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260220032809.758089-4-csander@purestorage.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Feb 19, 2026 at 08:28:06PM -0700, Caleb Sander Mateos wrote: > Currently, the I/O Command Set specific Identify Namespace structure is > only fetched for controllers that support extended LBA formats. This is > because struct nvme_id_ns_nvm is only used by nvme_configure_pi_elbas(), > which is only called when the ELBAS bit is set in the CTRATT field of > the Identify Controller structure. > > However, the I/O Command Set specific Identify Namespace structure will > soon be used in nvme_config_discard(), so always try to obtain it in > nvme_update_ns_info_block() if the controller supports NVMe version 2.0 > or later. This was done kinda intentionally to avoid extra roundtrips and tripping over buggy implementations. But I think you have a good use case to extent this, so: Reviewed-by: Christoph Hellwig > goto out; > } > > -- > 2.45.2 ---end quoted text---