From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E4EE2765F5
	for <linux-kernel@vger.kernel.org>; Fri, 20 Feb 2026 16:11:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1771603863; cv=none; b=JKicTGYKVWBcewUyZyUvxSIltxTaZb6HHOXeZy0Ozdy/bqRYbQH5y5x2mFsCcJ8nqtZQC9IHaIB6GpL+8KHJ8EO4RVSp+W+Za9OCz0JY6gzj2A+wfLx6ARnsIbud22eLCQd/rmQT9bzvtkGY4I12fRLJsGSjXxzNbvNUUvuHq5Q=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1771603863; c=relaxed/simple;
	bh=dlwqpBDJLohovqOqN1l4hMEygSPaWXYi3iPxAS6xRmA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=e8njxmawF+jOLGq715Zc19xKHvFNmToQUoVf4D0wXEtBWtpHpnJUppCgczaXBpAf7ZoDehrVs6+q0WF7mCzuV2V9IMRhV8ofTz6rP5P+O287HFI1pfkKJhFxGWhgfEShYmcxbf0gZWiGPu2MBsvektaJQBKnRWvj3sPQ86U7jXU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 40CE868B05; Fri, 20 Feb 2026 17:11:00 +0100 (CET)
Date: Fri, 20 Feb 2026 17:10:59 +0100
From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT
Message-ID: <20260220161059.GF15071@lst.de>
References: <20260220032809.758089-1-csander@purestorage.com> <20260220032809.758089-6-csander@purestorage.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260220032809.758089-6-csander@purestorage.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Feb 19, 2026 at 08:28:08PM -0700, Caleb Sander Mateos wrote:
> Use the NVME_NS_FEAT_OPTPERF_SHIFT constant in nvmet_bdev_set_limits()
> to set the OPTPERF bits of the nvme_id_ns NSFEAT field instead of the
> magic number 4.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>