From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B92366544 for ; Fri, 20 Feb 2026 18:20:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771611639; cv=none; b=HtA9PSkc7lsv7HVh0QEaOLNJUWkAddIF2xneUJAaAaZ9vbalT2y/L+qjaJ0gQoW9y8IyA2b549DrTfUVkslWdxXOx/HgmeAKXo/scDTNzhOdR2adiA+QJm2+eR7CVSDLptMZjVfoVwZew14EPbbzBOW1ZQSpGudG3F0hDaoTUes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771611639; c=relaxed/simple; bh=B70Dg1KnWId+84nKzdvSCzbx9v8OOTz5PhxPUSIWwmg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o1Mk4G+sWQXL7CNSNdlzgwIsJHZpHxOR4V6+kao5I1mKuZLb29GhPrhKV97XafEwx50tT+KAdMbPDbOkrjdCqS05iemSjcWLtf9UZd8TK6LDl32p/GwQD+5yXntck9gMtT0OyDT9jnoAk+ibUfnOll8f8ppPBh/azZQsi3L2wDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=G8VI7y3h; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="G8VI7y3h" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771611636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RaXcc3pAAHmc8PSgdViMdDRL6D0Fzy3EW/WYrcZC0ac=; b=G8VI7y3hAwkBLiZZYr4HkjydRWseGSN9qmA3N/uBhIeWhpK0y6C0dpebiZCZMIKu7Z0Tm/ aTcVSMVIXMYNaKN2JJ/6N+dnCCbqOmbWLJwbX3xwwWQyF4LIGtGzKZQZ5cvTmmw6xFDdLC 1XX/YcSiuLmlSSDr64oWzEyzThC4X+Q= From: Ihor Solodrai To: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Eduard Zingerman Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: [PATCH bpf v1 5/7] selftests/bpf: Use strscpy_cat() in the test_loader Date: Fri, 20 Feb 2026 10:20:09 -0800 Message-ID: <20260220182011.802116-6-ihor.solodrai@linux.dev> In-Reply-To: <20260220182011.802116-1-ihor.solodrai@linux.dev> References: <20260220182011.802116-1-ihor.solodrai@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Replace a pair of strcpy() calls that construct the unpriv test name with a single strscpy_cat() call. This simplifies the code and adds bounds checking. Signed-off-by: Ihor Solodrai --- tools/testing/selftests/bpf/test_loader.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/bpf/test_loader.c b/tools/testing/selftests/bpf/test_loader.c index 338c035c3688..af4319566fea 100644 --- a/tools/testing/selftests/bpf/test_loader.c +++ b/tools/testing/selftests/bpf/test_loader.c @@ -673,18 +673,18 @@ static int parse_test_spec(struct test_loader *tester, if (spec->mode_mask & UNPRIV) { int descr_len = strlen(description); - const char *suffix = " @unpriv"; + static const char suffix[] = " @unpriv"; + int name_len = descr_len + sizeof(suffix) + 1; char *name; - name = malloc(descr_len + strlen(suffix) + 1); + name = malloc(name_len); if (!name) { PRINT_FAIL("failed to allocate memory for unpriv.name\n"); err = -ENOMEM; goto cleanup; } - strcpy(name, description); - strcpy(&name[descr_len], suffix); + strscpy_cat(name, name_len, description, suffix); spec->unpriv.name = name; } -- 2.53.0