From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E71528AB0B for ; Sat, 21 Feb 2026 03:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771644789; cv=none; b=ltUqhHE+6O8iTsNlC/E2u+OiTL3o44QVuE3GZiMCsr5m3JDdSIZtLnE5VDyfSo++Asd9XxFB6Y/hiOhm0CWv2Exq9Dlv3GopnTbReuX8VoYfSJj6pEfW4tdIE720oebTjWarX/ThE9QCJe866vBMcbPGkfQTQQcJQEdypFZKhgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771644789; c=relaxed/simple; bh=NdPvYIVAiaJrTIXUdUqqs5xQQgNiklVTzdScYSwE5do=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rrTOnUXluB2Le6JqYLe1JYK55xDu2KcUbc/RdIXRkJLrVGnj8cwVLy0F5/Hv9kDbYt5/SHaQRUcJCi6xeoXOOVQLHu77TUH/ISRzNVx/6ZkkhvBSkxEVC3R95gt8IIAWTcAQvmfoHu++cSb9bYzcQ4uzR/EKIRpqddymomRHHEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=gADcNy34; arc=none smtp.client-ip=209.85.214.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="gADcNy34" Received: by mail-pl1-f226.google.com with SMTP id d9443c01a7336-2a8fba89cb5so3826945ad.2 for ; Fri, 20 Feb 2026 19:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771644787; x=1772249587; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d5MnxCfiSl8pO88LgItQirBF6Sk69OYbyQL24d2UZK0=; b=gADcNy342A8DAOfjlZdeeBTVAbDnGg1PbH7Y3JSS7JllwrMNJvYtl7uQNVjRrJpSVz ZKUJPUf2kelr2JDbaZ0XrzI1A23/H7Pzmab2PwuUXvVr6ghs9fjDlGoPO+1+g+fs1k5O 5BeyiDACcmDk+uerM6ou3rXl40M23s5mOVhl8gGcbGS8bayh0sd7VOKX1lKJI8+jPJ/J dyA7tkuFB4CcXW0dt7XTOcZPDczmEenS89a+o4/eJ3xFYtYyzrd/Z3PRvhHfDZHIHxu0 6WNHt/6y8GkRy/cRCdZw8ubugq+bxdsvKOzvFBPa3hHTsXajLYL3kbsET2l0/dUNLbuc J2ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771644787; x=1772249587; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d5MnxCfiSl8pO88LgItQirBF6Sk69OYbyQL24d2UZK0=; b=bBWvqXfyXwsMknIfLd4bXC+2Cp5dTs2S3NK909diWepqUttTCOVhBT7Dz+9Agw1cCN CXyYickAnoWDc9gsQAnjAMYnF+xGDy/baqkRtH/zWem7KAkwGHclDb4/5bba2KBsnvI/ RMOTvQPqfETgalFdtaxNyKUcPYBFvEO2NYVxmgY8/JK7tBtZ+7yTKCIiu6zjDZZbI7An ishspeTBRS16iiPLP8ByYXlhCafMHQ3TkJHRuzRi7/HLua3pyOh9RkuewNnQQ/b13M1P euwgyeoDyPlpYt9SPEzzFoALKy7kG5lj06k1dY5u/gbPXMNTYKp3HsQ66wbKr/ijG3B2 rGdg== X-Forwarded-Encrypted: i=1; AJvYcCW1CjeWqUTVz4mq92aCfXshLkN6NZ+/CuxTzPKKg9xxjgOK3sYZojInIHdanfedxzfFq3Hjoh7UESyLOaw=@vger.kernel.org X-Gm-Message-State: AOJu0YxqdNRHCDKXKxEKGsvAMrjT485QPqrHFBmZ1ndUacQa0+hYQoau L4DCO9lxMzCWRWSEOAw3X7bSBQ3jtGmrxHGk0Pi8KNaZVMD9jazfiDIl0n9yr9cbrawXtDdzz2d KgqvcNIQwhaq/K6zstEodQ94cdJvh1T5Oh/tT5XreJ9FVGWc6MX+Q X-Gm-Gg: AZuq6aIeEN4jwHJIHhOx3ukYJ+9QUd268y0Utl1BApOUtctNrBB7RtEyBXzKnhi8bpf LJ/kGDajPos7MCUQ2OJ+WFlBG7OTcYBQZwcCBkD5nUQDUC7fAWo0SJTlRXENYfOmvxtN9n41ROI 6FIcKUXdZhcGfCwMeQ9lnIaJfP8VG5ItaGLwed65l0hsAi08Rwn+p8qKkPQ2ILkuXcxT7UniMGX tjUi2/iyh9BAMz5i8qrGu+wCRVNrTMXiATCW1pwu5QzH0HWotcFL5hRfQMZmWl/iY8GixbDBC/Z 4PqI4+fvKp9qlcwH2EqAiMqYZrL3el9XvR1DlG6jJRxKseilq4FB/dgCvEt/lmYEYRChkqX9euD lY8X0knG7fadyzksg/w2aCgW3nREd1Cb1dQ5zer8= X-Received: by 2002:a17:902:f607:b0:2a3:bf5f:9267 with SMTP id d9443c01a7336-2ad744d1bddmr11993925ad.4.1771644787570; Fri, 20 Feb 2026 19:33:07 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2ad74e03b5asm1599765ad.2.2026.02.20.19.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 19:33:07 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id C91E8340705; Fri, 20 Feb 2026 20:33:06 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id BF616E427C8; Fri, 20 Feb 2026 20:33:05 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v2 4/7] nvme: always issue I/O Command Set specific Identify Namespace Date: Fri, 20 Feb 2026 20:32:59 -0700 Message-ID: <20260221033302.1451669-5-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260221033302.1451669-1-csander@purestorage.com> References: <20260221033302.1451669-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, the I/O Command Set specific Identify Namespace structure is only fetched for controllers that support extended LBA formats. This is because struct nvme_id_ns_nvm is only used by nvme_configure_pi_elbas(), which is only called when the ELBAS bit is set in the CTRATT field of the Identify Controller structure. However, the I/O Command Set specific Identify Namespace structure will soon be used in nvme_update_disk_info(), so always try to obtain it in nvme_update_ns_info_block() if the controller supports NVMe version 2.0 or later. Signed-off-by: Caleb Sander Mateos Reviewed-by: Christoph Hellwig --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index bff6f26d7bcf..2b433478f328 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2352,11 +2352,11 @@ static int nvme_update_ns_info_block(struct nvme_ns *ns, ret = -ENXIO; goto out; } lbaf = nvme_lbaf_index(id->flbas); - if (ns->ctrl->ctratt & NVME_CTRL_ATTR_ELBAS) { + if (ns->ctrl->vs >= NVME_VS(2, 0, 0)) { ret = nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm); if (ret < 0) goto out; } -- 2.45.2