From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f97.google.com (mail-oa1-f97.google.com [209.85.160.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2BD32C1584 for ; Sat, 21 Feb 2026 03:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771644790; cv=none; b=ioMyO1lXalVRL2UPSE2ynM0YX/6ItDtICfSvDBckD5gwKDmKXq5Ebr7Wg6zobJ4aV+/ZSFAHjQVq2HZGm23N5qUq8SCCEXMDrX8KaGAYGnMxQ6xnoj35CBQlFMnHD8v+XammGkWscjbuRul1+HJ4pJRtMIRhKaad9akJG8rSapw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771644790; c=relaxed/simple; bh=pBiR297b8PXFueLy2tPMN9uZJGaoOz/0vV31TY2gEY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BwcovA/uyXiNYyPJTc/Wi1HMJDDk9O0Z0K6K4dCqCJLdCylDeVpxisU5sdYaoH2zZFWglMVcA3p20stXkCaFQEfcB9oOYz6wo5ydL4rTuh5KyCx/gyWWwVLWUT8RxcgX55GBLRGrEZRa/z0j8Syr9WnaaiKaALvWkwrs0v5YjNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=dmO4al9S; arc=none smtp.client-ip=209.85.160.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="dmO4al9S" Received: by mail-oa1-f97.google.com with SMTP id 586e51a60fabf-40850555c56so249742fac.3 for ; Fri, 20 Feb 2026 19:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771644787; x=1772249587; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=chF3cAD1j09EpR3bM9lUaumkQDJZpAeYYRmoTp9QLII=; b=dmO4al9SgfOyjwqu0/iOj7Le/SawTajJR+/c4GoUvuveQUvjVL44o8uoXcEKDuV3tx bA5ACL7NCDjozXD0XR8BBjE1bJk33Qkt18ZCtidvUVuIyqAXz4v6H97fZNSae9eY8a7P ZN6LL0zcEtMSzkdU5b1Tsqw43TvrGhvHQY1EiIW/1Aq7BKDYkVyndTezNKOZOddp6KHw MHxF2828klSMH+g1C7eXM5oWTu+oPEWxBTdi6+/CrnwuSBsbJWBmoR0LpcP0Ha8i5F7W N0FbBQZhOBOS4SqNXaOsgP1GEailoeTzY4/bM7YUDu1i7jA4AkToF3EmgKmd2Ji4DZ6S pxGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771644787; x=1772249587; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=chF3cAD1j09EpR3bM9lUaumkQDJZpAeYYRmoTp9QLII=; b=ewQfiAQeDoKFPVCtucCG1DrkkLoYoxI95R1tIKoovjWq0ywPpo9mVynT94ffK62sDC KgpWT1rfvUQP0amP2tJ9hs2vtvFZwaCPGgkXLT4vnH5FTt8hoTL6CFi54x+/sh2mjQ2B UPV6QBqAiE4ZKBI0SgYdPoSNu+Ag+RQ2wUdZrnwZixNlPD3HT5HC278/BPpWHREMfkA+ 7PuomdE1R4gMVq7DBSJngJY61sHKglXv2+9bbtvXB3GegvwVl94YOnd6UWTHbjs7bFXJ 5uv0GzNQGQCP339gyHR10lY89EUhU7CIK+/sE8n+7+h0pWr+i340I0Cba8suWy4+zhjz QySg== X-Forwarded-Encrypted: i=1; AJvYcCU7BXtLNyeozcQ5vwvqitcmEW64s/PlgBSdlNEAFqq9kms8UGTAePNVX9cbci8dQDukEnqd+9LSUS0zhpw=@vger.kernel.org X-Gm-Message-State: AOJu0YyUD/KOaGVQCiuHDNtrV+VVeDJ89YTQ71U4e6W90IR4DKkpwcZT pryX7/yYJUOrwzmIH8OsyHZq59vQcjUDhYamWPTv/i9/UoCC3uXF02I3Tirp+FYwRNz5FA82VgL hvn3PrXuPr4lrn4/KT+8YmAfN9aOPEyybB0i+yVYWFS1egqaVZqI5 X-Gm-Gg: AZuq6aKeBTTgc+iJQe4Nj2zpTFR1zzNRtq0i7KBckMkF/zQFTa6R2QOoPdkugO/kh3L CeKx52is7GPY8OnL0gBltsR30qJicmwjxr2QhQnXx4VQVKJTXzhwkBwirx6qmg16AdzXmRWRLrE BVQkv7GxajYAhO7pQ8IK/AJn2vJGBOFDotoh4Rd4nvNvwwAfAhOx6+bJT8Dqzp91Uey9WrB0UOM NJGmpykK0qO8U7jMKvQoZt+XK1Lm/+q+HITsgJadesXtaz0O6C9i9JWa/BZBgjJSAWJG4vKGBE3 Sxu/NmHE/7OhAX6acGePZlXoEEx1Op/QSghk0iqteuwISD5JRlUz+91CqXNgOmBpxZtJYFX9DGN PV/8zbyI71ylN6zHtYWQWrQkUnig3y6tXbyoxJoI= X-Received: by 2002:a05:6870:41cd:b0:3e8:304e:b0eb with SMTP id 586e51a60fabf-4157b135a66mr921056fac.5.1771644787385; Fri, 20 Feb 2026 19:33:07 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-4157cd86b54sm189672fac.7.2026.02.20.19.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 19:33:07 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 2A58F342181; Fri, 20 Feb 2026 20:33:06 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 203BFE427CB; Fri, 20 Feb 2026 20:33:06 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v2 6/7] nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT Date: Fri, 20 Feb 2026 20:33:01 -0700 Message-ID: <20260221033302.1451669-7-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260221033302.1451669-1-csander@purestorage.com> References: <20260221033302.1451669-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use the NVME_NS_FEAT_OPTPERF_SHIFT constant in nvmet_bdev_set_limits() to set the OPTPERF bits of the nvme_id_ns NSFEAT field instead of the magic number 4. Signed-off-by: Caleb Sander Mateos Reviewed-by: Christoph Hellwig --- drivers/nvme/target/io-cmd-bdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c index 8d246b8ca604..d94f885a56d9 100644 --- a/drivers/nvme/target/io-cmd-bdev.c +++ b/drivers/nvme/target/io-cmd-bdev.c @@ -28,15 +28,15 @@ void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id) id->nawun = lpp0b; id->nawupf = lpp0b; id->nacwu = lpp0b; /* - * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and + * OPTPERF = 01b indicates that the fields NPWG, NPWA, NPDG, NPDA, and * NOWS are defined for this namespace and should be used by * the host for I/O optimization. */ - id->nsfeat |= 1 << 4; + id->nsfeat |= 0x1 << NVME_NS_FEAT_OPTPERF_SHIFT; /* NPWG = Namespace Preferred Write Granularity. 0's based */ id->npwg = to0based(bdev_io_min(bdev) / bdev_logical_block_size(bdev)); /* NPWA = Namespace Preferred Write Alignment. 0's based */ id->npwa = id->npwg; /* NPDG = Namespace Preferred Deallocate Granularity. 0's based */ -- 2.45.2