public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Taha Ed-Dafili <0rayn.dev@gmail.com>
To: linux-iio@vger.kernel.org, jic23@kernel.org
Cc: dlechner@baylibre.com, rdunlap@infradead.org,
	skhan@linuxfoundation.org,
	linux-kernel-mentees-archive@lists.linuxfoundation.org,
	nuno.sa@analog.com, andy@kernel.org, corbet@lwn.net,
	lars@metafoo.de, Michael.Hennerich@analog.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Taha Ed-Dafili <0rayn.dev@gmail.com>
Subject: [PATCH v4 0/4] iio: accel: adxl345: Implement event scaling and ABI compliance
Date: Sat, 21 Feb 2026 14:12:43 +0000	[thread overview]
Message-ID: <20260221141251.34855-1-0rayn.dev@gmail.com> (raw)

This series addresses ADXL345 driver non-compliance with the IIO ABI for
event thresholds.

Currently, the driver exposes raw values for thresholds
(e.g., tap, activity) without providing the necessary scale factor to
convert them to SI units (m/s^2), as mandated by the ABI.

This series implements `IIO_EV_INFO_SCALE` in the IIO core and applies it
to the ADXL345 driver, ensuring that userspace can correctly interpret
threshold values. It also cleans up existing documentation errors and
typos.

Changes in v4:
- Patch 3: Fix missing IIO_EV_INFO_SCALE handling for MAG/MAG_ADAPTIVE
  events by moving the check to the top of adxl345_read_event_value().
- Patch 3: Explicitly reject writes to IIO_EV_INFO_SCALE with -EINVAL.
- Patch 3: Fix bitmask ordering and whitespace alignment in event spec
  arrays.
- Patch 4: Update documentation table with the exact sysfs scale
  attributes generated by the IIO core.
- Patch 4: Sort the entire event attribute table alphabetically
  (David Lechner).

Changes in v3:
- Patch 1: Revert "axis" to "axes" in documentation.
- Patch 2: Reword commit message to "Implement support for".
- Patch 4: Remove repetitive scale values from every table row.
- Patch 4: Fix typo in commit message.

Changes in v2:
- Add core infrastructure for IIO_EV_INFO_SCALE.
- Implement event scaling (0.612915 m/s^2) for ADXL345.
- Fix technical math and decimal errors in documentation.
- Clean up grammar and pluralization in .rst file.

I would like to thank Jonathan Cameron for catching the missing MAG scale
handling via static analysis, David Lechner for the alphabetical and
bitmask ordering feedback, and Andy Shevchenko and Randy Dunlap for
catching the whitespace inconsistencies.

Taha Ed-Dafili (4):
  docs: iio: adxl345: fix typos and grammar
  iio: core: Add IIO_EV_INFO_SCALE to event info
  iio: accel: adxl345: Implement event scaling for ABI compliance
  docs: iio: adxl345: update math and examples for scaling

 Documentation/iio/adxl345.rst    | 79 ++++++++++++++++++++------------
 drivers/iio/accel/adxl345_core.c | 37 ++++++++++-----
 drivers/iio/industrialio-event.c |  1 +
 include/linux/iio/types.h        |  1 +
 4 files changed, 78 insertions(+), 40 deletions(-)

-- 
2.47.3


             reply	other threads:[~2026-02-21 14:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-21 14:12 Taha Ed-Dafili [this message]
2026-02-21 14:12 ` [PATCH v4 1/4] docs: iio: adxl345: fix typos and grammar Taha Ed-Dafili
2026-02-21 14:12 ` [PATCH v4 2/4] iio: core: Add IIO_EV_INFO_SCALE to event info Taha Ed-Dafili
2026-02-21 14:12 ` [PATCH v4 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance Taha Ed-Dafili
2026-02-21 16:47   ` David Lechner
2026-02-21 17:21     ` Taha Ed-Dafili
2026-02-22 16:11       ` Jonathan Cameron
2026-02-21 14:12 ` [PATCH v4 4/4] docs: iio: adxl345: update math and examples for scaling Taha Ed-Dafili
2026-02-21 16:50   ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260221141251.34855-1-0rayn.dev@gmail.com \
    --to=0rayn.dev@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees-archive@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox